* [PATCH -next] virt: vbox: simplify the return expression of vbg_input_open()
@ 2020-09-21 13:11 Qinglang Miao
2020-09-21 13:33 ` Hans de Goede
0 siblings, 1 reply; 2+ messages in thread
From: Qinglang Miao @ 2020-09-21 13:11 UTC (permalink / raw)
To: Hans de Goede, Arnd Bergmann, Greg Kroah-Hartman
Cc: linux-kernel, Qinglang Miao
Simplify the return expression.
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
drivers/virt/vboxguest/vboxguest_linux.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
index 6215a688e..73eb34849 100644
--- a/drivers/virt/vboxguest/vboxguest_linux.c
+++ b/drivers/virt/vboxguest/vboxguest_linux.c
@@ -202,13 +202,8 @@ static int vbg_input_open(struct input_dev *input)
{
struct vbg_dev *gdev = input_get_drvdata(input);
u32 feat = VMMDEV_MOUSE_GUEST_CAN_ABSOLUTE | VMMDEV_MOUSE_NEW_PROTOCOL;
- int ret;
- ret = vbg_core_set_mouse_status(gdev, feat);
- if (ret)
- return ret;
-
- return 0;
+ return vbg_core_set_mouse_status(gdev, feat);
}
/**
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] virt: vbox: simplify the return expression of vbg_input_open()
2020-09-21 13:11 [PATCH -next] virt: vbox: simplify the return expression of vbg_input_open() Qinglang Miao
@ 2020-09-21 13:33 ` Hans de Goede
0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2020-09-21 13:33 UTC (permalink / raw)
To: Qinglang Miao, Arnd Bergmann, Greg Kroah-Hartman; +Cc: linux-kernel
Hi,
On 9/21/20 3:11 PM, Qinglang Miao wrote:
> Simplify the return expression.
>
> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Thank you, patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/virt/vboxguest/vboxguest_linux.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/virt/vboxguest/vboxguest_linux.c b/drivers/virt/vboxguest/vboxguest_linux.c
> index 6215a688e..73eb34849 100644
> --- a/drivers/virt/vboxguest/vboxguest_linux.c
> +++ b/drivers/virt/vboxguest/vboxguest_linux.c
> @@ -202,13 +202,8 @@ static int vbg_input_open(struct input_dev *input)
> {
> struct vbg_dev *gdev = input_get_drvdata(input);
> u32 feat = VMMDEV_MOUSE_GUEST_CAN_ABSOLUTE | VMMDEV_MOUSE_NEW_PROTOCOL;
> - int ret;
>
> - ret = vbg_core_set_mouse_status(gdev, feat);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return vbg_core_set_mouse_status(gdev, feat);
> }
>
> /**
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-21 13:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-21 13:11 [PATCH -next] virt: vbox: simplify the return expression of vbg_input_open() Qinglang Miao
2020-09-21 13:33 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®