mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Garry <john.g.garry@oracle.com>
To: Jason Yan <yanaijie@huawei.com>,
	yangxingui <yangxingui@huawei.com>,
	jejb@linux.ibm.com, martin.petersen@oracle.com,
	damien.lemoal@opensource.wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	linuxarm@huawei.com, prime.zeng@hisilicon.com,
	chenxiang66@hisilicon.com, kangfenglong@huawei.com
Subject: Re: [PATCH] scsi: libsas: Fix disk not being scanned in after being removed
Date: Tue, 27 Feb 2024 09:06:19 +0000	[thread overview]
Message-ID: <7d132b63-7336-4f59-a5f0-5ec37c3c34d3@oracle.com> (raw)
In-Reply-To: <8138ab55-1c43-8df1-dafd-95b16b7b3ce4@huawei.com>

On 27/02/2024 07:16, Jason Yan wrote:
>>>
>>> Can we directly set phy->negotiated_linkrate = SAS_PHY_DISABLED here? 
>>> For an empty PHY the other variables means nothing, so why bother get 
>>> and update them?
>> The value of the negotiated link rate has two possible values ​​in the 
>> current processing branch: SAS_LINK_RATE_UNKNOWN and SAS_PHY_DISABLED, 
>> and both come from disc_resp. If we do not use disc_resp, but set a 
>> fixed value SAS_PHY_DISABLED for it, it may not be appropriate.

But we know that the phy is disabled, right? It's our phy, isn't it?

Thanks,
John


  reply	other threads:[~2024-02-27  9:06 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-21  7:31 Xingui Yang
2024-02-22 12:41 ` John Garry
2024-02-23  4:04   ` yangxingui
2024-02-23  7:04     ` Jason Yan
2024-02-27  3:06       ` yangxingui
2024-02-27  7:16         ` Jason Yan
2024-02-27  9:06           ` John Garry [this message]
2024-02-27  9:42             ` yangxingui
2024-02-28 13:13   ` yangxingui
2024-02-28 16:26     ` John Garry
2024-02-28 18:13 ` John Garry
2024-03-01  1:55   ` Jason Yan
2024-03-04 12:50     ` yangxingui
2024-03-05  2:56       ` Jason Yan
2024-03-05 10:15         ` John Garry
2024-03-05 11:25           ` yangxingui
2024-03-06 17:57             ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d132b63-7336-4f59-a5f0-5ec37c3c34d3@oracle.com \
    --to=john.g.garry@oracle.com \
    --cc=chenxiang66@hisilicon.com \
    --cc=damien.lemoal@opensource.wdc.com \
    --cc=jejb@linux.ibm.com \
    --cc=kangfenglong@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    --cc=prime.zeng@hisilicon.com \
    --cc=yanaijie@huawei.com \
    --cc=yangxingui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®