From: Rodolfo Giometti <giometti@enneenne.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org
Cc: Ryan Govostes <rgovostes@whoi.edu>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH resend v1 4/7] pps: clients: gpio: Get rid of legacy platform data
Date: Tue, 9 Mar 2021 13:25:59 +0100 [thread overview]
Message-ID: <7d336ff8-25b8-e4f1-ec43-09e9414660a4@enneenne.com> (raw)
In-Reply-To: <20210309112403.36633-4-andriy.shevchenko@linux.intel.com>
On 09/03/21 12:24, Andy Shevchenko wrote:
> Platform data is a legacy interface to supply device properties
> to the driver. In this case we even don't have in-kernel users
> for it. Just remove it for good.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/pps/clients/pps-gpio.c | 17 +++--------------
> include/linux/pps-gpio.h | 19 -------------------
> 2 files changed, 3 insertions(+), 33 deletions(-)
> delete mode 100644 include/linux/pps-gpio.h
>
> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
> index dc9ed6fc3dae..291240dce79e 100644
> --- a/drivers/pps/clients/pps-gpio.c
> +++ b/drivers/pps/clients/pps-gpio.c
> @@ -16,7 +16,6 @@
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #include <linux/pps_kernel.h>
> -#include <linux/pps-gpio.h>
> #include <linux/gpio/consumer.h>
> #include <linux/list.h>
> #include <linux/of_device.h>
> @@ -164,7 +163,6 @@ static int pps_gpio_probe(struct platform_device *pdev)
> struct pps_gpio_device_data *data;
> int ret;
> int pps_default_params;
> - const struct pps_gpio_platform_data *pdata = pdev->dev.platform_data;
>
> /* allocate space for device info */
> data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
> @@ -173,18 +171,9 @@ static int pps_gpio_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, data);
>
> /* GPIO setup */
> - if (pdata) {
> - data->gpio_pin = pdata->gpio_pin;
> - data->echo_pin = pdata->echo_pin;
> -
> - data->assert_falling_edge = pdata->assert_falling_edge;
> - data->capture_clear = pdata->capture_clear;
> - data->echo_active_ms = pdata->echo_active_ms;
> - } else {
> - ret = pps_gpio_setup(pdev);
> - if (ret)
> - return -EINVAL;
> - }
> + ret = pps_gpio_setup(pdev);
> + if (ret)
> + return -EINVAL;
>
> /* IRQ setup */
> ret = gpiod_to_irq(data->gpio_pin);
> diff --git a/include/linux/pps-gpio.h b/include/linux/pps-gpio.h
> deleted file mode 100644
> index 7bf49908be06..000000000000
> --- a/include/linux/pps-gpio.h
> +++ /dev/null
> @@ -1,19 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0-or-later */
> -/*
> - * pps-gpio.h -- PPS client for GPIOs
> - *
> - * Copyright (C) 2011 James Nuss <jamesnuss@nanometrics.ca>
> - */
> -
> -#ifndef _PPS_GPIO_H
> -#define _PPS_GPIO_H
> -
> -struct pps_gpio_platform_data {
> - struct gpio_desc *gpio_pin;
> - struct gpio_desc *echo_pin;
> - bool assert_falling_edge;
> - bool capture_clear;
> - unsigned int echo_active_ms;
> -};
> -
> -#endif /* _PPS_GPIO_H */
>
Acked-by: Rodolfo Giometti <giometti@enneenne.com>
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
next prev parent reply other threads:[~2021-03-09 12:26 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 11:23 [PATCH resend v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line Andy Shevchenko
2021-03-09 11:23 ` [PATCH resend v1 2/7] pps: clients: gpio: Use dev_err_probe() to avoid log noise Andy Shevchenko
2021-03-09 12:25 ` Rodolfo Giometti
2021-03-09 11:23 ` [PATCH resend v1 3/7] pps: clients: gpio: Remove redundant condition in ->remove() Andy Shevchenko
2021-03-09 12:25 ` Rodolfo Giometti
2021-03-09 11:24 ` [PATCH resend v1 4/7] pps: clients: gpio: Get rid of legacy platform data Andy Shevchenko
2021-03-09 12:25 ` Rodolfo Giometti [this message]
2021-03-09 11:24 ` [PATCH resend v1 5/7] pps: clients: gpio: Make use of device properties Andy Shevchenko
2021-03-09 12:27 ` Rodolfo Giometti
2021-03-09 11:24 ` [PATCH resend v1 6/7] pps: clients: gpio: Use struct device pointer directly Andy Shevchenko
2021-03-09 12:30 ` Rodolfo Giometti
2021-03-09 11:24 ` [PATCH resend v1 7/7] pps: clients: gpio: Rearrange optional stuff in pps_gpio_setup() Andy Shevchenko
2021-03-09 12:30 ` Rodolfo Giometti
2021-03-09 12:23 ` [PATCH resend v1 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line Rodolfo Giometti
2021-03-15 12:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d336ff8-25b8-e4f1-ec43-09e9414660a4@enneenne.com \
--to=giometti@enneenne.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rgovostes@whoi.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®