mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yi Zhang" <yizhanghust@163.com>
To: broonie@kernel.org, lgirdwood@gmail.com
Cc: linux-kernel@vger.kernel.org, yizhang@marvell.com,
	zhenzh@marvell.com, zhouqiao@marvell.com
Subject: [Question] should we export set_suspend_voltage()?
Date: Fri, 6 Feb 2015 10:57:49 +0800 (CST)	[thread overview]
Message-ID: <7d3ec992.e522.14b5cd26cf6.Coremail.yizhanghust@163.com> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 1183 bytes --]


Hi, Liam & Mark:


seems at present, the set_suspend_voltage() is designed to cover the suspend voltage handling from board level, when the system enters into the suspend;
but the behavior of my chip is as following:
a) there are two sets of registers to configure one regulator's voltage separately, one is for active mode, the other is for the low power mode, say, suspend-to-ram;
b) both of the sets have control bits independently;
c) once the low power mode is triggered, by external signal, for example, pull-down a gpio, the regulator switches to use the registers for low power mode;
d) the consumers have different requirements for the voltage in low power mode according to different scenario, IOW, we cannot assume a fix value when system boots up;

So 
do you think it's good to export the set_suspend_voltage()? to make it controllable by the regulator itself?
another method in my opinion is add a set of virtual-regulator for this usage?

could you please share your advice?

thanks very much;

--
Yi Zhangÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

             reply	other threads:[~2015-02-06  3:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06  2:57 Yi Zhang [this message]
2015-02-06 22:10 ` Mark Brown
2015-02-09  7:37   ` Yi Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d3ec992.e522.14b5cd26cf6.Coremail.yizhanghust@163.com \
    --to=yizhanghust@163.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=yizhang@marvell.com \
    --cc=zhenzh@marvell.com \
    --cc=zhouqiao@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®