* [PATCH v1] ARM: dts: rockchip: rk3288: move edp assigned-clocks to edp node
@ 2025-11-01 23:18 Johan Jonker
2025-11-13 23:04 ` Heiko Stuebner
0 siblings, 1 reply; 2+ messages in thread
From: Johan Jonker @ 2025-11-01 23:18 UTC (permalink / raw)
To: heiko
Cc: robh, conor+dt, krzk+dt, devicetree, linux-arm-kernel,
linux-rockchip, linux-kernel
The rk3288 power-controller node contains an assigned-clocks property
that conflicts with the bindings. From the git history it shows that they
wanted to assign the rk3288 EDP_24M clock input centrally before an edp
node was available. Move the edp assigned-clocks property to the edp node
to reduce dtbs_check output.
Signed-off-by: Johan Jonker <jbx6244@gmail.com>
---
Not tested with hardware.
ARM: dts: rockchip: Assign RK3288 EDP_24M input centrally
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/rk3288.dtsi?id=df5ea015984633526874619ca1288fc5f2cf47c0
ARM: dts: rockchip: add rk3288 displayport controller node
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/rk3288.dtsi?id=6df7ec6186644a4ffb4f0c859327ef41a1145a5f
ARM: dts: rockchip: add rk3288 edp-phy node
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/rk3288.dtsi?id=f5663969d8125a5c5b7835812e1e636ecedf030b
ARM: dts: rockchip: move rk3288 edp phy under the GRF
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/rk3288.dtsi?id=4b91545072ad7ca1963d2a89c8b42fc2eb561484
---
arch/arm/boot/dts/rockchip/rk3288.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/boot/dts/rockchip/rk3288.dtsi b/arch/arm/boot/dts/rockchip/rk3288.dtsi
index 7e284b4fecdc..7477fc5da3ec 100644
--- a/arch/arm/boot/dts/rockchip/rk3288.dtsi
+++ b/arch/arm/boot/dts/rockchip/rk3288.dtsi
@@ -741,9 +741,6 @@ power: power-controller {
#address-cells = <1>;
#size-cells = <0>;
- assigned-clocks = <&cru SCLK_EDP_24M>;
- assigned-clock-parents = <&xin24m>;
-
/*
* Note: Although SCLK_* are the working clocks
* of device without including on the NOC, needed for
@@ -1193,6 +1190,8 @@ edp: dp@ff970000 {
compatible = "rockchip,rk3288-dp";
reg = <0x0 0xff970000 0x0 0x4000>;
interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>;
+ assigned-clocks = <&cru SCLK_EDP_24M>;
+ assigned-clock-parents = <&xin24m>;
clocks = <&cru SCLK_EDP>, <&cru PCLK_EDP_CTRL>;
clock-names = "dp", "pclk";
phys = <&edp_phy>;
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v1] ARM: dts: rockchip: rk3288: move edp assigned-clocks to edp node
2025-11-01 23:18 [PATCH v1] ARM: dts: rockchip: rk3288: move edp assigned-clocks to edp node Johan Jonker
@ 2025-11-13 23:04 ` Heiko Stuebner
0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2025-11-13 23:04 UTC (permalink / raw)
To: Johan Jonker
Cc: Heiko Stuebner, robh, conor+dt, krzk+dt, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
On Sun, 02 Nov 2025 00:18:13 +0100, Johan Jonker wrote:
> The rk3288 power-controller node contains an assigned-clocks property
> that conflicts with the bindings. From the git history it shows that they
> wanted to assign the rk3288 EDP_24M clock input centrally before an edp
> node was available. Move the edp assigned-clocks property to the edp node
> to reduce dtbs_check output.
>
>
> [...]
Applied, thanks!
[1/1] ARM: dts: rockchip: rk3288: move edp assigned-clocks to edp node
commit: 10712ce694a67304a99dbba20f8cb146ca5f4fd6
Best regards,
--
Heiko Stuebner <heiko@sntech.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-11-13 23:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-01 23:18 [PATCH v1] ARM: dts: rockchip: rk3288: move edp assigned-clocks to edp node Johan Jonker
2025-11-13 23:04 ` Heiko Stuebner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®