mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baochen Qiang <baochen.qiang@oss.qualcomm.com>
To: Guangshuo Li <lgs201920130244@gmail.com>,
	Jeff Johnson <jjohnson@kernel.org>,
	Pradeep Kumar Chitrapu <quic_pradeepc@quicinc.com>,
	Vasanthakumar Thiagarajan <quic_vthiagar@quicinc.com>,
	Sathishkumar Muruganandam <quic_murugana@quicinc.com>,
	Anilkumar Kolli <quic_akolli@quicinc.com>,
	Ganesh Sesetti <gseset@codeaurora.org>,
	linux-wireless@vger.kernel.org, ath11k@lists.infradead.org,
	linux-kernel@vger.kernel.org, ath12k@lists.infradead.org
Subject: Re: [PATCH v3 0/2] wifi: ath11k/ath12k: release QMI handles on late init failures
Date: Mon, 20 Jul 2026 10:20:02 +0800	[thread overview]
Message-ID: <7d76cc32-5022-48c1-b33d-f16521ab5b7a@oss.qualcomm.com> (raw)
In-Reply-To: <20260718074026.3085688-1-lgs201920130244@gmail.com>



On 7/18/2026 3:40 PM, Guangshuo Li wrote:
> This series fixes QMI handle leaks in the late initialization failure
> paths of ath11k and ath12k.
> 
> Both drivers initialize the QMI handle before allocating the QMI event
> workqueue and registering the service lookup. If either of these later
> steps fails, the initialized QMI handle is not released.
> 
> Patch 1 fixes the leak in ath11k.
> 
> Patch 2 fixes the leak in ath12k and sets ab->qmi.ab only after QMI
> service initialization completes successfully.
> 
> v3:
>   - Split the ath11k and ath12k changes into separate patches, as
>     requested by Jeff Johnson.
> 
> v2:
>   - Set ath12k ab->qmi.ab only after QMI service initialization succeeds,
>     as suggested by Baochen Qiang.
>   - Fix the same late initialization QMI handle leak in ath11k, as
>     suggested by Vasanthakumar Thiagarajan.
>   - Drop the Reviewed-by tag due to the code changes.
> 
> Guangshuo Li (2):
>   wifi: ath11k: release QMI handle on late init failures
>   wifi: ath12k: release QMI handle on late init failures
> 
>  drivers/net/wireless/ath/ath11k/qmi.c | 10 ++++++++--
>  drivers/net/wireless/ath/ath12k/qmi.c | 13 ++++++++++---
>  2 files changed, 18 insertions(+), 5 deletions(-)
> 

Reviewed-by: Baochen Qiang <baochen.qiang@oss.qualcomm.com>


      parent reply	other threads:[~2026-07-20  2:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-18  7:40 Guangshuo Li
2026-07-18  7:40 ` [PATCH v3 1/2] wifi: ath11k: release QMI handle " Guangshuo Li
2026-07-24  1:02   ` Jeff Johnson
2026-07-18  7:40 ` [PATCH v3 2/2] wifi: ath12k: " Guangshuo Li
2026-07-20  2:20 ` Baochen Qiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7d76cc32-5022-48c1-b33d-f16521ab5b7a@oss.qualcomm.com \
    --to=baochen.qiang@oss.qualcomm.com \
    --cc=ath11k@lists.infradead.org \
    --cc=ath12k@lists.infradead.org \
    --cc=gseset@codeaurora.org \
    --cc=jjohnson@kernel.org \
    --cc=lgs201920130244@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_akolli@quicinc.com \
    --cc=quic_murugana@quicinc.com \
    --cc=quic_pradeepc@quicinc.com \
    --cc=quic_vthiagar@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®