From: Hans de Goede <hdegoede@redhat.com>
To: Ai Chao <aichao@kylinos.cn>,
ilpo.jarvinen@linux.intel.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] platform/x86: huawei-wmi: use sysfs_emit() instead of sprintf()
Date: Mon, 25 Mar 2024 15:42:39 +0100 [thread overview]
Message-ID: <7d7c3357-48a1-4479-9365-19fb3e9ddf0a@redhat.com> (raw)
In-Reply-To: <20240319064243.297320-1-aichao@kylinos.cn>
Hi,
On 3/19/24 7:42 AM, Ai Chao wrote:
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
>
> Signed-off-by: Ai Chao <aichao@kylinos.cn>
Thank you for your patch, I've applied this patch to my review-hans
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans
> ---
> drivers/platform/x86/huawei-wmi.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
> index dde139c69945..09d476dd832e 100644
> --- a/drivers/platform/x86/huawei-wmi.c
> +++ b/drivers/platform/x86/huawei-wmi.c
> @@ -379,7 +379,7 @@ static ssize_t charge_control_start_threshold_show(struct device *dev,
> if (err)
> return err;
>
> - return sprintf(buf, "%d\n", start);
> + return sysfs_emit(buf, "%d\n", start);
> }
>
> static ssize_t charge_control_end_threshold_show(struct device *dev,
> @@ -392,7 +392,7 @@ static ssize_t charge_control_end_threshold_show(struct device *dev,
> if (err)
> return err;
>
> - return sprintf(buf, "%d\n", end);
> + return sysfs_emit(buf, "%d\n", end);
> }
>
> static ssize_t charge_control_thresholds_show(struct device *dev,
> @@ -405,7 +405,7 @@ static ssize_t charge_control_thresholds_show(struct device *dev,
> if (err)
> return err;
>
> - return sprintf(buf, "%d %d\n", start, end);
> + return sysfs_emit(buf, "%d %d\n", start, end);
> }
>
> static ssize_t charge_control_start_threshold_store(struct device *dev,
> @@ -562,7 +562,7 @@ static ssize_t fn_lock_state_show(struct device *dev,
> if (err)
> return err;
>
> - return sprintf(buf, "%d\n", on);
> + return sysfs_emit(buf, "%d\n", on);
> }
>
> static ssize_t fn_lock_state_store(struct device *dev,
prev parent reply other threads:[~2024-03-25 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-19 6:42 Ai Chao
2024-03-25 14:42 ` Hans de Goede [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d7c3357-48a1-4479-9365-19fb3e9ddf0a@redhat.com \
--to=hdegoede@redhat.com \
--cc=aichao@kylinos.cn \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®