mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v1] platform/x86: huawei-wmi: use sysfs_emit() instead of sprintf()
@ 2024-03-19  6:42 Ai Chao
  2024-03-25 14:42 ` Hans de Goede
  0 siblings, 1 reply; 2+ messages in thread
From: Ai Chao @ 2024-03-19  6:42 UTC (permalink / raw)
  To: hdegoede, ilpo.jarvinen, platform-driver-x86, linux-kernel; +Cc: Ai Chao

Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: Ai Chao <aichao@kylinos.cn>
---
 drivers/platform/x86/huawei-wmi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
index dde139c69945..09d476dd832e 100644
--- a/drivers/platform/x86/huawei-wmi.c
+++ b/drivers/platform/x86/huawei-wmi.c
@@ -379,7 +379,7 @@ static ssize_t charge_control_start_threshold_show(struct device *dev,
 	if (err)
 		return err;
 
-	return sprintf(buf, "%d\n", start);
+	return sysfs_emit(buf, "%d\n", start);
 }
 
 static ssize_t charge_control_end_threshold_show(struct device *dev,
@@ -392,7 +392,7 @@ static ssize_t charge_control_end_threshold_show(struct device *dev,
 	if (err)
 		return err;
 
-	return sprintf(buf, "%d\n", end);
+	return sysfs_emit(buf, "%d\n", end);
 }
 
 static ssize_t charge_control_thresholds_show(struct device *dev,
@@ -405,7 +405,7 @@ static ssize_t charge_control_thresholds_show(struct device *dev,
 	if (err)
 		return err;
 
-	return sprintf(buf, "%d %d\n", start, end);
+	return sysfs_emit(buf, "%d %d\n", start, end);
 }
 
 static ssize_t charge_control_start_threshold_store(struct device *dev,
@@ -562,7 +562,7 @@ static ssize_t fn_lock_state_show(struct device *dev,
 	if (err)
 		return err;
 
-	return sprintf(buf, "%d\n", on);
+	return sysfs_emit(buf, "%d\n", on);
 }
 
 static ssize_t fn_lock_state_store(struct device *dev,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v1] platform/x86: huawei-wmi: use sysfs_emit() instead of sprintf()
  2024-03-19  6:42 [PATCH v1] platform/x86: huawei-wmi: use sysfs_emit() instead of sprintf() Ai Chao
@ 2024-03-25 14:42 ` Hans de Goede
  0 siblings, 0 replies; 2+ messages in thread
From: Hans de Goede @ 2024-03-25 14:42 UTC (permalink / raw)
  To: Ai Chao, ilpo.jarvinen, platform-driver-x86, linux-kernel

Hi,

On 3/19/24 7:42 AM, Ai Chao wrote:
> Follow the advice in Documentation/filesystems/sysfs.rst:
> show() should only use sysfs_emit() or sysfs_emit_at() when formatting
> the value to be returned to user space.
> 
> Signed-off-by: Ai Chao <aichao@kylinos.cn>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  drivers/platform/x86/huawei-wmi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/x86/huawei-wmi.c b/drivers/platform/x86/huawei-wmi.c
> index dde139c69945..09d476dd832e 100644
> --- a/drivers/platform/x86/huawei-wmi.c
> +++ b/drivers/platform/x86/huawei-wmi.c
> @@ -379,7 +379,7 @@ static ssize_t charge_control_start_threshold_show(struct device *dev,
>  	if (err)
>  		return err;
>  
> -	return sprintf(buf, "%d\n", start);
> +	return sysfs_emit(buf, "%d\n", start);
>  }
>  
>  static ssize_t charge_control_end_threshold_show(struct device *dev,
> @@ -392,7 +392,7 @@ static ssize_t charge_control_end_threshold_show(struct device *dev,
>  	if (err)
>  		return err;
>  
> -	return sprintf(buf, "%d\n", end);
> +	return sysfs_emit(buf, "%d\n", end);
>  }
>  
>  static ssize_t charge_control_thresholds_show(struct device *dev,
> @@ -405,7 +405,7 @@ static ssize_t charge_control_thresholds_show(struct device *dev,
>  	if (err)
>  		return err;
>  
> -	return sprintf(buf, "%d %d\n", start, end);
> +	return sysfs_emit(buf, "%d %d\n", start, end);
>  }
>  
>  static ssize_t charge_control_start_threshold_store(struct device *dev,
> @@ -562,7 +562,7 @@ static ssize_t fn_lock_state_show(struct device *dev,
>  	if (err)
>  		return err;
>  
> -	return sprintf(buf, "%d\n", on);
> +	return sysfs_emit(buf, "%d\n", on);
>  }
>  
>  static ssize_t fn_lock_state_store(struct device *dev,


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-03-25 14:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-19  6:42 [PATCH v1] platform/x86: huawei-wmi: use sysfs_emit() instead of sprintf() Ai Chao
2024-03-25 14:42 ` Hans de Goede

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®