From: Markus Elfring <Markus.Elfring@web.de>
To: Pei Xiao <xiaopei01@kylinos.cn>,
linux-wireless@vger.kernel.org, Kalle Valo <kvalo@kernel.org>,
Ping-Ke Shih <pkshih@realtek.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
xiaopeitux@foxmail.com, xiongxin@kylinos.cn
Subject: Re: [PATCH] net: wireless: realtek/rtw89: Add check null return of kmalloc
Date: Tue, 29 Oct 2024 21:37:13 +0100 [thread overview]
Message-ID: <7d8df935-d1b2-4416-88e1-052113038f54@web.de> (raw)
In-Reply-To: <82dd45fe7faed8f558841643a0593202b2da90c5.1730192926.git.xiaopei01@kylinos.cn>
> kmalloc may fail, return might be NULL and will cause
value?
> NULL pointer dereference later.
* An imperative wording is more desirable for such a change description,
isn't it?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n94
* Would you like to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.12-rc5#n145
Regards,
Markus
prev parent reply other threads:[~2024-10-29 20:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 9:12 Pei Xiao
2024-10-29 10:33 ` Kalle Valo
2024-10-30 0:35 ` Ping-Ke Shih
2024-10-30 3:12 ` Pei Xiao
2024-10-30 3:13 ` Pei Xiao
2024-10-29 20:37 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d8df935-d1b2-4416-88e1-052113038f54@web.de \
--to=markus.elfring@web.de \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=xiaopei01@kylinos.cn \
--cc=xiaopeitux@foxmail.com \
--cc=xiongxin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®