From: Pei Xiao <xiaopei01@kylinos.cn>
To: 425562414@qq.com, Ping-Ke Shih <pkshih@realtek.com>,
Kalle Valo <kvalo@kernel.org>
Cc: Pei Xiao <xiaopei01@kylinos.cn>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xiaopeitux@foxmail.com" <xiaopeitux@foxmail.com>,
"xiongxin@kylinos.cn" <xiongxin@kylinos.cn>
Subject: Re: [PATCH] net: wireless: realtek/rtw89: Add check null return of\r kmalloc
Date: Wed, 30 Oct 2024 11:12:22 +0800 [thread overview]
Message-ID: <1728e9f5-0d4c-481f-8f85-9e4d74ab4ee5@kylinos.cn> (raw)
In-Reply-To: <4f5eee8cb4024571a9a78af97aecab67@realtek.com>
On 2024/10/30 08:35, Ping-Ke Shih wrote:
> Kalle Valo <kvalo@kernel.org> wrote:
>> Pei Xiao <xiaopei01@kylinos.cn> writes:
>>
>>> kmalloc may fail, return might be NULL and will cause
>>> NULL pointer dereference later.
>>>
>>> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
>>
>> We use 'wifi: rtw89:' in the title, please check the documentation below
>> for more.
>>
>
> A way to known subject prefix is to use git log with the files touched by
> this patch:
> git log --oneline drivers/net/wireless/realtek/rtw89/coex.c
>
> Also subject can point out specific function. Then my opinion is
> "wifi: rtw89: coex: check NULL return of kmalloc in btc_fw_set_monreg()"
>
hi Kalle Valo and Ping-Ke Shih,
Thanks,I will modify the commit information and add Fixes.Thanks for help.
Pei Xiao.
WARNING: multiple messages have this Message-ID
From: Pei Xiao <xiaopei01@kylinos.cn>
To: Ping-Ke Shih <pkshih@realtek.com>, Kalle Valo <kvalo@kernel.org>
Cc: Pei Xiao <xiaopei01@kylinos.cn>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"xiaopeitux@foxmail.com" <xiaopeitux@foxmail.com>,
"xiongxin@kylinos.cn" <xiongxin@kylinos.cn>
Subject: Re: [PATCH] net: wireless: realtek/rtw89: Add check null return of\r kmalloc
Date: Wed, 30 Oct 2024 11:13:43 +0800 [thread overview]
Message-ID: <1728e9f5-0d4c-481f-8f85-9e4d74ab4ee5@kylinos.cn> (raw)
Message-ID: <20241030031343.904UxI16wlJEmqfLn6YFDwcsPTVITZIN6NS2KSQOGck@z> (raw)
In-Reply-To: <4f5eee8cb4024571a9a78af97aecab67@realtek.com>
On 2024/10/30 08:35, Ping-Ke Shih wrote:
> Kalle Valo <kvalo@kernel.org> wrote:
>> Pei Xiao <xiaopei01@kylinos.cn> writes:
>>
>>> kmalloc may fail, return might be NULL and will cause
>>> NULL pointer dereference later.
>>>
>>> Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
>>
>> We use 'wifi: rtw89:' in the title, please check the documentation below
>> for more.
>>
>
> A way to known subject prefix is to use git log with the files touched by
> this patch:
> git log --oneline drivers/net/wireless/realtek/rtw89/coex.c
>
> Also subject can point out specific function. Then my opinion is
> "wifi: rtw89: coex: check NULL return of kmalloc in btc_fw_set_monreg()"
>
hi Kalle Valo and Ping-Ke Shih,
Thanks,I will modify the commit information and add Fixes.Thanks for help.
Pei Xiao.
next prev parent reply other threads:[~2024-10-30 3:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-29 9:12 Pei Xiao
2024-10-29 10:33 ` Kalle Valo
2024-10-30 0:35 ` Ping-Ke Shih
2024-10-30 3:12 ` Pei Xiao [this message]
2024-10-30 3:13 ` Pei Xiao
2024-10-29 20:37 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1728e9f5-0d4c-481f-8f85-9e4d74ab4ee5@kylinos.cn \
--to=xiaopei01@kylinos.cn \
--cc=425562414@qq.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=xiaopeitux@foxmail.com \
--cc=xiongxin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®