From: Jiri Slaby <jirislaby@kernel.org>
To: Zucheng Zheng <zhengzucheng@huawei.com>,
alcooperx@gmail.com, gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-kernel@vger.kernel.org, hucool.lihua@huawei.com
Subject: Re: [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root' static
Date: Tue, 6 Apr 2021 06:53:14 +0200 [thread overview]
Message-ID: <7d91eb53-cde3-934c-a75f-833f98e6b156@kernel.org> (raw)
In-Reply-To: <20210401074919.56573-1-zhengzucheng@huawei.com>
On 01. 04. 21, 9:49, Zucheng Zheng wrote:
> symbol 'brcmuart_debugfs_root' is not used outside of 8250_bcm7271.c,
> so this commit marks it static.
>
> Signed-off-by: Zucheng Zheng <zhengzucheng@huawei.com>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> ---
> drivers/tty/serial/8250/8250_bcm7271.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
> index 63883185fccd..ebba7f2e960c 100644
> --- a/drivers/tty/serial/8250/8250_bcm7271.c
> +++ b/drivers/tty/serial/8250/8250_bcm7271.c
> @@ -239,7 +239,7 @@ struct brcmuart_priv {
> u32 rx_abort;
> };
>
> -struct dentry *brcmuart_debugfs_root;
> +static struct dentry *brcmuart_debugfs_root;
>
> /*
> * Register access routines
>
--
js
prev parent reply other threads:[~2021-04-06 4:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 7:49 Zucheng Zheng
2021-04-06 4:53 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d91eb53-cde3-934c-a75f-833f98e6b156@kernel.org \
--to=jirislaby@kernel.org \
--cc=alcooperx@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gregkh@linuxfoundation.org \
--cc=hucool.lihua@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=zhengzucheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®