mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root' static
@ 2021-04-01  7:49 Zucheng Zheng
  2021-04-06  4:53 ` Jiri Slaby
  0 siblings, 1 reply; 2+ messages in thread
From: Zucheng Zheng @ 2021-04-01  7:49 UTC (permalink / raw)
  To: alcooperx, gregkh, jirislaby
  Cc: linux-serial, bcm-kernel-feedback-list, linux-kernel, hucool.lihua

symbol 'brcmuart_debugfs_root' is not used outside of 8250_bcm7271.c,
so this commit marks it static.

Signed-off-by: Zucheng Zheng <zhengzucheng@huawei.com>
---
 drivers/tty/serial/8250/8250_bcm7271.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
index 63883185fccd..ebba7f2e960c 100644
--- a/drivers/tty/serial/8250/8250_bcm7271.c
+++ b/drivers/tty/serial/8250/8250_bcm7271.c
@@ -239,7 +239,7 @@ struct brcmuart_priv {
 	u32		rx_abort;
 };
 
-struct dentry *brcmuart_debugfs_root;
+static struct dentry *brcmuart_debugfs_root;
 
 /*
  * Register access routines
-- 
2.17.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root' static
  2021-04-01  7:49 [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root' static Zucheng Zheng
@ 2021-04-06  4:53 ` Jiri Slaby
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2021-04-06  4:53 UTC (permalink / raw)
  To: Zucheng Zheng, alcooperx, gregkh
  Cc: linux-serial, bcm-kernel-feedback-list, linux-kernel, hucool.lihua

On 01. 04. 21, 9:49, Zucheng Zheng wrote:
> symbol 'brcmuart_debugfs_root' is not used outside of 8250_bcm7271.c,
> so this commit marks it static.
> 
> Signed-off-by: Zucheng Zheng <zhengzucheng@huawei.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> ---
>   drivers/tty/serial/8250/8250_bcm7271.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/8250/8250_bcm7271.c b/drivers/tty/serial/8250/8250_bcm7271.c
> index 63883185fccd..ebba7f2e960c 100644
> --- a/drivers/tty/serial/8250/8250_bcm7271.c
> +++ b/drivers/tty/serial/8250/8250_bcm7271.c
> @@ -239,7 +239,7 @@ struct brcmuart_priv {
>   	u32		rx_abort;
>   };
>   
> -struct dentry *brcmuart_debugfs_root;
> +static struct dentry *brcmuart_debugfs_root;
>   
>   /*
>    * Register access routines
> 


-- 
js

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-06  4:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-01  7:49 [PATCH -next] serial: 8250: Make symbol 'brcmuart_debugfs_root' static Zucheng Zheng
2021-04-06  4:53 ` Jiri Slaby

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®