* [PATCH 1/4] vdpa_sim: Fix return value check for vdpa_alloc_device()
@ 2021-07-15 7:59 Xie Yongji
2021-07-15 8:03 ` Jason Wang
0 siblings, 1 reply; 4+ messages in thread
From: Xie Yongji @ 2021-07-15 7:59 UTC (permalink / raw)
To: mst, jasowang, dan.carpenter; +Cc: virtualization, linux-kernel
The vdpa_alloc_device() returns an error pointer upon
failure, not NULL. To handle the failure correctly, this
replaces NULL check with IS_ERR() check and propagate the
error upwards.
Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index 14e024de5cbf..c621cf7feec0 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
@@ -251,8 +251,10 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *dev_attr)
vdpasim = vdpa_alloc_device(struct vdpasim, vdpa, NULL, ops,
dev_attr->name);
- if (!vdpasim)
+ if (IS_ERR(vdpasim)) {
+ ret = PTR_ERR(vdpasim);
goto err_alloc;
+ }
vdpasim->dev_attr = *dev_attr;
INIT_WORK(&vdpasim->work, dev_attr->work_fn);
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/4] vdpa_sim: Fix return value check for vdpa_alloc_device()
2021-07-15 7:59 [PATCH 1/4] vdpa_sim: Fix return value check for vdpa_alloc_device() Xie Yongji
@ 2021-07-15 8:03 ` Jason Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jason Wang @ 2021-07-15 8:03 UTC (permalink / raw)
To: Xie Yongji, mst, dan.carpenter; +Cc: virtualization, linux-kernel
在 2021/7/15 下午3:59, Xie Yongji 写道:
> The vdpa_alloc_device() returns an error pointer upon
> failure, not NULL. To handle the failure correctly, this
> replaces NULL check with IS_ERR() check and propagate the
> error upwards.
>
> Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
Acked-by: Jason Wang <jasowang@redhat.com>
> ---
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> index 14e024de5cbf..c621cf7feec0 100644
> --- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
> +++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
> @@ -251,8 +251,10 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *dev_attr)
>
> vdpasim = vdpa_alloc_device(struct vdpasim, vdpa, NULL, ops,
> dev_attr->name);
> - if (!vdpasim)
> + if (IS_ERR(vdpasim)) {
> + ret = PTR_ERR(vdpasim);
> goto err_alloc;
> + }
>
> vdpasim->dev_attr = *dev_attr;
> INIT_WORK(&vdpasim->work, dev_attr->work_fn);
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/4] vdpa_sim: Fix return value check for vdpa_alloc_device()
@ 2021-07-15 8:00 Xie Yongji
2021-07-26 9:28 ` Stefano Garzarella
0 siblings, 1 reply; 4+ messages in thread
From: Xie Yongji @ 2021-07-15 8:00 UTC (permalink / raw)
To: mst, jasowang, dan.carpenter; +Cc: virtualization, linux-kernel
The vdpa_alloc_device() returns an error pointer upon
failure, not NULL. To handle the failure correctly, this
replaces NULL check with IS_ERR() check and propagate the
error upwards.
Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
---
drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
index 14e024de5cbf..c621cf7feec0 100644
--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
@@ -251,8 +251,10 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *dev_attr)
vdpasim = vdpa_alloc_device(struct vdpasim, vdpa, NULL, ops,
dev_attr->name);
- if (!vdpasim)
+ if (IS_ERR(vdpasim)) {
+ ret = PTR_ERR(vdpasim);
goto err_alloc;
+ }
vdpasim->dev_attr = *dev_attr;
INIT_WORK(&vdpasim->work, dev_attr->work_fn);
--
2.11.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 1/4] vdpa_sim: Fix return value check for vdpa_alloc_device()
2021-07-15 8:00 Xie Yongji
@ 2021-07-26 9:28 ` Stefano Garzarella
0 siblings, 0 replies; 4+ messages in thread
From: Stefano Garzarella @ 2021-07-26 9:28 UTC (permalink / raw)
To: Xie Yongji; +Cc: mst, jasowang, dan.carpenter, virtualization, linux-kernel
On Thu, Jul 15, 2021 at 04:00:23PM +0800, Xie Yongji wrote:
>The vdpa_alloc_device() returns an error pointer upon
>failure, not NULL. To handle the failure correctly, this
>replaces NULL check with IS_ERR() check and propagate the
>error upwards.
>
>Fixes: 2c53d0f64c06 ("vdpasim: vDPA device simulator")
>Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
>---
> drivers/vdpa/vdpa_sim/vdpa_sim.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c
>index 14e024de5cbf..c621cf7feec0 100644
>--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c
>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c
>@@ -251,8 +251,10 @@ struct vdpasim *vdpasim_create(struct vdpasim_dev_attr *dev_attr)
>
> vdpasim = vdpa_alloc_device(struct vdpasim, vdpa, NULL, ops,
> dev_attr->name);
>- if (!vdpasim)
>+ if (IS_ERR(vdpasim)) {
>+ ret = PTR_ERR(vdpasim);
> goto err_alloc;
>+ }
>
> vdpasim->dev_attr = *dev_attr;
> INIT_WORK(&vdpasim->work, dev_attr->work_fn);
>--
>2.11.0
>
Reviewed-by: Stefano Garzarella <sgarzare@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-26 9:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-15 7:59 [PATCH 1/4] vdpa_sim: Fix return value check for vdpa_alloc_device() Xie Yongji
2021-07-15 8:03 ` Jason Wang
2021-07-15 8:00 Xie Yongji
2021-07-26 9:28 ` Stefano Garzarella
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®