* [PATCH] perf: arm_cspmu: Fix compiler warning
@ 2023-03-01 22:56 Besar Wicaksono
2023-03-02 12:01 ` Suzuki K Poulose
0 siblings, 1 reply; 3+ messages in thread
From: Besar Wicaksono @ 2023-03-01 22:56 UTC (permalink / raw)
To: suzuki.poulose, catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, linux-tegra, treding, jonathanh,
vsethi, Besar Wicaksono
Fix following compiler warning message
| smatch warnings:
| drivers/perf/arm_cspmu/arm_cspmu.c:1075 arm_cspmu_find_cpu_container()
| warn: variable dereferenced before check 'cpu_dev' (see line 1073)
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/202302191227.kc0V8fM7-lkp@intel.com/
Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
---
drivers/perf/arm_cspmu/arm_cspmu.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
index e31302ab7e37..a3f1c410b417 100644
--- a/drivers/perf/arm_cspmu/arm_cspmu.c
+++ b/drivers/perf/arm_cspmu/arm_cspmu.c
@@ -1078,12 +1078,14 @@ static int arm_cspmu_request_irq(struct arm_cspmu *cspmu)
static inline int arm_cspmu_find_cpu_container(int cpu, u32 container_uid)
{
u32 acpi_uid;
- struct device *cpu_dev = get_cpu_device(cpu);
- struct acpi_device *acpi_dev = ACPI_COMPANION(cpu_dev);
+ struct device *cpu_dev;
+ struct acpi_device *acpi_dev;
+ cpu_dev = get_cpu_device(cpu);
if (!cpu_dev)
return -ENODEV;
+ acpi_dev = ACPI_COMPANION(cpu_dev);
while (acpi_dev) {
if (!strcmp(acpi_device_hid(acpi_dev),
ACPI_PROCESSOR_CONTAINER_HID) &&
base-commit: 7f7a8831520f12a3cf894b0627641fad33971221
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf: arm_cspmu: Fix compiler warning
2023-03-01 22:56 [PATCH] perf: arm_cspmu: Fix compiler warning Besar Wicaksono
@ 2023-03-02 12:01 ` Suzuki K Poulose
2023-03-02 16:34 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Suzuki K Poulose @ 2023-03-02 12:01 UTC (permalink / raw)
To: Besar Wicaksono, catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, linux-tegra, treding, jonathanh, vsethi
On 01/03/2023 22:56, Besar Wicaksono wrote:
> Fix following compiler warning message
> | smatch warnings:
> | drivers/perf/arm_cspmu/arm_cspmu.c:1075 arm_cspmu_find_cpu_container()
> | warn: variable dereferenced before check 'cpu_dev' (see line 1073)
>
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Link: https://lore.kernel.org/r/202302191227.kc0V8fM7-lkp@intel.com/
> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> ---
> drivers/perf/arm_cspmu/arm_cspmu.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
> index e31302ab7e37..a3f1c410b417 100644
> --- a/drivers/perf/arm_cspmu/arm_cspmu.c
> +++ b/drivers/perf/arm_cspmu/arm_cspmu.c
> @@ -1078,12 +1078,14 @@ static int arm_cspmu_request_irq(struct arm_cspmu *cspmu)
> static inline int arm_cspmu_find_cpu_container(int cpu, u32 container_uid)
> {
> u32 acpi_uid;
> - struct device *cpu_dev = get_cpu_device(cpu);
> - struct acpi_device *acpi_dev = ACPI_COMPANION(cpu_dev);
> + struct device *cpu_dev;
> + struct acpi_device *acpi_dev;
>
> + cpu_dev = get_cpu_device(cpu);
> if (!cpu_dev)
> return -ENODEV;
>
> + acpi_dev = ACPI_COMPANION(cpu_dev);
> while (acpi_dev) {
> if (!strcmp(acpi_device_hid(acpi_dev),
> ACPI_PROCESSOR_CONTAINER_HID) &&
>
> base-commit: 7f7a8831520f12a3cf894b0627641fad33971221
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] perf: arm_cspmu: Fix compiler warning
2023-03-02 12:01 ` Suzuki K Poulose
@ 2023-03-02 16:34 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2023-03-02 16:34 UTC (permalink / raw)
To: Suzuki K Poulose, Besar Wicaksono, catalin.marinas, will, mark.rutland
Cc: linux-arm-kernel, linux-kernel, linux-tegra, treding, jonathanh, vsethi
On 3/2/23 04:01, Suzuki K Poulose wrote:
> On 01/03/2023 22:56, Besar Wicaksono wrote:
>> Fix following compiler warning message
>> | smatch warnings:
>> | drivers/perf/arm_cspmu/arm_cspmu.c:1075 arm_cspmu_find_cpu_container()
>> | warn: variable dereferenced before check 'cpu_dev' (see line 1073)
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Reported-by: Dan Carpenter <error27@gmail.com>
>> Link: https://lore.kernel.org/r/202302191227.kc0V8fM7-lkp@intel.com/
>> Signed-off-by: Besar Wicaksono <bwicaksono@nvidia.com>
>
> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
in Subject:, s/compiler/smatch/
>> ---
>> drivers/perf/arm_cspmu/arm_cspmu.c | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/perf/arm_cspmu/arm_cspmu.c b/drivers/perf/arm_cspmu/arm_cspmu.c
>> index e31302ab7e37..a3f1c410b417 100644
>> --- a/drivers/perf/arm_cspmu/arm_cspmu.c
>> +++ b/drivers/perf/arm_cspmu/arm_cspmu.c
>> @@ -1078,12 +1078,14 @@ static int arm_cspmu_request_irq(struct arm_cspmu *cspmu)
>> static inline int arm_cspmu_find_cpu_container(int cpu, u32 container_uid)
>> {
>> u32 acpi_uid;
>> - struct device *cpu_dev = get_cpu_device(cpu);
>> - struct acpi_device *acpi_dev = ACPI_COMPANION(cpu_dev);
>> + struct device *cpu_dev;
>> + struct acpi_device *acpi_dev;
>> + cpu_dev = get_cpu_device(cpu);
>> if (!cpu_dev)
>> return -ENODEV;
>> + acpi_dev = ACPI_COMPANION(cpu_dev);
>> while (acpi_dev) {
>> if (!strcmp(acpi_device_hid(acpi_dev),
>> ACPI_PROCESSOR_CONTAINER_HID) &&
>>
>> base-commit: 7f7a8831520f12a3cf894b0627641fad33971221
>
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-02 16:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-01 22:56 [PATCH] perf: arm_cspmu: Fix compiler warning Besar Wicaksono
2023-03-02 12:01 ` Suzuki K Poulose
2023-03-02 16:34 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®