mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Matthias Schiffer <matthias.schiffer@ew.tq-group.com>
Cc: Peter Korsgaard <peter@korsgaard.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux@ew.tq-group.com
Subject: Re: [PATCH 1/2] i2c: ocores: replace 1ms poll iteration timeout with total transfer timeout
Date: Tue, 7 Oct 2025 14:34:25 +0200	[thread overview]
Message-ID: <7dbefacc-3ce0-47ea-b521-102320f49420@lunn.ch> (raw)
In-Reply-To: <1eb320b6b7d3a12e62785893ea68c4d16aa2560d.1759838476.git.matthias.schiffer@ew.tq-group.com>

On Tue, Oct 07, 2025 at 02:09:24PM +0200, Matthias Schiffer wrote:
> When a target makes use of clock stretching, a timeout of 1ms may not be
> enough. One extreme example is the NXP PTN3460 eDP to LVDS bridge, which
> takes ~320ms to send its ACK after a flash command has been
> submitted.
> 
> Replace the per-iteration timeout of 1ms with limiting the total
> transfer time to the timeout set in struct i2c_adapter (defaulting to
> 1s, configurable through the I2C_TIMEOUT ioctl). While we're at it, also
> add a cpu_relax() to the busy poll loop.

1s is a long time to spin. Maybe it would be better to keep with the
current spin for 1ms, and then use one of the helpers from iopoll.h to
do a sleeping wait? Say with 10ms sleeps, up to the 1s maximum?

	Andrew

  parent reply	other threads:[~2025-10-07 12:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-07 12:09 Matthias Schiffer
2025-10-07 12:09 ` [PATCH 2/2] i2c: ocores: respect adapter timeout in IRQ mode Matthias Schiffer
2025-10-07 14:32   ` Peter Korsgaard
2025-10-07 12:34 ` Andrew Lunn [this message]
2025-10-07 14:06   ` [PATCH 1/2] i2c: ocores: replace 1ms poll iteration timeout with total transfer timeout Matthias Schiffer
2025-10-07 14:20     ` Andrew Lunn
2025-10-07 14:41       ` Matthias Schiffer
2025-10-07 14:50         ` Andrew Lunn
2025-10-09 22:25 ` Andi Shyti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7dbefacc-3ce0-47ea-b521-102320f49420@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=andi.shyti@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=matthias.schiffer@ew.tq-group.com \
    --cc=peter@korsgaard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®