coresight-etm4x-core.c:969:26: error: 'ID_AA64DFR0_TRACEVER_SHIFT' undeclared

coresight-etm4x-core.c:969:26: error: 'ID_AA64DFR0_TRACEVER_SHIFT' undeclared

[Naresh Kamboju]

Following build warnings / errors noticed while building arm64 coresight
on linux next-20220919 and next-20220920.

Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>

make --silent --keep-going --jobs=8
O=/home/tuxbuild/.cache/tuxmake/builds/1/build
CROSS_COMPILE_COMPAT=arm-linux-gnueabihf- ARCH=arm64
CROSS_COMPILE=aarch64-linux-gnu- 'CC=sccache aarch64-linux-gnu-gcc'
'HOSTCC=sccache gcc'

drivers/hwtracing/coresight/coresight-etm4x-core.c: In function
'cpu_supports_sysreg_trace':
drivers/hwtracing/coresight/coresight-etm4x-core.c:969:26: error:
'ID_AA64DFR0_TRACEVER_SHIFT' undeclared (first use in this function);
did you mean 'ID_AA64DFR0_EL1_TraceVer_SHIFT'?
  969 |         return ((dfr0 >> ID_AA64DFR0_TRACEVER_SHIFT) & 0xfUL) > 0;
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                          ID_AA64DFR0_EL1_TraceVer_SHIFT
drivers/hwtracing/coresight/coresight-etm4x-core.c:969:26: note: each
undeclared identifier is reported only once for each function it
appears in
drivers/hwtracing/coresight/coresight-etm4x-core.c: In function
'cpu_detect_trace_filtering':
drivers/hwtracing/coresight/coresight-etm4x-core.c:1057:57: error:
'ID_AA64DFR0_TRACE_FILT_SHIFT' undeclared (first use in this
function); did you mean 'ID_AA64PFR0_EL1_DIT_SHIFT'?
 1057 |         if (!cpuid_feature_extract_unsigned_field(dfr0,
ID_AA64DFR0_TRACE_FILT_SHIFT))
      |
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |
ID_AA64PFR0_EL1_DIT_SHIFT
drivers/hwtracing/coresight/coresight-etm4x-core.c: In function
'cpu_supports_sysreg_trace':
drivers/hwtracing/coresight/coresight-etm4x-core.c:970:1: error:
control reaches end of non-void function [-Werror=return-type]
  970 | }
      | ^
cc1: some warnings being treated as errors

Regressions found on arm64:
   - build-clang-13-lkftconfig
   - build-gcc-11-lkftconfig-devicetree
   - build-gcc-11-lkftconfig-kunit
   - build-gcc-11-lkftconfig-perf
   - build-gcc-11-lkftconfig-64k_page_size
   - build-gcc-11-lkftconfig-debug
   - build-gcc-11-lkftconfig-libgpiod
   - build-gcc-11-lkftconfig-debug-kmemleak
   - build-clang-14-lkftconfig
   - build-clang-nightly-lkftconfig
   - build-gcc-11-lkftconfig
   - build-gcc-11-lkftconfig-kasan
   - build-clang-12-lkftconfig
   - build-gcc-11-lkftconfig-kselftest-kernel
   - build-gcc-11-lkftconfig-rcutorture
   - build-gcc-11-lkftconfig-armv8_features
   - build-gcc-11-lkftconfig-kselftest

Build: https://builds.tuxbuild.com/2F1cW8NpQ0Z6l9h9rfkZT5AXzqg/
config: https://builds.tuxbuild.com/2F1cW8NpQ0Z6l9h9rfkZT5AXzqg/config


--
Linaro LKFT
https://lkft.linaro.org

Re: coresight-etm4x-core.c:969:26: error: 'ID_AA64DFR0_TRACEVER_SHIFT' undeclared

[James Clark]

On 20/09/2022 12:39, Naresh Kamboju wrote:
> Following build warnings / errors noticed while building arm64 coresight
> on linux next-20220919 and next-20220920.

Fix is here:
https://lists.linaro.org/archives/list/coresight@lists.linaro.org/thread/OS4F43WGOYGQUJHISR2PZQPE3FUQ7DXH/

> 
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
> 
> make --silent --keep-going --jobs=8
> O=/home/tuxbuild/.cache/tuxmake/builds/1/build
> CROSS_COMPILE_COMPAT=arm-linux-gnueabihf- ARCH=arm64
> CROSS_COMPILE=aarch64-linux-gnu- 'CC=sccache aarch64-linux-gnu-gcc'
> 'HOSTCC=sccache gcc'
> 
> drivers/hwtracing/coresight/coresight-etm4x-core.c: In function
> 'cpu_supports_sysreg_trace':
> drivers/hwtracing/coresight/coresight-etm4x-core.c:969:26: error:
> 'ID_AA64DFR0_TRACEVER_SHIFT' undeclared (first use in this function);
> did you mean 'ID_AA64DFR0_EL1_TraceVer_SHIFT'?
>   969 |         return ((dfr0 >> ID_AA64DFR0_TRACEVER_SHIFT) & 0xfUL) > 0;
>       |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                          ID_AA64DFR0_EL1_TraceVer_SHIFT
> drivers/hwtracing/coresight/coresight-etm4x-core.c:969:26: note: each
> undeclared identifier is reported only once for each function it
> appears in
> drivers/hwtracing/coresight/coresight-etm4x-core.c: In function
> 'cpu_detect_trace_filtering':
> drivers/hwtracing/coresight/coresight-etm4x-core.c:1057:57: error:
> 'ID_AA64DFR0_TRACE_FILT_SHIFT' undeclared (first use in this
> function); did you mean 'ID_AA64PFR0_EL1_DIT_SHIFT'?
>  1057 |         if (!cpuid_feature_extract_unsigned_field(dfr0,
> ID_AA64DFR0_TRACE_FILT_SHIFT))
>       |
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |
> ID_AA64PFR0_EL1_DIT_SHIFT
> drivers/hwtracing/coresight/coresight-etm4x-core.c: In function
> 'cpu_supports_sysreg_trace':
> drivers/hwtracing/coresight/coresight-etm4x-core.c:970:1: error:
> control reaches end of non-void function [-Werror=return-type]
>   970 | }
>       | ^
> cc1: some warnings being treated as errors
> 
> Regressions found on arm64:
>    - build-clang-13-lkftconfig
>    - build-gcc-11-lkftconfig-devicetree
>    - build-gcc-11-lkftconfig-kunit
>    - build-gcc-11-lkftconfig-perf
>    - build-gcc-11-lkftconfig-64k_page_size
>    - build-gcc-11-lkftconfig-debug
>    - build-gcc-11-lkftconfig-libgpiod
>    - build-gcc-11-lkftconfig-debug-kmemleak
>    - build-clang-14-lkftconfig
>    - build-clang-nightly-lkftconfig
>    - build-gcc-11-lkftconfig
>    - build-gcc-11-lkftconfig-kasan
>    - build-clang-12-lkftconfig
>    - build-gcc-11-lkftconfig-kselftest-kernel
>    - build-gcc-11-lkftconfig-rcutorture
>    - build-gcc-11-lkftconfig-armv8_features
>    - build-gcc-11-lkftconfig-kselftest
> 
> Build: https://builds.tuxbuild.com/2F1cW8NpQ0Z6l9h9rfkZT5AXzqg/
> config: https://builds.tuxbuild.com/2F1cW8NpQ0Z6l9h9rfkZT5AXzqg/config
> 
> 
> --
> Linaro LKFT
> https://lkft.linaro.org
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel