[PATCH] ASoC: dt-bindings: ak4554: Convert to dtschema

[PATCH] ASoC: dt-bindings: ak4554: Convert to dtschema

[Animesh Agarwal]

Convert the AK4554 sound codec bindings to DT schema.

Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Daniel Baluta <daniel.baluta@nxp.com>
---
 .../devicetree/bindings/sound/ak4554.txt      | 11 --------
 .../bindings/sound/asahi-kasei,ak4554.yaml    | 27 +++++++++++++++++++
 2 files changed, 27 insertions(+), 11 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/sound/ak4554.txt
 create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4554.yaml

diff --git a/Documentation/devicetree/bindings/sound/ak4554.txt b/Documentation/devicetree/bindings/sound/ak4554.txt
deleted file mode 100644
index 934fa02754b3..000000000000
--- a/Documentation/devicetree/bindings/sound/ak4554.txt
+++ /dev/null
@@ -1,11 +0,0 @@
-AK4554 ADC/DAC
-
-Required properties:
-
-  - compatible : "asahi-kasei,ak4554"
-
-Example:
-
-ak4554-adc-dac {
-	compatible = "asahi-kasei,ak4554";
-};
diff --git a/Documentation/devicetree/bindings/sound/asahi-kasei,ak4554.yaml b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4554.yaml
new file mode 100644
index 000000000000..c77d85df239e
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/asahi-kasei,ak4554.yaml
@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/sound/asahi-kasei,ak4554.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: AK4554 sound codec
+
+maintainers:
+  - Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
+  - Liam Girdwood <lgirdwood@gmail.com>
+  - Mark Brown <broonie@kernel.org>
+
+properties:
+  compatible:
+    const: asahi-kasei,ak4554
+
+required:
+  - compatible
+
+additionalProperties: false
+
+examples:
+  - |
+    codec {
+        compatible = "asahi-kasei,ak4554";
+    };
-- 
2.45.1

Re: [PATCH] ASoC: dt-bindings: ak4554: Convert to dtschema

[Kuninori Morimoto]

Hi Animesh

> Convert the AK4554 sound codec bindings to DT schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> ---

Thank you for the patch.
But no one is using AK4554, we can remove it instead ?


Thank you for your help !!
Best regards
---
Kuninori Morimoto

Re: [PATCH] ASoC: dt-bindings: ak4554: Convert to dtschema

[Daniel Baluta]

On Fri, Jun 7, 2024 at 9:19 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Animesh
>
> > Convert the AK4554 sound codec bindings to DT schema.
> >
> > Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> > Cc: Daniel Baluta <daniel.baluta@nxp.com>
> > ---
>
> Thank you for the patch.
> But no one is using AK4554, we can remove it instead ?


So we just remove the device tree binding file, right? And later if
there is anyone who will use the
codec he can later add the yaml file.

Re: [PATCH] ASoC: dt-bindings: ak4554: Convert to dtschema

[Krzysztof Kozlowski]

On 07/06/2024 10:42, Daniel Baluta wrote:
> On Fri, Jun 7, 2024 at 9:19 AM Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
>>
>>
>> Hi Animesh
>>
>>> Convert the AK4554 sound codec bindings to DT schema.
>>>
>>> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
>>> Cc: Daniel Baluta <daniel.baluta@nxp.com>
>>> ---
>>
>> Thank you for the patch.
>> But no one is using AK4554, we can remove it instead ?
> 
> 
> So we just remove the device tree binding file, right? And later if
> there is anyone who will use the
> codec he can later add the yaml file.

Remove the binding and the driver.

Best regards,
Krzysztof

Re: [PATCH] ASoC: dt-bindings: ak4554: Convert to dtschema

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 502 bytes --]

On Fri, Jun 07, 2024 at 11:27:25AM +0200, Krzysztof Kozlowski wrote:
> On 07/06/2024 10:42, Daniel Baluta wrote:

> > So we just remove the device tree binding file, right? And later if
> > there is anyone who will use the
> > codec he can later add the yaml file.

> Remove the binding and the driver.

I tend to prefer to keep drivers unless they're actively getting in the
way, there's no requirement for people to upstream their board DTs
(we're trying to have boards shipping DTs in firmware...).

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH] ASoC: dt-bindings: ak4554: Convert to dtschema

[Rob Herring (Arm)]

On Fri, 07 Jun 2024 11:27:20 +0530, Animesh Agarwal wrote:
> Convert the AK4554 sound codec bindings to DT schema.
> 
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> Cc: Daniel Baluta <daniel.baluta@nxp.com>
> ---
>  .../devicetree/bindings/sound/ak4554.txt      | 11 --------
>  .../bindings/sound/asahi-kasei,ak4554.yaml    | 27 +++++++++++++++++++
>  2 files changed, 27 insertions(+), 11 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/sound/ak4554.txt
>  create mode 100644 Documentation/devicetree/bindings/sound/asahi-kasei,ak4554.yaml
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>

Re: [PATCH] ASoC: dt-bindings: ak4554: Convert to dtschema

[Mark Brown]

On Fri, 07 Jun 2024 11:27:20 +0530, Animesh Agarwal wrote:
> Convert the AK4554 sound codec bindings to DT schema.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: dt-bindings: ak4554: Convert to dtschema
      commit: 0ac3f1a4c2a345c48d22e8eb5b5aeb9304cb11db

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark