From: Richard Fitzgerald <rf@opensource.cirrus.com>
To: Ziyi Guo <n7l8m4@u.northwestern.edu>,
Simon Trimmer <simont@opensource.cirrus.com>,
Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: patches@opensource.cirrus.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: cs_dsp: fix missing pwr_lock in cs_dsp_signal_event_controls()
Date: Mon, 2 Feb 2026 09:58:22 +0000 [thread overview]
Message-ID: <7e0183dd-33b7-4fed-8be6-9b41bb612610@opensource.cirrus.com> (raw)
In-Reply-To: <20260131223317.3328639-1-n7l8m4@u.northwestern.edu>
On 31/01/2026 10:33 pm, Ziyi Guo wrote:
> cs_dsp_signal_event_controls() calls cs_dsp_coeff_write_acked_control()
> which has lockdep_assert_held(&dsp->pwr_lock), but the lock is not held.
>
> Add mutex_lock()/mutex_unlock() around the control list iteration in
> cs_dsp_signal_event_controls() to fix the missing lock protection.
>
> Signed-off-by: Ziyi Guo <n7l8m4@u.northwestern.edu>
I don't think this is the correct fix.
The mutex_lock() in cs_dsp_stop() should be at the top of the function.
Compare with cs_dsp_run().
next prev parent reply other threads:[~2026-02-02 9:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 22:33 Ziyi Guo
2026-02-02 9:58 ` Richard Fitzgerald [this message]
2026-02-02 14:06 ` Ziyi Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e0183dd-33b7-4fed-8be6-9b41bb612610@opensource.cirrus.com \
--to=rf@opensource.cirrus.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=linux-kernel@vger.kernel.org \
--cc=n7l8m4@u.northwestern.edu \
--cc=patches@opensource.cirrus.com \
--cc=simont@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®