From: "Friday Yang (杨阳)" <Friday.Yang@mediatek.com>
To: "robh@kernel.org" <robh@kernel.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
"Yong Wu (吴勇)" <Yong.Wu@mediatek.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"krzk@kernel.org" <krzk@kernel.org>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v8 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188
Date: Mon, 28 Jul 2025 02:59:23 +0000 [thread overview]
Message-ID: <7e390b85e1ba6362ffa0231faefc0ea63a922639.camel@mediatek.com> (raw)
In-Reply-To: <03dece78-44d5-4b85-b71c-bb6794849ddd@kernel.org>
On Thu, 2025-07-24 at 10:55 +0200, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 24/07/2025 10:43, Friday Yang (杨阳) wrote:
> > >
> > > > ignore this tag. What I intended to explain here was that I
> > > > decided
> > > > not
> > > > to use 'devm_pm_runtime_enable' to replace 'pm_runtime_enable'
> > > > functions. Unfortunately, the fake tag didn't explain this
> > > > clearly
> > > > in
> > > > the changelog, which was my fault. To address this, I updated
> > > > patchset
> > > > v8 to include an explanation.
> > > >
> > > > In patchset v6, I replaced 'pm_runtime_enable' with
> > > > 'devm_pm_runtime_enable'. However, in patchset v8, I reverted
> > > > this
> > > > change and included the reason for this decision in the
> > > > changelog.
> > > > Apologize for the delay and the trouble again.
> > >
> > > Nothing above is related to my question about the
> > > fake/invented/questioned tag.
> > >
> >
> > I got your point, you refer to the 'reviewed-by' and 'acked-by' tag
> > in
> > this patch.
> > These are the tags from two reviewers.
> >
> >
https://lore.kernel.org/lkml/174172361378.44650.15345202042780383326.robh@kernel.org/
>
>
> You are really not responding to my initial comments and keep
> dragging
> this discussion in some confused directions. Do we talk here about
> that
> patch? No.
>
I understand what you're referring to. For the 'dt-binding' patch, I
can keep the tags. However, for the 'smi driver' patch, I should remove
the tags because there was a change after v6.
I will update v9 soon. Thank you!
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2025-07-28 2:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-21 6:33 [PATCH v8 0/2] Add SMI reset and clamp for MediaTek MT8188 SoC Friday Yang
2025-05-21 6:33 ` [PATCH v8 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188 Friday Yang
2025-05-21 6:33 ` [PATCH v8 2/2] memory: mtk-smi: mt8188: " Friday Yang
2025-06-12 15:16 ` Krzysztof Kozlowski
2025-07-24 1:49 ` Friday Yang (杨阳)
2025-07-24 7:08 ` Krzysztof Kozlowski
2025-07-24 7:59 ` Friday Yang (杨阳)
2025-07-24 8:09 ` Krzysztof Kozlowski
2025-07-24 8:43 ` Friday Yang (杨阳)
2025-07-24 8:55 ` Krzysztof Kozlowski
2025-07-28 2:59 ` Friday Yang (杨阳) [this message]
2025-07-28 4:50 ` Krzysztof Kozlowski
2025-08-02 1:25 ` Yong Wu (吴勇)
2025-08-04 6:05 ` Friday Yang (杨阳)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e390b85e1ba6362ffa0231faefc0ea63a922639.camel@mediatek.com \
--to=friday.yang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Yong.Wu@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®