From: Randy Dunlap <rdunlap@infradead.org>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c
Date: Wed, 3 Feb 2021 19:33:16 -0800 [thread overview]
Message-ID: <7e5dfce3-1343-4bad-1d64-b8f2eff8e2a6@infradead.org> (raw)
In-Reply-To: <YBtcy8WPPSz6wCfO@Gentoo>
On 2/3/21 6:32 PM, Bhaskar Chowdhury wrote:
> On 18:09 Wed 03 Feb 2021, Randy Dunlap wrote:
>> On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote:
>>>
>>> s/initialsation/initialisation/
>>> s/specifiing/specifying/
>>>
>>> Plus get rid of few blank lines.
>>>
>>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>>> ---
>>> Changes from V1:
>>> Fix typo in the subject line
>>> Give explanation of all the changes in changelog text
>>>
>>> drivers/net/ethernet/i825xx/ether1.c | 9 +++------
>>> 1 file changed, 3 insertions(+), 6 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
>>> index a0bfb509e002..850ea32091ed 100644
>>> --- a/drivers/net/ethernet/i825xx/ether1.c
>>> +++ b/drivers/net/ethernet/i825xx/ether1.c
>>
>> a. don't delete the blank lines
>> b. the change below is not described and does not change any whitespace AFAICT.
>> I.e., DDT [don't do that].
>>
> But what do you do when things getting automatically inducted in the
> patch???(You got to believe me)
>
> I haven't had touch that bloody function with my keystroke and it gets it on
> its own! Bemusing!
>
> Those blank lines too inducted from the fresh file(means in pristine form) ,so
> thought pruning would be good..hence the decision to get rid of those.
>
> Wondering what the fuck is going on....
Yeah, it seems like you have had editor-doing-too-much-for-you issues before now...
--
~Randy
prev parent reply other threads:[~2021-02-04 3:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 1:18 Bhaskar Chowdhury
2021-02-04 2:09 ` Randy Dunlap
2021-02-04 2:32 ` Bhaskar Chowdhury
2021-02-04 3:33 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e5dfce3-1343-4bad-1d64-b8f2eff8e2a6@infradead.org \
--to=rdunlap@infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=unixbhaskar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®