mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
	linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2] drivers: net: ethernet: i825xx: Fix couple of spellings and get rid of blank lines too in the file ether1.c
Date: Wed, 3 Feb 2021 18:09:54 -0800	[thread overview]
Message-ID: <bea4f9c4-b1bb-eab6-3125-bfe69938fa5b@infradead.org> (raw)
In-Reply-To: <20210204011821.18356-1-unixbhaskar@gmail.com>

On 2/3/21 5:18 PM, Bhaskar Chowdhury wrote:
> 
> s/initialsation/initialisation/
> s/specifiing/specifying/
> 
> Plus get rid of few blank lines.
> 
> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
> ---
> Changes from V1:
>    Fix typo in the subject line
>    Give explanation of all the changes in changelog text
> 
>  drivers/net/ethernet/i825xx/ether1.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/i825xx/ether1.c b/drivers/net/ethernet/i825xx/ether1.c
> index a0bfb509e002..850ea32091ed 100644
> --- a/drivers/net/ethernet/i825xx/ether1.c
> +++ b/drivers/net/ethernet/i825xx/ether1.c

a. don't delete the blank lines
b. the change below is not described and does not change any whitespace AFAICT.
   I.e., DDT [don't do that].

> @@ -1047,7 +1044,7 @@ static void ether1_remove(struct expansion_card *ec)
>  {
>  	struct net_device *dev = ecard_get_drvdata(ec);
> 
> -	ecard_set_drvdata(ec, NULL);
> +	ecard_set_drvdata(ec, NULL);
> 
>  	unregister_netdev(dev);
>  	free_netdev(dev);


-- 
~Randy


  reply	other threads:[~2021-02-04  2:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04  1:18 Bhaskar Chowdhury
2021-02-04  2:09 ` Randy Dunlap [this message]
2021-02-04  2:32   ` Bhaskar Chowdhury
2021-02-04  3:33     ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bea4f9c4-b1bb-eab6-3125-bfe69938fa5b@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=unixbhaskar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®