mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vijay Kumar <vijay.ac.kumar@oracle.com>
To: David Miller <davem@davemloft.net>
Cc: sparclinux@vger.kernel.org, karl.volz@oracle.com,
	rob.gardner@oracle.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] sparc64: Migrate hvcons irq to panicked cpu
Date: Mon, 28 Nov 2016 12:33:57 -0600	[thread overview]
Message-ID: <7e6a2af2-87b7-f042-cd8a-aabac3b3a80b@oracle.com> (raw)
In-Reply-To: <20161119.104812.1434195314137737490.davem@davemloft.net>


On 11/19/2016 9:48 AM, David Miller wrote:
> From: Vijay Kumar <vijay.ac.kumar@oracle.com>
> Date: Fri, 11 Nov 2016 10:11:57 -0800
>
>> @@ -1444,8 +1444,12 @@ void smp_send_stop(void)
>>   	int cpu;
>>   
>>   	if (tlb_type == hypervisor) {
>> +		int this_cpu = smp_processor_id();
>> +
>> +		sunhv_migrate_hvcons_irq(this_cpu);
>> +
> You can't unconditionally call into code that might be configured
> out by a Kconfig option, as you are doing here.
>
> If SERIAL_SUNHV=n this change will thus result in a build error.
Thanks for your comment. I will fix this and send revised version of patch.

Thanks,
Vijay

  reply	other threads:[~2016-11-28 18:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11 18:11 [PATCH v2 0/4] sparc64: Jump to boot prom from console on panic Vijay Kumar
2016-11-11 18:11 ` [PATCH v2 1/4] sparc64: Set cpu state to offline when stopped Vijay Kumar
2016-11-11 18:11 ` [PATCH v2 2/4] sparc64: Migrate hvcons irq to panicked cpu Vijay Kumar
2016-11-19 15:48   ` David Miller
2016-11-28 18:33     ` Vijay Kumar [this message]
2016-11-11 18:11 ` [PATCH v2 3/4] sparc64: Send break twice from console to return to boot prom Vijay Kumar
2016-11-11 18:11 ` [PATCH v2 4/4] Documentation/sparc: Steps for sending break on sunhv console Vijay Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e6a2af2-87b7-f042-cd8a-aabac3b3a80b@oracle.com \
    --to=vijay.ac.kumar@oracle.com \
    --cc=davem@davemloft.net \
    --cc=karl.volz@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rob.gardner@oracle.com \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®