mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>
To: William Wu <william.wu@rock-chips.com>,
	Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"frank.wang@rock-chips.com" <frank.wang@rock-chips.com>,
	"jianwei.zheng@rock-chips.com" <jianwei.zheng@rock-chips.com>,
	"yangbin@rock-chips.com" <yangbin@rock-chips.com>
Subject: Re: [PATCH] usb: dwc2: Disable clock gating feature on Rockchip SoCs
Date: Tue, 26 Dec 2023 07:26:22 +0000	[thread overview]
Message-ID: <7e6ccec1-2e4d-97c0-8a85-e38bad11f056@synopsys.com> (raw)
In-Reply-To: <1703575199-23638-1-git-send-email-william.wu@rock-chips.com>

Hi,

On 12/26/23 11:19, William Wu wrote:
> The DWC2 IP on the Rockchip SoCs doesn't support clock gating.
> When a clock gating is enabled, system hangs.
> 
> Signed-off-by: William Wu <william.wu@rock-chips.com>

Acked-by: Minas Harutyunyan <hminas@synopsys.com>

> ---
>   drivers/usb/dwc2/params.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index fb03162..eb677c3 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -130,6 +130,7 @@ static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
>   	p->lpm_clock_gating = false;
>   	p->besl = false;
>   	p->hird_threshold_en = false;
> +	p->no_clock_gating = true;
>   }
>   
>   static void dwc2_set_ltq_params(struct dwc2_hsotg *hsotg)

      reply	other threads:[~2023-12-26  7:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-26  7:19 William Wu
2023-12-26  7:26 ` Minas Harutyunyan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7e6ccec1-2e4d-97c0-8a85-e38bad11f056@synopsys.com \
    --to=minas.harutyunyan@synopsys.com \
    --cc=frank.wang@rock-chips.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jianwei.zheng@rock-chips.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=william.wu@rock-chips.com \
    --cc=yangbin@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®