* [PATCH] usb: dwc2: Disable clock gating feature on Rockchip SoCs
@ 2023-12-26 7:19 William Wu
2023-12-26 7:26 ` Minas Harutyunyan
0 siblings, 1 reply; 2+ messages in thread
From: William Wu @ 2023-12-26 7:19 UTC (permalink / raw)
To: hminas, gregkh
Cc: linux-usb, linux-kernel, william.wu, frank.wang, jianwei.zheng, yangbin
The DWC2 IP on the Rockchip SoCs doesn't support clock gating.
When a clock gating is enabled, system hangs.
Signed-off-by: William Wu <william.wu@rock-chips.com>
---
drivers/usb/dwc2/params.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
index fb03162..eb677c3 100644
--- a/drivers/usb/dwc2/params.c
+++ b/drivers/usb/dwc2/params.c
@@ -130,6 +130,7 @@ static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
p->lpm_clock_gating = false;
p->besl = false;
p->hird_threshold_en = false;
+ p->no_clock_gating = true;
}
static void dwc2_set_ltq_params(struct dwc2_hsotg *hsotg)
--
2.0.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: dwc2: Disable clock gating feature on Rockchip SoCs
2023-12-26 7:19 [PATCH] usb: dwc2: Disable clock gating feature on Rockchip SoCs William Wu
@ 2023-12-26 7:26 ` Minas Harutyunyan
0 siblings, 0 replies; 2+ messages in thread
From: Minas Harutyunyan @ 2023-12-26 7:26 UTC (permalink / raw)
To: William Wu, Minas Harutyunyan, gregkh
Cc: linux-usb, linux-kernel, frank.wang, jianwei.zheng, yangbin
Hi,
On 12/26/23 11:19, William Wu wrote:
> The DWC2 IP on the Rockchip SoCs doesn't support clock gating.
> When a clock gating is enabled, system hangs.
>
> Signed-off-by: William Wu <william.wu@rock-chips.com>
Acked-by: Minas Harutyunyan <hminas@synopsys.com>
> ---
> drivers/usb/dwc2/params.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc2/params.c b/drivers/usb/dwc2/params.c
> index fb03162..eb677c3 100644
> --- a/drivers/usb/dwc2/params.c
> +++ b/drivers/usb/dwc2/params.c
> @@ -130,6 +130,7 @@ static void dwc2_set_rk_params(struct dwc2_hsotg *hsotg)
> p->lpm_clock_gating = false;
> p->besl = false;
> p->hird_threshold_en = false;
> + p->no_clock_gating = true;
> }
>
> static void dwc2_set_ltq_params(struct dwc2_hsotg *hsotg)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-26 7:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-26 7:19 [PATCH] usb: dwc2: Disable clock gating feature on Rockchip SoCs William Wu
2023-12-26 7:26 ` Minas Harutyunyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®