From: Jiri Slaby <jslaby@suse.cz>
To: Valentin Vidic <Valentin.Vidic@CARNet.hr>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] n_tty: update comment for WAKEUP_CHARS define
Date: Wed, 2 Jan 2019 07:48:42 +0100 [thread overview]
Message-ID: <7e91df3a-d38b-fda4-b64f-4d47f4949623@suse.cz> (raw)
In-Reply-To: <20181229124829.3745-1-Valentin.Vidic@CARNet.hr>
On 29. 12. 18, 13:48, Valentin Vidic wrote:
> Give a better descriptions of what WAKEUP_CHARS represents.
>
> Signed-off-by: Valentin Vidic <Valentin.Vidic@CARNet.hr>
I am not a native speaker, but this is much better than the current text.
Acked-by: Jiri Slaby <jslaby@suse.cz>
BTW this text is copy&pasted from/to all the other WAKEUP_CHARS
locations. Care to fix them all?
> ---
> drivers/tty/n_tty.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c
> index 3ad460219fd6..1dfbd45746da 100644
> --- a/drivers/tty/n_tty.c
> +++ b/drivers/tty/n_tty.c
> @@ -50,8 +50,10 @@
> #include <linux/ratelimit.h>
> #include <linux/vmalloc.h>
>
> -
> -/* number of characters left in xmit buffer before select has we have room */
> +/*
> + * Until this number of characters is queued in the xmit buffer, select will
> + * return "we have room for writes".
> + */
> #define WAKEUP_CHARS 256
>
> /*
>
thanks,
--
js
suse labs
next prev parent reply other threads:[~2019-01-02 6:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-29 12:48 Valentin Vidic
2019-01-02 6:48 ` Jiri Slaby [this message]
2019-01-02 9:50 ` Valentin Vidic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e91df3a-d38b-fda4-b64f-4d47f4949623@suse.cz \
--to=jslaby@suse.cz \
--cc=Valentin.Vidic@CARNet.hr \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®