mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: poeschel@lemonage.de
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
	Miguel Ojeda <ojeda@kernel.org>,
	Hugo Villeneuve <hvilleneuve@dimonoff.com>,
	linux-kernel@vger.kernel.org, geert@linux-m68k.org,
	Christian Meusel <christian.meusel@posteo.de>
Subject: Re: [PATCH] auxdisplay: hd44780: move cursor home after clear display command
Date: Thu, 20 Jul 2023 18:49:59 +0200	[thread overview]
Message-ID: <7eb2d50baf269310e51854f700936e94@lemonage.de> (raw)
In-Reply-To: <20230706154937.1380bdcf9d84e1cff78911fa@hugovil.com>

Am 2023-07-06 21:49, schrieb Hugo Villeneuve:
> On Thu, 6 Jul 2023 21:33:05 +0200
> Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> 
>> On Thu, Jul 6, 2023 at 8:51 PM Hugo Villeneuve <hugo@hugovil.com> 
>> wrote:
>> >
>> > The "clear display" command on the NewHaven NHD-0220DZW-AG5 display
>> > does NOT change the DDRAM address to 00h (home position) like the
>> > standard Hitachi HD44780 controller. As a consequence, the starting
>> > position of the initial string LCD_INIT_TEXT is not guaranteed to be
>> > at 0,0 depending on where the cursor was before the clear display
>> > command.
>> >
>> > Extract of CLEAR_DISPLAY command from datasheets of:
>> >
>> >     Hitachi HD44780:
>> >         ... It then sets DDRAM address 0 into the address counter...
>> >
>> >     NewHaven NHD-0220DZW-AG5 datasheet:
>> >         ... This instruction does not change the DDRAM Address
>> >
>> > Move the cursor home after sending clear display command to support
>> > non-standard LCDs.
>> >
>> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>> 
>> Thanks! Sounds good to me, as long the extra command does not
>> introduce some issue with the actual HD44780 -- can we double-check
>> the HD44780 still works as expected?
>> 
>> Cc'ing Lars and Geert since they may be able to give it a quick test.
> 
> Hi Miguel,
> I do not have a standard Hitachi controller to test it on, so lets wait
> for feedback from Lars and Geert or others.

Sorry guys,
I do not have access to the relevant hardware anymore. I am CC'ing 
Christian,
who has the relevant hardware and maybe he can help testing the patch.
Christian is on vacation up until mid august, so we have to wait a bit 
more
for someone able to test this.

BTW: The displays I did the work back then on were for sure not genuine
Hitachi ones either.
I do not see, that the little patch should do any harm.

Regards,
Lars

  reply	other threads:[~2023-07-20 16:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-06 18:50 Hugo Villeneuve
2023-07-06 19:33 ` Miguel Ojeda
2023-07-06 19:49   ` Hugo Villeneuve
2023-07-20 16:49     ` poeschel [this message]
2023-07-22 14:46       ` David Reaver
2023-07-22 16:04         ` Miguel Ojeda
2023-07-22 18:07           ` Hugo Villeneuve
2023-08-16 15:22             ` Christian Meusel
2023-08-19 19:56               ` Miguel Ojeda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7eb2d50baf269310e51854f700936e94@lemonage.de \
    --to=poeschel@lemonage.de \
    --cc=christian.meusel@posteo.de \
    --cc=geert@linux-m68k.org \
    --cc=hugo@hugovil.com \
    --cc=hvilleneuve@dimonoff.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=ojeda@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®