From: Hugo Villeneuve <hugo@hugovil.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: me@davidreaver.com, poeschel@lemonage.de,
Miguel Ojeda <ojeda@kernel.org>,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
linux-kernel@vger.kernel.org, geert@linux-m68k.org,
Christian Meusel <christian.meusel@posteo.de>
Subject: Re: [PATCH] auxdisplay: hd44780: move cursor home after clear display command
Date: Sat, 22 Jul 2023 14:07:43 -0400 [thread overview]
Message-ID: <20230722140743.fe710f4f12c344f07d879c88@hugovil.com> (raw)
In-Reply-To: <CANiq72nO04+2BcwBe_P0uD8pXJtTMG3djAFAj5Ucez6VvT4g7g@mail.gmail.com>
On Sat, 22 Jul 2023 18:04:03 +0200
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> wrote:
> On Sat, Jul 22, 2023 at 4:54 PM David Reaver <me@davidreaver.com> wrote:
> >
> > I was actually hooking up a 16x2 HD44780 on my BeagleBone Black last
> > night before I came across this patch, so I was able to test this. It
> > works fine for me. I tested with:
> >
> > $ printf '\f' > /dev/lcd
> > $ printf 'Hello\nWorld!\n' > /dev/lcd
> > $ printf '\x1b[LR' > /dev/lcd
> > $ printf '\x1b[LR' > /dev/lcd
> > $ printf '\x1b[LR' > /dev/lcd
> > $ printf '\f' > /dev/lcd
> > $ printf 'Goodbye\nWorld!\n' > /dev/lcd
> >
> > As expected, "Goodbye World!" was correctly placed left-aligned on the
> > display, split over both lines. Let me know if there is something else
> > you would like me to do to test this!
> >
> > Tested-by: David Reaver <me@davidreaver.com>
>
> Thanks a lot, that is very helpful!
>
> I will wait a while in case Christian or somebody else wants to test
> it, and send it for 6.6.
Hi Miguel,
in the meantime, I will send V2 of the patch with the changes you
suggested for the commit message and the comments.
Hugo.
next prev parent reply other threads:[~2023-07-22 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-06 18:50 Hugo Villeneuve
2023-07-06 19:33 ` Miguel Ojeda
2023-07-06 19:49 ` Hugo Villeneuve
2023-07-20 16:49 ` poeschel
2023-07-22 14:46 ` David Reaver
2023-07-22 16:04 ` Miguel Ojeda
2023-07-22 18:07 ` Hugo Villeneuve [this message]
2023-08-16 15:22 ` Christian Meusel
2023-08-19 19:56 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230722140743.fe710f4f12c344f07d879c88@hugovil.com \
--to=hugo@hugovil.com \
--cc=christian.meusel@posteo.de \
--cc=geert@linux-m68k.org \
--cc=hvilleneuve@dimonoff.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@davidreaver.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=poeschel@lemonage.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®