mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Adrián Moreno" <amorenoz@redhat.com>,
	"Ilya Maximets" <i.maximets@ovn.org>
Cc: Matthieu Baerts <matttbe@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	 Masami Hiramatsu <mhiramat@kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
	Aaron Conole	 <aconole@redhat.com>,
	Eelco Chaudron <echaudro@redhat.com>,
	dev@openvswitch.org, 	linux-trace-kernel@vger.kernel.org,
	linux-kernel@vger.kernel.org, 	netdev@vger.kernel.org,
	Antoine Tenart <atenart@kernel.org>
Subject: Re: [PATCH v6 3/4] net: dropreason: use new __print_sym() in tracing
Date: Tue, 22 Sep 2026 16:59:40 +0200	[thread overview]
Message-ID: <7ec27c80d766884c5f0d5d0c190d2c06ebeda6e5.camel@sipsolutions.net> (raw)
In-Reply-To: <CAG=2xmNURzYdR+eL8x_kW64Bo9gEe3ne88YXaKQKT+_Ya7XZFQ@mail.gmail.com>

On Tue, 2026-09-22 at 07:35 -0700, Adrián Moreno wrote:
> > 
> > IIUC, this change only affects the printing and doesn't affect debugging
> > tools like retis that attempt to surface the drop reasons.  But, maybe
> > Adrian and Antoine (CCed) may want to have a glance as well.
> > 
> 
> I don't think this will affect retis in a bad way. We collect the list
> of drop reasons by inspecting the BTF enums. It generally works but we
> need to keep track of new subsystems enums being added

Right, that wouldn't really change.

> so a dynamically-generated full-list of drop reasons is interesting.

> IIUC, the only way for userspace to read this list is by looking at the
> event format and parse the printf line, right? Any ideas to make this
> more machine-friendly?

It's intended to be machine friendly "enough", trace-cmd/perf (via
libtraceevent or so I think?) parse and use this? But it's also only
available when tracing is enabled.

I think if you really wanted to have a full list dynamically exposed at
runtime across all kernels, then perhaps dropmonitor or some other
netlink interface could expose it? Or maybe another debugfs/sysfs file?
I don't know what you need it for, but I think it's out of scope for
this patchset, and could even be done without it?

johannes

  reply	other threads:[~2026-09-22 14:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-21 10:06 [PATCH v6 0/4] tracing: improve symbolic printing Johannes Berg
2026-09-21 10:06 ` [PATCH v6 1/4] tracing: add __print_sym() to replace __print_symbolic() Johannes Berg
2026-09-21 10:06 ` [PATCH v6 2/4] tracing/timer: use __print_sym() Johannes Berg
2026-09-21 10:06 ` [PATCH v6 3/4] net: dropreason: use new __print_sym() in tracing Johannes Berg
2026-09-21 22:03   ` Matthieu Baerts
2026-09-21 22:23     ` Ilya Maximets
2026-09-21 22:36       ` Johannes Berg
2026-09-21 23:20         ` Johannes Berg
2026-09-22  9:01           ` Ilya Maximets
2026-09-22  9:03             ` Johannes Berg
2026-09-22 14:36             ` Adrián Moreno
2026-09-22 15:34             ` Aaron Conole
2026-09-22  7:18       ` Antoine Tenart
2026-09-22  8:48         ` Ilya Maximets
2026-09-22 14:35       ` Adrián Moreno
2026-09-22 14:59         ` Johannes Berg [this message]
2026-09-21 10:06 ` [PATCH v6 4/4] net: drop_monitor: use drop_reason_lookup() Johannes Berg
2026-09-21 21:59 ` [PATCH v6 0/4] tracing: improve symbolic printing Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ec27c80d766884c5f0d5d0c190d2c06ebeda6e5.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=aconole@redhat.com \
    --cc=amorenoz@redhat.com \
    --cc=atenart@kernel.org \
    --cc=dev@openvswitch.org \
    --cc=echaudro@redhat.com \
    --cc=i.maximets@ovn.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-trace-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@efficios.com \
    --cc=matttbe@kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®