From: Matthieu Baerts <matttbe@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Johannes Berg <johannes.berg@intel.com>,
Aaron Conole <aconole@redhat.com>,
Eelco Chaudron <echaudro@redhat.com>,
Ilya Maximets <i.maximets@ovn.org>,
dev@openvswitch.org, linux-trace-kernel@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v6 3/4] net: dropreason: use new __print_sym() in tracing
Date: Tue, 22 Sep 2026 00:03:01 +0200 [thread overview]
Message-ID: <98b93c98-21ae-4248-a60a-9625a20508ad@kernel.org> (raw)
In-Reply-To: <20260921101538.97286-9-johannes@sipsolutions.net>
Hi Johannes,
(+Cc openvswitch devs)
On 21/09/2026 12:06, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> The __print_symbolic() could only ever print the core
> drop reasons, since that's the way the infrastructure
> works. Now that we have __print_sym() with all the
> advantages mentioned in that commit, convert to that
> and get all the drop reasons from all subsystems. As
> we already have a list of them, that's really easy.
>
> This is a little bit of .text (~100 bytes in my build)
> and saves a lot of .data (~17k).
Thank you for working on that! But it looks like it breaks the
openvswitch test:
https://netdev-ctrl.bots.linux.dev/logview.html?f=%2Flogs%2Fvmksft%2Fnet%2Fresults%2F833743%2F9-openvswitch-sh%2Fstdout#L168
Maybe the test needs to be adapted to get the same info differently?
(and adding CONFIG_TRACEPOINTS to the selftest config file)
Cheers,
Matt
next prev parent reply other threads:[~2026-09-21 22:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 10:06 [PATCH v6 0/4] tracing: improve symbolic printing Johannes Berg
2026-09-21 10:06 ` [PATCH v6 1/4] tracing: add __print_sym() to replace __print_symbolic() Johannes Berg
2026-09-21 10:06 ` [PATCH v6 2/4] tracing/timer: use __print_sym() Johannes Berg
2026-09-21 10:06 ` [PATCH v6 3/4] net: dropreason: use new __print_sym() in tracing Johannes Berg
2026-09-21 22:03 ` Matthieu Baerts [this message]
2026-09-21 22:23 ` Ilya Maximets
2026-09-21 22:36 ` Johannes Berg
2026-09-21 23:20 ` Johannes Berg
2026-09-22 9:01 ` Ilya Maximets
2026-09-22 9:03 ` Johannes Berg
2026-09-22 14:36 ` Adrián Moreno
2026-09-22 15:34 ` Aaron Conole
2026-09-22 7:18 ` Antoine Tenart
2026-09-22 8:48 ` Ilya Maximets
2026-09-22 14:35 ` Adrián Moreno
2026-09-22 14:59 ` Johannes Berg
2026-09-21 10:06 ` [PATCH v6 4/4] net: drop_monitor: use drop_reason_lookup() Johannes Berg
2026-09-21 21:59 ` [PATCH v6 0/4] tracing: improve symbolic printing Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=98b93c98-21ae-4248-a60a-9625a20508ad@kernel.org \
--to=matttbe@kernel.org \
--cc=aconole@redhat.com \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=i.maximets@ovn.org \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®