From: Marek Vasut <marex@denx.de>
To: Marco Felsch <m.felsch@pengutronix.de>,
Florian Fainelli <f.fainelli@gmail.com>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org, mkl@pengutronix.de,
kernel@pengutronix.de, David Jander <david@protonic.nl>
Subject: Re: PHY reset question
Date: Wed, 7 Oct 2020 10:23:14 +0200 [thread overview]
Message-ID: <7edb2e01-bec5-05b0-aa47-caf6e214e5a0@denx.de> (raw)
In-Reply-To: <20201007081410.jk5fi6x5w3ab3726@pengutronix.de>
On 10/7/20 10:14 AM, Marco Felsch wrote:
> Hi Marek,
Hi,
[...]
> On 20-10-06 14:11, Florian Fainelli wrote:
>> On 10/6/2020 1:24 PM, Marek Vasut wrote:
>
> ...
>
>>> If this happens on MX6 with FEC, can you please try these two patches?
>>>
>>> https://patchwork.ozlabs.org/project/netdev/patch/20201006135253.97395-1-marex@denx.de/
>>>
>>> https://patchwork.ozlabs.org/project/netdev/patch/20201006202029.254212-1-marex@denx.de/
>>
>> Your patches are not scaling across multiple Ethernet MAC drivers
>> unfortunately, so I am not sure this should be even remotely considered a
>> viable solution.
>
> Recently I added clk support for the smcs driver [1] and dropped the
> PHY_RST_AFTER_CLK_EN flag for LAN8710/20 devices because I had the same
> issues. Hope this will help you too.
>
> [1] https://www.spinics.net/lists/netdev/msg682080.html
I feel this might be starting to go a bit off-topic here, but isn't the
last patch 5/5 breaking existing setups ? The LAN8710 surely does need
clock enabled before the reset line is toggled.
next prev parent reply other threads:[~2020-10-07 8:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 8:04 Oleksij Rempel
2020-10-06 19:36 ` Florian Fainelli
2020-10-06 20:24 ` Marek Vasut
2020-10-06 21:11 ` Florian Fainelli
2020-10-06 22:24 ` Marek Vasut
2020-10-07 8:14 ` Marco Felsch
2020-10-07 8:23 ` Marek Vasut [this message]
2020-10-07 9:06 ` Marco Felsch
2020-10-07 9:20 ` Marek Vasut
2020-10-07 10:47 ` Marco Felsch
2020-10-07 15:44 ` Florian Fainelli
2020-10-07 9:50 ` Fabio Estevam
2020-10-09 14:25 ` Bruno Thomsen
2020-10-12 5:48 ` Oleksij Rempel
2020-10-12 8:25 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7edb2e01-bec5-05b0-aa47-caf6e214e5a0@denx.de \
--to=marex@denx.de \
--cc=andrew@lunn.ch \
--cc=david@protonic.nl \
--cc=f.fainelli@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.felsch@pengutronix.de \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®