mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: st: fix arm,smc-id of the SMC watchdog on stm32mp2
@ 2026-09-07  9:14 Mateusz Nowicki
  2026-09-08  8:52 ` [Linux-stm32] [PATCH] arm64: dts: st: fix arm, smc-id " Antonio Borneo
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Mateusz Nowicki @ 2026-09-07  9:14 UTC (permalink / raw)
  To: alexandre.torgue, mcoquelin.stm32
  Cc: robh, krzk+dt, conor+dt, lionel.debieve, amelie.delaunay,
	patrice.chotard, devicetree, linux-stm32, linux-arm-kernel,
	linux-kernel

OP-TEE implements the STM32MP2 watchdog SMC service with function ID
0xbc000000 (CFG_WDT_SM_HANDLER_ID), not 0xb200005a. With the current
value the arm_smc_wdt probe fails with -EIO and the IWDG started by the
bootloader is never refreshed.

Fixes: 89fca38168c9 ("arm64: dts: st: add arm-wdt node for watchdog support on stm32mp251")
Fixes: e9b03ef21386 ("arm64: dts: st: introduce stm32mp23 SoCs family")
Signed-off-by: Mateusz Nowicki <mateusz.nowicki@posteo.net>
---
 arch/arm64/boot/dts/st/stm32mp231.dtsi | 2 +-
 arch/arm64/boot/dts/st/stm32mp251.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi
index 9e1d240888ff..35e247af957c 100644
--- a/arch/arm64/boot/dts/st/stm32mp231.dtsi
+++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi
@@ -35,7 +35,7 @@ arm-pmu {
 
 	arm_wdt: watchdog {
 		compatible = "arm,smc-wdt";
-		arm,smc-id = <0xb200005a>;
+		arm,smc-id = <0xbc000000>;
 		status = "disabled";
 	};
 
diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
index 9c63fdb5a885..2dcbba65e298 100644
--- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
+++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
@@ -36,7 +36,7 @@ arm-pmu {
 
 	arm_wdt: watchdog {
 		compatible = "arm,smc-wdt";
-		arm,smc-id = <0xb200005a>;
+		arm,smc-id = <0xbc000000>;
 		status = "disabled";
 	};
 
-- 
2.55.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Linux-stm32] [PATCH] arm64: dts: st: fix arm, smc-id of the SMC watchdog on stm32mp2
  2026-09-07  9:14 [PATCH] arm64: dts: st: fix arm,smc-id of the SMC watchdog on stm32mp2 Mateusz Nowicki
@ 2026-09-08  8:52 ` Antonio Borneo
  2026-09-23 11:52 ` [PATCH] arm64: dts: st: fix arm,smc-id " Mateusz Nowicki
  2026-09-28  8:45 ` Alexandre TORGUE
  2 siblings, 0 replies; 4+ messages in thread
From: Antonio Borneo @ 2026-09-08  8:52 UTC (permalink / raw)
  To: Mateusz Nowicki, alexandre.torgue, mcoquelin.stm32
  Cc: robh, conor+dt, devicetree, linux-stm32, linux-kernel, krzk+dt,
	linux-arm-kernel

On Mon, 2026-09-07 at 09:14 +0000, Mateusz Nowicki wrote:
> OP-TEE implements the STM32MP2 watchdog SMC service with function ID
> 0xbc000000 (CFG_WDT_SM_HANDLER_ID), not 0xb200005a. With the current
> value the arm_smc_wdt probe fails with -EIO and the IWDG started by the
> bootloader is never refreshed.
> 
> Fixes: 89fca38168c9 ("arm64: dts: st: add arm-wdt node for watchdog support on stm32mp251")
> Fixes: e9b03ef21386 ("arm64: dts: st: introduce stm32mp23 SoCs family")
> Signed-off-by: Mateusz Nowicki <mateusz.nowicki@posteo.net>

Reviewed-by: Antonio Borneo <antonio.borneo@foss.st.com>

Thanks,
Antonio

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: st: fix arm,smc-id of the SMC watchdog on stm32mp2
  2026-09-07  9:14 [PATCH] arm64: dts: st: fix arm,smc-id of the SMC watchdog on stm32mp2 Mateusz Nowicki
  2026-09-08  8:52 ` [Linux-stm32] [PATCH] arm64: dts: st: fix arm, smc-id " Antonio Borneo
@ 2026-09-23 11:52 ` Mateusz Nowicki
  2026-09-28  8:45 ` Alexandre TORGUE
  2 siblings, 0 replies; 4+ messages in thread
From: Mateusz Nowicki @ 2026-09-23 11:52 UTC (permalink / raw)
  To: alexandre.torgue, mcoquelin.stm32
  Cc: antonio.borneo, robh, krzk+dt, conor+dt, lionel.debieve,
	amelie.delaunay, patrice.chotard, devicetree, linux-stm32,
	linux-arm-kernel, linux-kernel

Hi Alexandre,

Gentle ping on this fix, Antonio gave his Reviewed-by on Sep 8.

On current stm32-next the SMC watchdog still fails to probe on the
STM32MP257F-DK:

    arm_smc_wdt watchdog: probe with driver arm_smc_wdt failed with error -5

Could you take it for v7.4?

Thanks,
Mateusz

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm64: dts: st: fix arm,smc-id of the SMC watchdog on stm32mp2
  2026-09-07  9:14 [PATCH] arm64: dts: st: fix arm,smc-id of the SMC watchdog on stm32mp2 Mateusz Nowicki
  2026-09-08  8:52 ` [Linux-stm32] [PATCH] arm64: dts: st: fix arm, smc-id " Antonio Borneo
  2026-09-23 11:52 ` [PATCH] arm64: dts: st: fix arm,smc-id " Mateusz Nowicki
@ 2026-09-28  8:45 ` Alexandre TORGUE
  2 siblings, 0 replies; 4+ messages in thread
From: Alexandre TORGUE @ 2026-09-28  8:45 UTC (permalink / raw)
  To: Mateusz Nowicki, mcoquelin.stm32
  Cc: robh, krzk+dt, conor+dt, lionel.debieve, amelie.delaunay,
	patrice.chotard, devicetree, linux-stm32, linux-arm-kernel,
	linux-kernel

Hi Mateusz

On 9/7/26 11:14, Mateusz Nowicki wrote:
> OP-TEE implements the STM32MP2 watchdog SMC service with function ID
> 0xbc000000 (CFG_WDT_SM_HANDLER_ID), not 0xb200005a. With the current
> value the arm_smc_wdt probe fails with -EIO and the IWDG started by the
> bootloader is never refreshed.
> 
> Fixes: 89fca38168c9 ("arm64: dts: st: add arm-wdt node for watchdog support on stm32mp251")
> Fixes: e9b03ef21386 ("arm64: dts: st: introduce stm32mp23 SoCs family")
> Signed-off-by: Mateusz Nowicki <mateusz.nowicki@posteo.net>
> ---
>   arch/arm64/boot/dts/st/stm32mp231.dtsi | 2 +-
>   arch/arm64/boot/dts/st/stm32mp251.dtsi | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/st/stm32mp231.dtsi b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> index 9e1d240888ff..35e247af957c 100644
> --- a/arch/arm64/boot/dts/st/stm32mp231.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp231.dtsi
> @@ -35,7 +35,7 @@ arm-pmu {
>   
>   	arm_wdt: watchdog {
>   		compatible = "arm,smc-wdt";
> -		arm,smc-id = <0xb200005a>;
> +		arm,smc-id = <0xbc000000>;
>   		status = "disabled";
>   	};
>   
> diff --git a/arch/arm64/boot/dts/st/stm32mp251.dtsi b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> index 9c63fdb5a885..2dcbba65e298 100644
> --- a/arch/arm64/boot/dts/st/stm32mp251.dtsi
> +++ b/arch/arm64/boot/dts/st/stm32mp251.dtsi
> @@ -36,7 +36,7 @@ arm-pmu {
>   
>   	arm_wdt: watchdog {
>   		compatible = "arm,smc-wdt";
> -		arm,smc-id = <0xb200005a>;
> +		arm,smc-id = <0xbc000000>;
>   		status = "disabled";
>   	};
>   

Applied on stm32-next.

Thanks
Alex

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-09-28  8:45 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-09-07  9:14 [PATCH] arm64: dts: st: fix arm,smc-id of the SMC watchdog on stm32mp2 Mateusz Nowicki
2026-09-08  8:52 ` [Linux-stm32] [PATCH] arm64: dts: st: fix arm, smc-id " Antonio Borneo
2026-09-23 11:52 ` [PATCH] arm64: dts: st: fix arm,smc-id " Mateusz Nowicki
2026-09-28  8:45 ` Alexandre TORGUE

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®