mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] tools/spi: Return failure from spidev_fdx on I/O errors
@ 2026-11-20  6:19 Zhu Jun
  2026-11-20 11:59 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Zhu Jun @ 2026-11-20  6:19 UTC (permalink / raw)
  To: broonie; +Cc: rdunlap, linux-spi, linux-kernel, Zhu Jun

spidev_fdx logs failed ioctls and failed or short reads, but always
exits successfully once the device opens. Return an error from the
helpers and translate it to a failing exit status after closing the
file descriptor.

Fixes: 31a16294261a ("documentation: move spidev_fdx example to its own source file")
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 tools/spi/spidev_fdx.c | 39 ++++++++++++++++++++-------------------
 1 file changed, 20 insertions(+), 19 deletions(-)

diff --git a/tools/spi/spidev_fdx.c b/tools/spi/spidev_fdx.c
index bc9c4f6c3ba8..45f0fd2444dd 100644
--- a/tools/spi/spidev_fdx.c
+++ b/tools/spi/spidev_fdx.c
@@ -15,7 +15,7 @@
 
 static int verbose;
 
-static void do_read(int fd, int len)
+static int do_read(int fd, int len)
 {
 	unsigned char	buf[32], *bp;
 	int		status;
@@ -30,11 +30,11 @@ static void do_read(int fd, int len)
 	status = read(fd, buf, len);
 	if (status < 0) {
 		perror("read");
-		return;
+		return -1;
 	}
 	if (status != len) {
 		fprintf(stderr, "short read\n");
-		return;
+		return -1;
 	}
 
 	printf("read(%2d, %2d): %02x %02x,", len, status,
@@ -44,9 +44,10 @@ static void do_read(int fd, int len)
 	while (status-- > 0)
 		printf(" %02x", *bp++);
 	printf("\n");
+	return 0;
 }
 
-static void do_msg(int fd, int len)
+static int do_msg(int fd, int len)
 {
 	struct spi_ioc_transfer	xfer[2];
 	unsigned char		buf[32], *bp;
@@ -68,39 +69,41 @@ static void do_msg(int fd, int len)
 	status = ioctl(fd, SPI_IOC_MESSAGE(2), xfer);
 	if (status < 0) {
 		perror("SPI_IOC_MESSAGE");
-		return;
+		return -1;
 	}
 
 	printf("response(%2d, %2d): ", len, status);
 	for (bp = buf; len; len--)
 		printf(" %02x", *bp++);
 	printf("\n");
+	return 0;
 }
 
-static void dumpstat(const char *name, int fd)
+static int dumpstat(const char *name, int fd)
 {
 	__u8	lsb, bits;
 	__u32	mode, speed;
 
 	if (ioctl(fd, SPI_IOC_RD_MODE32, &mode) < 0) {
 		perror("SPI rd_mode");
-		return;
+		return -1;
 	}
 	if (ioctl(fd, SPI_IOC_RD_LSB_FIRST, &lsb) < 0) {
 		perror("SPI rd_lsb_fist");
-		return;
+		return -1;
 	}
 	if (ioctl(fd, SPI_IOC_RD_BITS_PER_WORD, &bits) < 0) {
 		perror("SPI bits_per_word");
-		return;
+		return -1;
 	}
 	if (ioctl(fd, SPI_IOC_RD_MAX_SPEED_HZ, &speed) < 0) {
 		perror("SPI max_speed_hz");
-		return;
+		return -1;
 	}
 
 	printf("%s: spi mode 0x%x, %d bits %sper word, %u Hz max\n",
 		name, mode, bits, lsb ? "(lsb first) " : "", speed);
+	return 0;
 }
 
 int main(int argc, char **argv)
@@ -108,7 +111,7 @@ int main(int argc, char **argv)
 	int		c;
 	int		readcount = 0;
 	int		msglen = 0;
-	int		fd;
+	int		fd, ret;
 	const char	*name;
 
 	while ((c = getopt(argc, argv, "hm:r:v")) != EOF) {
@@ -146,14 +149,12 @@ int main(int argc, char **argv)
 		return 1;
 	}
 
-	dumpstat(name, fd);
-
-	if (msglen)
-		do_msg(fd, msglen);
-
-	if (readcount)
-		do_read(fd, readcount);
+	ret = dumpstat(name, fd);
+	if (!ret && msglen)
+		ret = do_msg(fd, msglen);
+	if (!ret && readcount)
+		ret = do_read(fd, readcount);
 
 	close(fd);
-	return 0;
+	return ret ? EXIT_FAILURE : EXIT_SUCCESS;
 }



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-11-20 12:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-20  6:19 [PATCH] tools/spi: Return failure from spidev_fdx on I/O errors Zhu Jun
2026-11-20 11:59 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®