From: Harikrishna Shenoy <h-shenoy@ti.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: <andrzej.hajda@intel.com>, <neil.armstrong@linaro.org>,
<rfoss@kernel.org>, <Laurent.pinchart@ideasonboard.com>,
<jonas@kwiboo.se>, <jernej.skrabec@gmail.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
<lumag@kernel.org>, <dianders@chromium.org>,
<andy.yan@rock-chips.com>, <mordan@ispras.ru>,
<linux@treblig.org>, <viro@zeniv.linux.org.uk>,
<aradhya.bhatia@linux.dev>, <javierm@redhat.com>,
<tomi.valkeinen@ideasonboard.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<devarsht@ti.com>, <u-kumar1@ti.com>, <s-jain1@ti.com>,
<lyude@redhat.com>, <luca.ceresoli@bootlin.com>
Subject: Re: [PATCH v6 1/6] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge
Date: Wed, 10 Sep 2025 14:29:18 +0530 [thread overview]
Message-ID: <7ef2071a-0c57-4ca8-af67-ed254d5d2faf@ti.com> (raw)
In-Reply-To: <gptscrssnl7lck6ga6bzu4grcjcbokbdznbg4skbpvrmuo57ex@4zjugogguuw4>
On 9/9/25 19:39, Dmitry Baryshkov wrote:
> On Tue, Sep 09, 2025 at 02:38:19PM +0530, Harikrishna Shenoy wrote:
>> From: Jayesh Choudhary <j-choudhary@ti.com>
>>
>> Now that we have DBANC framework, remove the connector initialisation code
>> as that piece of code is not called if DRM_BRIDGE_ATTACH_NO_CONNECTOR flag
>> is used. Only TI K3 platforms consume this driver and tidss (their display
>> controller) has this flag set. So this legacy support can be dropped.
>>
>> Fixes: c932ced6b585 ("drm/tidss: Update encoder/bridge chain connect model")
> I'm not sure, why do you have this Fixes tag. Other than that:
>
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
>
>
Hi Dmitry,
Have explained about fixes tag in cover letter, that these 4 commits
fix the bug of null pointer de-refernce (logs and bug described in cover
letter).
also have given the rationale of sequencing of commits in cover letter.
Warm Regards,
Hari
>> Signed-off-by: Jayesh Choudhary <j-choudhary@ti.com>
>> ---
>> .../drm/bridge/cadence/cdns-mhdp8546-core.c | 187 +-----------------
>> 1 file changed, 10 insertions(+), 177 deletions(-)
>>
next prev parent reply other threads:[~2025-09-10 9:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 9:08 [PATCH v6 0/6] MHDP8546 fixes related to DBANC usecase Harikrishna Shenoy
2025-09-09 9:08 ` [PATCH v6 1/6] drm/bridge: cadence: cdns-mhdp8546-core: Remove legacy support for connector initialisation in bridge Harikrishna Shenoy
2025-09-09 14:09 ` Dmitry Baryshkov
2025-09-10 8:59 ` Harikrishna Shenoy [this message]
2025-09-09 9:08 ` [PATCH v6 2/6] drm/bridge: cadence: cdns-mhdp8546*: Change drm_connector from structure to pointer Harikrishna Shenoy
2025-09-09 14:12 ` Dmitry Baryshkov
2025-09-10 9:48 ` Harikrishna Shenoy
2025-09-09 9:08 ` [PATCH v6 3/6] drm/bridge: cadence: cdns-mhdp8546-core: Set the mhdp connector earlier in atomic_enable() Harikrishna Shenoy
2025-09-09 14:14 ` Dmitry Baryshkov
2025-09-10 9:42 ` Harikrishna Shenoy
2025-09-09 9:08 ` [PATCH v6 4/6] drm/bridge: cadence: cdns-mhdp8546-core: Add mode_valid hook to drm_bridge_funcs Harikrishna Shenoy
2025-09-09 9:08 ` [PATCH v6 5/6] drm/bridge: cadence: cdns-mhdp8546-core: Reduce log level for DPCD read/write Harikrishna Shenoy
2025-09-09 9:08 ` [PATCH v6 6/6] drm/bridge: cadence: cdns-mhdp8546-core: Handle HDCP state in bridge atomic check Harikrishna Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ef2071a-0c57-4ca8-af67-ed254d5d2faf@ti.com \
--to=h-shenoy@ti.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=aradhya.bhatia@linux.dev \
--cc=devarsht@ti.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=javierm@redhat.com \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@treblig.org \
--cc=luca.ceresoli@bootlin.com \
--cc=lumag@kernel.org \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mordan@ispras.ru \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=s-jain1@ti.com \
--cc=simona@ffwll.ch \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=tzimmermann@suse.de \
--cc=u-kumar1@ti.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®