* [PATCH v4 0/4] arm64: qcom: dts: Add display support for Qualcomm Shikra
@ 2026-09-16 9:11 Nabige Aala
2026-09-16 9:11 ` [PATCH v4 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala
` (3 more replies)
0 siblings, 4 replies; 11+ messages in thread
From: Nabige Aala @ 2026-09-16 9:11 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Abel Vesa
Cc: Arpit Saini, Nabige Aala, linux-arm-msm, devicetree,
linux-kernel, Konrad Dybcio
This series adds display support for the Qualcomm Shikra platform.
It introduces the Qualcomm Shikra MDSS display subsystem support
at the SoC level, and enables display on the Qualcomm Shikra CQS
EVK and CQM EVK boards with the required DSI panel nodes.
---
Changes in v4:
- Rebased on top of next-20260915 tag.
- Dropped all prerequisite-message-id references since the dependent
patches have been merged.
- Link to v3:
https://lore.kernel.org/all/20260713-shikra-dt-changes-v3-0-15102fca9570@oss.qualcomm.com/
Changes in v3:
- Drop redundant vph_pwr fixed-regulator node (Krzysztof Kozlowski)
- Remove vin-supply = <&vph_pwr> from lcd_bias node (Krzysztof
Kozlowski).
- Add the new line between the last property and the following
subnodes in mdss block(Konrad).
- Link to v2: https://patch.msgid.link/20260706-shikra-dt-changes-v2-0-56fcd1659ea4@oss.qualcomm.com
Changes in v2:
- Replace QCM2290-specific RPM power domain identifiers with generic
RPMPD_VDDCX/VDDMX macros in Shikra display and DSI nodes.
- Add missing blank line before status = "okay" in &mdss_dsi0 node(Dmitry).
- Split avdd-supply and avee-supply into separate regulators vreg_disp_p
and vreg_disp_n instead of sharing the same lcd_bias regulator(Dmitry).
- Sort tlmm pin state entries by pin number: gpio3, gpio86, gpio91,
gpio151 (Dmitry).
- Add vph_pwr as an always-on fixed regulator representing the main
board power supply, used as vin-supply for lcd_bias.
- Droped the 5th patch "Shikra LT9611UXD support". NAK by Dmitry. Once
the hdmi-dsi driver is fixed then we will post DT changes.
- Link to v1: https://patch.msgid.link/20260627-shikra-dt-changes-v1-0-449a402673d0@oss.qualcomm.com
Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>
To: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzk+dt@kernel.org>
To: Conor Dooley <conor+dt@kernel.org>
To: Abel Vesa <abelvesa@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: arpit.saini@oss.qualcomm.com
---
Arpit Saini (3):
arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel
arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
arm64: defconfig: Enable ILI7807S DSI panel driver
Nabige Aala (1):
arm64: dts: qcom: shikra: Add MDSS display subsystem
arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 118 ++++++++++++++++
arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 118 ++++++++++++++++
arch/arm64/boot/dts/qcom/shikra.dtsi | 206 +++++++++++++++++++++++++++-
arch/arm64/configs/defconfig | 1 +
4 files changed, 441 insertions(+), 2 deletions(-)
---
base-commit: e6e35979777d646fe3c7c94dca7dd32fb25d45f4
change-id: 20260626-shikra-dt-changes-8d127be951d5
Best regards,
--
Nabige Aala <nabige.aala@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH v4 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem 2026-09-16 9:11 [PATCH v4 0/4] arm64: qcom: dts: Add display support for Qualcomm Shikra Nabige Aala @ 2026-09-16 9:11 ` Nabige Aala 2026-09-22 16:05 ` Dmitry Baryshkov 2026-09-16 9:11 ` [PATCH v4 2/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala ` (2 subsequent siblings) 3 siblings, 1 reply; 11+ messages in thread From: Nabige Aala @ 2026-09-16 9:11 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: Arpit Saini, Nabige Aala, linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio Add the SoC-level display subsystem nodes for Qualcomm Shikra: MDSS wrapper,DPU display controller, DSI host controller, and 14nm DSI PHY. Qualcomm Shikra uses DPU 6.5 hardware (same as QCM2290). Platform-specific compatible strings are used as the primary match with QCM2290 fallbacks to reuse the existing driver support. The dispcc clock inputs for the DSI byte and pixel PLLs are wired from mdss_dsi0_phy. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/shikra.dtsi | 206 ++++++++++++++++++++++++++++++++++- 1 file changed, 204 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/shikra.dtsi b/arch/arm64/boot/dts/qcom/shikra.dtsi index c1f06f692f66..9375a8be46aa 100644 --- a/arch/arm64/boot/dts/qcom/shikra.dtsi +++ b/arch/arm64/boot/dts/qcom/shikra.dtsi @@ -4,6 +4,7 @@ */ #include <dt-bindings/clock/qcom,dispcc-qcm2290.h> +#include <dt-bindings/clock/qcom,dsi-phy-28nm.h> #include <dt-bindings/clock/qcom,qcm2290-gpucc.h> #include <dt-bindings/clock/qcom,rpmcc.h> #include <dt-bindings/clock/qcom,shikra-gcc.h> @@ -2281,6 +2282,207 @@ adreno_smmu: iommu@59a0000 { power-domains = <&gpucc GPU_CX_GDSC>; }; + mdss: display-subsystem@5e00000 { + compatible = "qcom,shikra-mdss", "qcom,qcm2290-mdss"; + reg = <0x0 0x05e00000 0x0 0x1000>; + reg-names = "mdss"; + interrupts = <GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH 0>; + interrupt-controller; + #interrupt-cells = <1>; + + clocks = <&gcc GCC_DISP_AHB_CLK>, + <&gcc GCC_DISP_HF_AXI_CLK>, + <&dispcc DISP_CC_MDSS_MDP_CLK>; + clock-names = "iface", + "bus", + "core"; + + resets = <&dispcc DISP_CC_MDSS_CORE_BCR>; + + power-domains = <&dispcc MDSS_GDSC>; + + iommus = <&apps_smmu 0x420 0x2>; + interconnects = <&mmrt_virt MASTER_MDP_PORT0 RPM_ALWAYS_TAG + &mc_virt SLAVE_EBI_CH0 RPM_ALWAYS_TAG>, + <&mem_noc MASTER_AMPSS_M0 RPM_ALWAYS_TAG + &config_noc SLAVE_DISPLAY_CFG RPM_ALWAYS_TAG>; + interconnect-names = "mdp0-mem", + "cpu-cfg"; + + #address-cells = <2>; + #size-cells = <2>; + ranges; + + status = "disabled"; + + mdp: display-controller@5e01000 { + compatible = "qcom,shikra-dpu", "qcom,qcm2290-dpu"; + reg = <0x0 0x05e01000 0x0 0x8f000>, + <0x0 0x05eb0000 0x0 0x3000>; + reg-names = "mdp", + "vbif"; + + interrupt-parent = <&mdss>; + interrupts = <0>; + + clocks = <&gcc GCC_DISP_HF_AXI_CLK>, + <&dispcc DISP_CC_MDSS_AHB_CLK>, + <&dispcc DISP_CC_MDSS_MDP_CLK>, + <&dispcc DISP_CC_MDSS_MDP_LUT_CLK>, + <&dispcc DISP_CC_MDSS_VSYNC_CLK>; + clock-names = "bus", + "iface", + "core", + "lut", + "vsync"; + + operating-points-v2 = <&mdp_opp_table>; + power-domains = <&rpmpd RPMPD_VDDCX>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + dpu_intf1_out: endpoint { + remote-endpoint = <&mdss_dsi0_in>; + }; + }; + }; + + mdp_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-19200000 { + opp-hz = /bits/ 64 <19200000>; + required-opps = <&rpmpd_opp_min_svs>; + }; + + opp-192000000 { + opp-hz = /bits/ 64 <192000000>; + required-opps = <&rpmpd_opp_low_svs>; + }; + + opp-256000000 { + opp-hz = /bits/ 64 <256000000>; + required-opps = <&rpmpd_opp_svs>; + }; + + opp-307200000 { + opp-hz = /bits/ 64 <307200000>; + required-opps = <&rpmpd_opp_svs_plus>; + }; + + opp-384000000 { + opp-hz = /bits/ 64 <384000000>; + required-opps = <&rpmpd_opp_nom>; + }; + }; + }; + + mdss_dsi0: dsi@5e94000 { + compatible = "qcom,shikra-dsi-ctrl", + "qcom,qcm2290-dsi-ctrl", + "qcom,mdss-dsi-ctrl"; + reg = <0x0 0x05e94000 0x0 0x400>; + reg-names = "dsi_ctrl"; + + interrupt-parent = <&mdss>; + interrupts = <4>; + + clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK>, + <&dispcc DISP_CC_MDSS_BYTE0_INTF_CLK>, + <&dispcc DISP_CC_MDSS_PCLK0_CLK>, + <&dispcc DISP_CC_MDSS_ESC0_CLK>, + <&dispcc DISP_CC_MDSS_AHB_CLK>, + <&gcc GCC_DISP_HF_AXI_CLK>; + clock-names = "byte", + "byte_intf", + "pixel", + "core", + "iface", + "bus"; + + assigned-clocks = <&dispcc DISP_CC_MDSS_BYTE0_CLK_SRC>, + <&dispcc DISP_CC_MDSS_PCLK0_CLK_SRC>; + assigned-clock-parents = <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>, + <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>; + + operating-points-v2 = <&dsi_opp_table>; + power-domains = <&rpmpd RPMPD_VDDCX>; + phys = <&mdss_dsi0_phy>; + + #address-cells = <1>; + #size-cells = <0>; + + status = "disabled"; + + dsi_opp_table: opp-table { + compatible = "operating-points-v2"; + + opp-19200000 { + opp-hz = /bits/ 64 <19200000>; + required-opps = <&rpmpd_opp_min_svs>; + }; + + opp-164000000 { + opp-hz = /bits/ 64 <164000000>; + required-opps = <&rpmpd_opp_low_svs>; + }; + + opp-187500000 { + opp-hz = /bits/ 64 <187500000>; + required-opps = <&rpmpd_opp_svs>; + }; + }; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + reg = <0>; + + mdss_dsi0_in: endpoint { + remote-endpoint = <&dpu_intf1_out>; + }; + }; + + port@1 { + reg = <1>; + + mdss_dsi0_out: endpoint { + }; + }; + }; + }; + + mdss_dsi0_phy: phy@5e94400 { + compatible = "qcom,dsi-phy-14nm-2290"; + reg = <0x0 0x05e94400 0x0 0x100>, + <0x0 0x05e94500 0x0 0x300>, + <0x0 0x05e94800 0x0 0x188>; + reg-names = "dsi_phy", + "dsi_phy_lane", + "dsi_pll"; + + clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, + <&rpmcc RPM_SMD_XO_CLK_SRC>; + clock-names = "iface", + "ref"; + + power-domains = <&rpmpd RPMPD_VDDMX>; + required-opps = <&rpmpd_opp_nom>; + + #clock-cells = <1>; + #phy-cells = <0>; + + status = "disabled"; + }; + }; + dispcc: clock-controller@5f00000 { compatible = "qcom,shikra-dispcc", "qcom,qcm2290-dispcc"; reg = <0x0 0x05f00000 0x0 0x20000>; @@ -2288,8 +2490,8 @@ dispcc: clock-controller@5f00000 { <&rpmcc RPM_SMD_XO_A_CLK_SRC>, <&gcc GCC_DISP_GPLL0_CLK_SRC>, <&gcc GCC_DISP_GPLL0_DIV_CLK_SRC>, - <0>, - <0>; + <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>, + <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>; clock-names = "bi_tcxo", "bi_tcxo_ao", "gcc_disp_gpll0_clk_src", -- 2.34.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem 2026-09-16 9:11 ` [PATCH v4 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala @ 2026-09-22 16:05 ` Dmitry Baryshkov 0 siblings, 0 replies; 11+ messages in thread From: Dmitry Baryshkov @ 2026-09-22 16:05 UTC (permalink / raw) To: Nabige Aala Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa, Arpit Saini, linux-arm-msm, devicetree, linux-kernel, Konrad Dybcio On Wed, Sep 16, 2026 at 02:41:18PM +0530, Nabige Aala wrote: > Add the SoC-level display subsystem nodes for Qualcomm Shikra: > MDSS wrapper,DPU display controller, DSI host controller, and > 14nm DSI PHY. > > Qualcomm Shikra uses DPU 6.5 hardware (same as QCM2290). Platform-specific > compatible strings are used as the primary match with QCM2290 fallbacks > to reuse the existing driver support. > > The dispcc clock inputs for the DSI byte and pixel PLLs are wired > from mdss_dsi0_phy. > > Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> > Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/shikra.dtsi | 206 ++++++++++++++++++++++++++++++++++- > 1 file changed, 204 insertions(+), 2 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 2/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel 2026-09-16 9:11 [PATCH v4 0/4] arm64: qcom: dts: Add display support for Qualcomm Shikra Nabige Aala 2026-09-16 9:11 ` [PATCH v4 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala @ 2026-09-16 9:11 ` Nabige Aala 2026-09-22 16:04 ` Dmitry Baryshkov 2026-09-16 9:11 ` [PATCH v4 3/4] arm64: dts: qcom: shikra-cqm-evk: " Nabige Aala 2026-09-16 9:11 ` [PATCH v4 4/4] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala 3 siblings, 1 reply; 11+ messages in thread From: Nabige Aala @ 2026-09-16 9:11 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: Arpit Saini, Nabige Aala, linux-arm-msm, devicetree, linux-kernel From: Arpit Saini <arpit.saini@oss.qualcomm.com> Enable the Shikra MDSS display subsystem on the Qualcomm Shikra CQS EVK board and add the DLC0697 MIPI DSI display panel node. Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 118 ++++++++++++++++++++++++++++ 1 file changed, 118 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts index e62ba5aef71f..a9067b710a22 100644 --- a/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts +++ b/arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts @@ -21,6 +21,78 @@ aliases { chosen { stdout-path = "serial0:115200n8"; }; + + lcd_bias: regulator-lcd-bias { + compatible = "regulator-fixed"; + regulator-name = "lcd_bias"; + gpio = <&tlmm 151 GPIO_ACTIVE_HIGH>; + enable-active-high; + pinctrl-0 = <&lcd_bias_en>; + pinctrl-names = "default"; + }; + + vreg_disp_n: regulator-vreg-disp-n { + compatible = "regulator-fixed"; + regulator-name = "vreg_disp_n"; + regulator-min-microvolt = <5500000>; + regulator-max-microvolt = <5500000>; + vin-supply = <&lcd_bias>; + }; + + vreg_disp_p: regulator-vreg-disp-p { + compatible = "regulator-fixed"; + regulator-name = "vreg_disp_p"; + regulator-min-microvolt = <5500000>; + regulator-max-microvolt = <5500000>; + vin-supply = <&lcd_bias>; + }; +}; + +&mdss { + status = "okay"; +}; + +&mdss_dsi0 { + vdda-supply = <&pm4125_l5>; + + status = "okay"; + + panel@0 { + compatible = "dlc,dlc0697", "ilitek,ili7807s"; + reg = <0>; + + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; + + vddi-supply = <&pm4125_l15>; + avdd-supply = <&vreg_disp_p>; + avee-supply = <&vreg_disp_n>; + + pinctrl-0 = <&panel_rst_n &panel_te_pin &panel_bl_en>; + pinctrl-1 = <&panel_rst_n_suspend &panel_bl_en_suspend>; + pinctrl-names = "default", "sleep"; + + port { + panel_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; +}; + +&mdss_dsi0_out { + remote-endpoint = <&panel_in>; + data-lanes = <0 1 2 3>; +}; + +&mdss_dsi0_phy { + status = "okay"; +}; + +&pm4125_l5 { + /* DSI VDDA - must be at NOM voltage for PHY PLL lock */ + regulator-min-microvolt = <1232000>; + regulator-max-microvolt = <1232000>; + regulator-allow-set-load; }; &remoteproc_cdsp { @@ -57,3 +129,49 @@ &sdhc_1 { status = "okay"; }; + +&tlmm { + panel_rst_n: panel-rst-n-state { + pins = "gpio3"; + function = "gpio"; + drive-strength = <8>; + bias-disable; + }; + + panel_rst_n_suspend: panel-rst-n-suspend-state { + pins = "gpio3"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; + }; + + panel_te_pin: panel-te-pin-state { + pins = "gpio86"; + function = "mdp_vsync_p"; + drive-strength = <2>; + bias-pull-down; + }; + + panel_bl_en: panel-bl-en-state { + pins = "gpio91"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + output-high; + }; + + panel_bl_en_suspend: panel-bl-en-suspend-state { + pins = "gpio91"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; + output-low; + }; + + lcd_bias_en: lcd-bias-en-state { + pins = "gpio151"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; +}; -- 2.34.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 2/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel 2026-09-16 9:11 ` [PATCH v4 2/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala @ 2026-09-22 16:04 ` Dmitry Baryshkov 0 siblings, 0 replies; 11+ messages in thread From: Dmitry Baryshkov @ 2026-09-22 16:04 UTC (permalink / raw) To: Nabige Aala Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa, Arpit Saini, linux-arm-msm, devicetree, linux-kernel On Wed, Sep 16, 2026 at 02:41:19PM +0530, Nabige Aala wrote: > From: Arpit Saini <arpit.saini@oss.qualcomm.com> > > Enable the Shikra MDSS display subsystem on the Qualcomm Shikra CQS EVK > board and add the DLC0697 MIPI DSI display panel node. > > Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com> > Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts | 118 ++++++++++++++++++++++++++++ > 1 file changed, 118 insertions(+) > > + > +&mdss_dsi0 { > + vdda-supply = <&pm4125_l5>; > + > + status = "okay"; > + > + panel@0 { > + compatible = "dlc,dlc0697", "ilitek,ili7807s"; > + reg = <0>; > + > + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; > + > + vddi-supply = <&pm4125_l15>; > + avdd-supply = <&vreg_disp_p>; > + avee-supply = <&vreg_disp_n>; > + > + pinctrl-0 = <&panel_rst_n &panel_te_pin &panel_bl_en>; > + pinctrl-1 = <&panel_rst_n_suspend &panel_bl_en_suspend>; Same question, panel_bl_en should be a regulator. > + pinctrl-names = "default", "sleep"; > + > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 3/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel 2026-09-16 9:11 [PATCH v4 0/4] arm64: qcom: dts: Add display support for Qualcomm Shikra Nabige Aala 2026-09-16 9:11 ` [PATCH v4 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala 2026-09-16 9:11 ` [PATCH v4 2/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala @ 2026-09-16 9:11 ` Nabige Aala 2026-09-22 16:03 ` Dmitry Baryshkov 2026-09-16 9:11 ` [PATCH v4 4/4] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala 3 siblings, 1 reply; 11+ messages in thread From: Nabige Aala @ 2026-09-16 9:11 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: Arpit Saini, Nabige Aala, linux-arm-msm, devicetree, linux-kernel From: Arpit Saini <arpit.saini@oss.qualcomm.com> Enable the Shikra MDSS display subsystem on the Qualcomm Shikra CQM EVK board and add the DLC0697 MIPI DSI display panel node. Pin pm4125_l5 to 1.232V with regulator-allow-set-load for DSI PHY PLL stability. Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 118 ++++++++++++++++++++++++++++ 1 file changed, 118 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts index b112b21b1d79..d9a0f32ce8d3 100644 --- a/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts +++ b/arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts @@ -21,6 +21,78 @@ aliases { chosen { stdout-path = "serial0:115200n8"; }; + + lcd_bias: regulator-lcd-bias { + compatible = "regulator-fixed"; + regulator-name = "lcd_bias"; + gpio = <&tlmm 151 GPIO_ACTIVE_HIGH>; + enable-active-high; + pinctrl-0 = <&lcd_bias_en>; + pinctrl-names = "default"; + }; + + vreg_disp_n: regulator-vreg-disp-n { + compatible = "regulator-fixed"; + regulator-name = "vreg_disp_n"; + regulator-min-microvolt = <5500000>; + regulator-max-microvolt = <5500000>; + vin-supply = <&lcd_bias>; + }; + + vreg_disp_p: regulator-vreg-disp-p { + compatible = "regulator-fixed"; + regulator-name = "vreg_disp_p"; + regulator-min-microvolt = <5500000>; + regulator-max-microvolt = <5500000>; + vin-supply = <&lcd_bias>; + }; +}; + +&mdss { + status = "okay"; +}; + +&mdss_dsi0 { + vdda-supply = <&pm4125_l5>; + + status = "okay"; + + panel@0 { + compatible = "dlc,dlc0697", "ilitek,ili7807s"; + reg = <0>; + + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; + + vddi-supply = <&pm4125_l15>; + avdd-supply = <&vreg_disp_p>; + avee-supply = <&vreg_disp_n>; + + pinctrl-0 = <&panel_rst_n &panel_te_pin &panel_bl_en>; + pinctrl-1 = <&panel_rst_n_suspend &panel_bl_en_suspend>; + pinctrl-names = "default", "sleep"; + + port { + panel_in: endpoint { + remote-endpoint = <&mdss_dsi0_out>; + }; + }; + }; +}; + +&mdss_dsi0_out { + remote-endpoint = <&panel_in>; + data-lanes = <0 1 2 3>; +}; + +&mdss_dsi0_phy { + status = "okay"; +}; + +&pm4125_l5 { + /* DSI VDDA - must be at NOM voltage for PHY PLL lock */ + regulator-min-microvolt = <1232000>; + regulator-max-microvolt = <1232000>; + regulator-allow-set-load; }; &remoteproc_cdsp { @@ -57,3 +129,49 @@ &sdhc_1 { status = "okay"; }; + +&tlmm { + panel_rst_n: panel-rst-n-state { + pins = "gpio3"; + function = "gpio"; + drive-strength = <8>; + bias-disable; + }; + + panel_rst_n_suspend: panel-rst-n-suspend-state { + pins = "gpio3"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; + }; + + panel_te_pin: panel-te-pin-state { + pins = "gpio86"; + function = "mdp_vsync_p"; + drive-strength = <2>; + bias-pull-down; + }; + + panel_bl_en: panel-bl-en-state { + pins = "gpio91"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + output-high; + }; + + panel_bl_en_suspend: panel-bl-en-suspend-state { + pins = "gpio91"; + function = "gpio"; + drive-strength = <2>; + bias-pull-down; + output-low; + }; + + lcd_bias_en: lcd-bias-en-state { + pins = "gpio151"; + function = "gpio"; + drive-strength = <2>; + bias-disable; + }; +}; -- 2.34.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel 2026-09-16 9:11 ` [PATCH v4 3/4] arm64: dts: qcom: shikra-cqm-evk: " Nabige Aala @ 2026-09-22 16:03 ` Dmitry Baryshkov 2026-09-23 10:46 ` Arpit Saini 0 siblings, 1 reply; 11+ messages in thread From: Dmitry Baryshkov @ 2026-09-22 16:03 UTC (permalink / raw) To: Nabige Aala Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa, Arpit Saini, linux-arm-msm, devicetree, linux-kernel On Wed, Sep 16, 2026 at 02:41:20PM +0530, Nabige Aala wrote: > From: Arpit Saini <arpit.saini@oss.qualcomm.com> > > Enable the Shikra MDSS display subsystem on the Qualcomm > Shikra CQM EVK board and add the DLC0697 MIPI DSI display > panel node. Pin pm4125_l5 to 1.232V with regulator-allow-set-load > for DSI PHY PLL stability. > > Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com> > Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> > --- > arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 118 ++++++++++++++++++++++++++++ > 1 file changed, 118 insertions(+) > > + > +&mdss_dsi0 { > + vdda-supply = <&pm4125_l5>; > + > + status = "okay"; > + > + panel@0 { > + compatible = "dlc,dlc0697", "ilitek,ili7807s"; > + reg = <0>; > + > + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; > + > + vddi-supply = <&pm4125_l15>; > + avdd-supply = <&vreg_disp_p>; > + avee-supply = <&vreg_disp_n>; > + > + pinctrl-0 = <&panel_rst_n &panel_te_pin &panel_bl_en>; As far as I remember, your panel_bl_en enables an external regulator. Why is it not described in this way? > + pinctrl-1 = <&panel_rst_n_suspend &panel_bl_en_suspend>; > + pinctrl-names = "default", "sleep"; > + > + port { > + panel_in: endpoint { > + remote-endpoint = <&mdss_dsi0_out>; > + }; > + }; > + }; > +}; > + -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel 2026-09-22 16:03 ` Dmitry Baryshkov @ 2026-09-23 10:46 ` Arpit Saini 2026-09-23 12:08 ` Dmitry Baryshkov 0 siblings, 1 reply; 11+ messages in thread From: Arpit Saini @ 2026-09-23 10:46 UTC (permalink / raw) To: Dmitry Baryshkov, Nabige Aala Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa, linux-arm-msm, devicetree, linux-kernel Hi Dmitry, On 9/22/2026 9:33 PM, Dmitry Baryshkov wrote: > On Wed, Sep 16, 2026 at 02:41:20PM +0530, Nabige Aala wrote: >> From: Arpit Saini <arpit.saini@oss.qualcomm.com> >> >> Enable the Shikra MDSS display subsystem on the Qualcomm >> Shikra CQM EVK board and add the DLC0697 MIPI DSI display >> panel node. Pin pm4125_l5 to 1.232V with regulator-allow-set-load >> for DSI PHY PLL stability. >> >> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com> >> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> >> --- >> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 118 ++++++++++++++++++++++++++++ >> 1 file changed, 118 insertions(+) >> >> + >> +&mdss_dsi0 { >> + vdda-supply = <&pm4125_l5>; >> + >> + status = "okay"; >> + >> + panel@0 { >> + compatible = "dlc,dlc0697", "ilitek,ili7807s"; >> + reg = <0>; >> + >> + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; >> + >> + vddi-supply = <&pm4125_l15>; >> + avdd-supply = <&vreg_disp_p>; >> + avee-supply = <&vreg_disp_n>; >> + >> + pinctrl-0 = <&panel_rst_n &panel_te_pin &panel_bl_en>; > > As far as I remember, your panel_bl_en enables an external regulator. > Why is it not described in this way? > panel_bl_en is a Qcom's daughter card specific platform signal , it does not feed into the panel. It is a board-level GPIO on the CQM EVK daughter card used purely for platform power sequencing. Adding panel_bl_en as an external regulator would be misleading and incorrect from a hardware perspective, as it is not directly going into the panel. for the CQM EVK, the backlight is MIPI DCS driven and panel_bl_en is a platform-specific sequencing pin, making pinctrl states the appropriate binding here. Could you please take a look at earlier discussion we had and let us know your thoughts ? https://lore.kernel.org/all/29ca6303-4368-4aeb-b82f-039aa252780a@oss.qualcomm.com/ Thanks, Arpit ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 3/4] arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel 2026-09-23 10:46 ` Arpit Saini @ 2026-09-23 12:08 ` Dmitry Baryshkov 0 siblings, 0 replies; 11+ messages in thread From: Dmitry Baryshkov @ 2026-09-23 12:08 UTC (permalink / raw) To: Arpit Saini Cc: Nabige Aala, Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa, linux-arm-msm, devicetree, linux-kernel On Wed, Sep 23, 2026 at 04:16:21PM +0530, Arpit Saini wrote: > Hi Dmitry, > > On 9/22/2026 9:33 PM, Dmitry Baryshkov wrote: > > On Wed, Sep 16, 2026 at 02:41:20PM +0530, Nabige Aala wrote: > >> From: Arpit Saini <arpit.saini@oss.qualcomm.com> > >> > >> Enable the Shikra MDSS display subsystem on the Qualcomm > >> Shikra CQM EVK board and add the DLC0697 MIPI DSI display > >> panel node. Pin pm4125_l5 to 1.232V with regulator-allow-set-load > >> for DSI PHY PLL stability. > >> > >> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com> > >> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> > >> --- > >> arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts | 118 ++++++++++++++++++++++++++++ > >> 1 file changed, 118 insertions(+) > >> > >> + > >> +&mdss_dsi0 { > >> + vdda-supply = <&pm4125_l5>; > >> + > >> + status = "okay"; > >> + > >> + panel@0 { > >> + compatible = "dlc,dlc0697", "ilitek,ili7807s"; > >> + reg = <0>; > >> + > >> + reset-gpios = <&tlmm 3 GPIO_ACTIVE_LOW>; > >> + > >> + vddi-supply = <&pm4125_l15>; > >> + avdd-supply = <&vreg_disp_p>; > >> + avee-supply = <&vreg_disp_n>; > >> + > >> + pinctrl-0 = <&panel_rst_n &panel_te_pin &panel_bl_en>; > > > > As far as I remember, your panel_bl_en enables an external regulator. > > Why is it not described in this way? > > > > panel_bl_en is a Qcom's daughter card specific platform signal , it does not feed into the panel. > > It is a board-level GPIO on the CQM EVK daughter card used purely for > platform power sequencing. > > Adding panel_bl_en as an external regulator would be misleading and incorrect from a hardware perspective, > as it is not directly going into the panel. Well... Aren't VREG_WLED and WLED_SIN1 / SIN2 directly going to the panel? > > for the CQM EVK, the backlight is MIPI DCS driven and panel_bl_en is a > platform-specific sequencing pin, making pinctrl states the > appropriate binding here. > > Could you please take a look at earlier discussion we had and let us know your thoughts ? > > https://lore.kernel.org/all/29ca6303-4368-4aeb-b82f-039aa252780a@oss.qualcomm.com/ Exactly. The diagram there shows that GPIO 91 (panel_bl_en) is an enable signal for the WLED regulator, whose output is then fed to the panel. -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v4 4/4] arm64: defconfig: Enable ILI7807S DSI panel driver 2026-09-16 9:11 [PATCH v4 0/4] arm64: qcom: dts: Add display support for Qualcomm Shikra Nabige Aala ` (2 preceding siblings ...) 2026-09-16 9:11 ` [PATCH v4 3/4] arm64: dts: qcom: shikra-cqm-evk: " Nabige Aala @ 2026-09-16 9:11 ` Nabige Aala 2026-09-22 16:03 ` Dmitry Baryshkov 3 siblings, 1 reply; 11+ messages in thread From: Nabige Aala @ 2026-09-16 9:11 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: Arpit Saini, Nabige Aala, linux-arm-msm, devicetree, linux-kernel From: Arpit Saini <arpit.saini@oss.qualcomm.com> Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module, used on the Shikra CQM EVK board and CQS EVK board. Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 5217de386edc..00dc52c8d87d 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -1021,6 +1021,7 @@ CONFIG_DRM_PANEL_LVDS=m CONFIG_DRM_PANEL_HIMAX_HX8279=m CONFIG_DRM_PANEL_HIMAX_HX83112A=m CONFIG_DRM_PANEL_HIMAX_HX83112B=m +CONFIG_DRM_PANEL_ILITEK_ILI7807S=m CONFIG_DRM_PANEL_ILITEK_ILI9806E_SPI=m CONFIG_DRM_PANEL_ILITEK_ILI9882T=m CONFIG_DRM_PANEL_KHADAS_TS050=m -- 2.34.1 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v4 4/4] arm64: defconfig: Enable ILI7807S DSI panel driver 2026-09-16 9:11 ` [PATCH v4 4/4] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala @ 2026-09-22 16:03 ` Dmitry Baryshkov 0 siblings, 0 replies; 11+ messages in thread From: Dmitry Baryshkov @ 2026-09-22 16:03 UTC (permalink / raw) To: Nabige Aala Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa, Arpit Saini, linux-arm-msm, devicetree, linux-kernel On Wed, Sep 16, 2026 at 02:41:21PM +0530, Nabige Aala wrote: > From: Arpit Saini <arpit.saini@oss.qualcomm.com> > > Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module, > used on the Shikra CQM EVK board and CQS EVK board. > > Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com> > Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2026-09-23 12:08 UTC | newest] Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-09-16 9:11 [PATCH v4 0/4] arm64: qcom: dts: Add display support for Qualcomm Shikra Nabige Aala 2026-09-16 9:11 ` [PATCH v4 1/4] arm64: dts: qcom: shikra: Add MDSS display subsystem Nabige Aala 2026-09-22 16:05 ` Dmitry Baryshkov 2026-09-16 9:11 ` [PATCH v4 2/4] arm64: dts: qcom: shikra-cqs-evk: Enable display and add ili7807s panel Nabige Aala 2026-09-22 16:04 ` Dmitry Baryshkov 2026-09-16 9:11 ` [PATCH v4 3/4] arm64: dts: qcom: shikra-cqm-evk: " Nabige Aala 2026-09-22 16:03 ` Dmitry Baryshkov 2026-09-23 10:46 ` Arpit Saini 2026-09-23 12:08 ` Dmitry Baryshkov 2026-09-16 9:11 ` [PATCH v4 4/4] arm64: defconfig: Enable ILI7807S DSI panel driver Nabige Aala 2026-09-22 16:03 ` Dmitry Baryshkov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®