From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Noam Camus <noamca@mellanox.com>, <linux-snps-arc@lists.infradead.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 02/12] ARC: set level of log per CPU during boot to be debug level
Date: Wed, 14 Jun 2017 15:45:57 -0700 [thread overview]
Message-ID: <7f6432b3-a5ea-13ee-e207-1edd0115434a@synopsys.com> (raw)
In-Reply-To: <1497362636-30353-3-git-send-email-noamca@mellanox.com>
On 06/13/2017 07:03 AM, Noam Camus wrote:
> From: Noam Camus <noamca@mellanox.com>
>
> The reasons are:
> 1) speeding up boot time, becomes critical for many CPUs machine,
> e.g. NPS400 with 4K CPUs
> 2) shorten kernel log at boot time, again easy to scan for large
> scale machines such NPS400
>
> Signed-off-by: Noam Camus <noamca@mellanox.com>
> ---
> arch/arc/kernel/setup.c | 6 +++---
> arch/arc/kernel/smp.c | 4 ++--
> arch/arc/mm/cache.c | 2 +-
> arch/arc/mm/tlb.c | 2 +-
> 4 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arc/kernel/setup.c b/arch/arc/kernel/setup.c
> index fc8211f..8494b31 100644
> --- a/arch/arc/kernel/setup.c
> +++ b/arch/arc/kernel/setup.c
> @@ -385,13 +385,13 @@ void setup_processor(void)
> read_arc_build_cfg_regs();
> arc_init_IRQ();
>
> - printk(arc_cpu_mumbojumbo(cpu_id, str, sizeof(str)));
> + pr_debug("%s", arc_cpu_mumbojumbo(cpu_id, str, sizeof(str)));
I understand you issue, but as Alexey mentioned before we can't switch the normal
kernel boot log to debug only.
At best you can convert the current printk to pr_info and then set the log level
in your cmdline to something higher than info !
>
> arc_mmu_init();
> arc_cache_init();
>
> - printk(arc_extn_mumbojumbo(cpu_id, str, sizeof(str)));
> - printk(arc_platform_smp_cpuinfo());
> + pr_debug("%s", arc_extn_mumbojumbo(cpu_id, str, sizeof(str)));
> + pr_debug("%s", arc_platform_smp_cpuinfo());
>
> arc_chk_core_config();
> }
> diff --git a/arch/arc/kernel/smp.c b/arch/arc/kernel/smp.c
> index f462671..d1aa917 100644
> --- a/arch/arc/kernel/smp.c
> +++ b/arch/arc/kernel/smp.c
> @@ -177,8 +177,8 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle)
>
> secondary_idle_tsk = idle;
>
> - pr_info("Idle Task [%d] %p", cpu, idle);
> - pr_info("Trying to bring up CPU%u ...\n", cpu);
> + pr_debug("Idle Task [%d] %p", cpu, idle);
> + pr_debug("Trying to bring up CPU%u ...\n", cpu);
>
> if (plat_smp_ops.cpu_kick)
> plat_smp_ops.cpu_kick(cpu,
> diff --git a/arch/arc/mm/cache.c b/arch/arc/mm/cache.c
> index a867575..7d3e79b 100644
> --- a/arch/arc/mm/cache.c
> +++ b/arch/arc/mm/cache.c
> @@ -1188,7 +1188,7 @@ void __ref arc_cache_init(void)
> unsigned int __maybe_unused cpu = smp_processor_id();
> char str[256];
>
> - printk(arc_cache_mumbojumbo(0, str, sizeof(str)));
> + pr_debug("%s", arc_cache_mumbojumbo(0, str, sizeof(str)));
>
> /*
> * Only master CPU needs to execute rest of function:
> diff --git a/arch/arc/mm/tlb.c b/arch/arc/mm/tlb.c
> index d0126fd..c5e70d8 100644
> --- a/arch/arc/mm/tlb.c
> +++ b/arch/arc/mm/tlb.c
> @@ -814,7 +814,7 @@ void arc_mmu_init(void)
> char str[256];
> struct cpuinfo_arc_mmu *mmu = &cpuinfo_arc700[smp_processor_id()].mmu;
>
> - printk(arc_mmu_mumbojumbo(0, str, sizeof(str)));
> + pr_debug("%s", arc_mmu_mumbojumbo(0, str, sizeof(str)));
>
> /*
> * Can't be done in processor.h due to header include depenedencies
>
next prev parent reply other threads:[~2017-06-14 22:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-13 14:03 [PATCH v2 00/12] plat-eznps upstream cont. set 2 Noam Camus
2017-06-13 14:03 ` [PATCH v2 01/12] ARC: [plat-eznps] Handle memory error as an exception Noam Camus
2017-06-14 22:39 ` Vineet Gupta
2017-06-13 14:03 ` [PATCH v2 02/12] ARC: set level of log per CPU during boot to be debug level Noam Camus
2017-06-14 22:45 ` Vineet Gupta [this message]
2017-06-13 14:03 ` [PATCH v2 03/12] ARC: send ipi to all cpus sharing task mm in case of page fault Noam Camus
2017-06-13 14:03 ` [PATCH v2 04/12] ARC: Allow irq threading Noam Camus
2017-06-13 14:03 ` [PATCH v2 05/12] ARC: Add CPU topology Noam Camus
2017-06-13 14:03 ` [PATCH v2 06/12] ARC: Support more than one PGDIR for KVADDR Noam Camus
2017-06-13 14:03 ` [PATCH v2 07/12] ARC: [NUMA] added CONFIG_NUMA for plat-eznps Noam Camus
2017-06-13 14:03 ` [PATCH v2 08/12] ARC: [plat-eznps] new command line argument for HW scheduler at MTM Noam Camus
2017-06-14 22:49 ` Vineet Gupta
2017-06-13 14:03 ` [PATCH v2 09/12] ARC: [plat-eznps] Update the init sequence of aux regs per cpu Noam Camus
2017-06-13 14:03 ` [PATCH v2 10/12] ARC: [plat-eznps] Save/Restore extra auxiliary registers Noam Camus
2017-06-13 14:03 ` [PATCH v2 11/12] ARC: [plat-eznps] handle dedicated AUX registers Noam Camus
2017-06-13 14:03 ` [PATCH v2 12/12] ARC: [plat-eznps] avoid toggling of DPC register Noam Camus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f6432b3-a5ea-13ee-e207-1edd0115434a@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=noamca@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®