From: Jijie Shao <shaojijie@huawei.com>
To: Wojciech Drewek <wojciech.drewek@intel.com>,
<yisen.zhuang@huawei.com>, <salil.mehta@huawei.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>
Cc: <shaojijie@huawei.com>, <shenjian15@huawei.com>,
<wangjie125@huawei.com>, <liuyonglong@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 net 2/2] net: hns: fix fake link up on xge port
Date: Mon, 4 Dec 2023 22:43:44 +0800 [thread overview]
Message-ID: <7f9fffe3-2fb8-41a2-9eb0-4adf91566a21@huawei.com> (raw)
In-Reply-To: <c382dc51-3a3c-4c79-90c0-13e2e716d0a9@intel.com>
on 2023/12/4 18:19, Wojciech Drewek wrote:
>
> On 04.12.2023 02:10, Jijie Shao wrote:
>>
>> +static void hns_mac_link_anti_shake(struct mac_driver *mac_ctrl_drv,
>> + u32 *link_status)
>> +{
> It would be cleaner to return the link status than using output arg IMO
>
Yes, it's a good suggestion, and this is modified in v3
prev parent reply other threads:[~2023-12-04 14:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 1:10 [PATCH V2 net 0/2] There are some bugfix for the HNS ethernet driver Jijie Shao
2023-12-04 1:10 ` [PATCH V2 net 1/2] net: hns: fix wrong head when modify the tx feature when sending packets Jijie Shao
2023-12-04 10:15 ` Wojciech Drewek
2023-12-04 14:41 ` Jijie Shao
2023-12-04 1:10 ` [PATCH V2 net 2/2] net: hns: fix fake link up on xge port Jijie Shao
2023-12-04 10:19 ` Wojciech Drewek
2023-12-04 14:43 ` Jijie Shao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f9fffe3-2fb8-41a2-9eb0-4adf91566a21@huawei.com \
--to=shaojijie@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shenjian15@huawei.com \
--cc=wangjie125@huawei.com \
--cc=wojciech.drewek@intel.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®