mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Hilal Rahmatullah <hilalrahmatullah11@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
	Donald Hunter <donald.hunter@gmail.com>,
	"open list:NETWORKING [GENERAL]" <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v3] wifi: nl80211: document sta-info nested attribute
Date: Fri, 02 Oct 2026 19:34:19 +0200	[thread overview]
Message-ID: <7fc3e2730ebea674abf750a39c53d6ee307a907e.camel@sipsolutions.net> (raw)
In-Reply-To: <6ae7fd5e4d24bdeb0f0df057f767107e08567640.camel@sipsolutions.net>

On Sat, 2026-09-05 at 09:46 +0200, Johannes Berg wrote:
> On Mon, 2026-08-17 at 08:47 -0700, Jakub Kicinski wrote:
> > > 
> > > ---
> > >  Documentation/netlink/specs/nl80211.yaml | 351 ++++++++++++++++++++++-
> > 
> > Hi Johannes! Should we add this file to wireless in MAINTAINERS?
> > Or do you prefer for us to handle the YAML stuff directly?
> 
> Not sure, we don't really seem to be using it for all I know, and so
> it's just been getting some random updates like this, I guess.
> 
> I think I tend to prefer the status quo, but I guess I could also just
> apply patches to it if you prefer.

So that's what I said a month ago, but because Jouni prodded me about
our inconsistent documentation today, I actually looked at converting
*all* of nl80211.h and our hand-rolled policies to be generated.

It ... takes some work, and ends up being 12k (!) lines of yaml, vs.
today's 7.2k of nl80211.h and ~1k policy in nl80211.c.

It also requires a bunch of changes to the tooling:

 - kdoc comments for attribute-set enums
 - exact-len-warn check
 - validate-fn check support and creating their prototypes
 - combining min-len/max-len for binary attributes
 - strict-start-type support
 - flag to generate the whole attrs without linking them from ops
   (otherwise we get even many many more lines of yaml)
 - NLA_NESTED/indexed arrays support
 - allow nesting the global policy into itself (yeah ... I want some of
   what we were smoking ;-) )
 - allowing inheriting different members for kernel policy side
 - drop nesting when subset overrides type ... not even sure how to
   explain this right now
 - option to define only policy, not ops
 - allow taking ops IDs from an enum, because our ops don't match the
   ynl ops too well
 - enum-max-name for definitions to adjust naming

There's a license issue - we have ISC license on nl80211.h now, but
Donald and Hilal picked GPL/syscall/BSD-3 for the yaml and of course
that carries over to the generated .h file, not sure if that's an issue
for downstream projects but might be with advertising clause? Could we
change it if I'm adding >10k new lines from nl80211.h? :)

I can post it but ... is it worth it? Not even sure it would
significantly simplify our lives, although the generated header file
with documentation is much more regular in that it always has the type,
etc. (which is what Jouni was asking about)

johannes

  reply	other threads:[~2026-10-02 17:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-16 10:12 Hilal Rahmatullah
2026-08-17 15:47 ` Jakub Kicinski
2026-09-05  7:46   ` Johannes Berg
2026-10-02 17:34     ` Johannes Berg [this message]
2026-10-02 20:25       ` Jakub Kicinski
2026-10-02 20:30         ` Johannes Berg
2026-08-18 17:07 ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7fc3e2730ebea674abf750a39c53d6ee307a907e.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=donald.hunter@gmail.com \
    --cc=edumazet@google.com \
    --cc=hilalrahmatullah11@gmail.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®