From: junkio@cox.net
To: David Dillow <dave@thedillows.org>
Cc: linux-kernel@vger.kernel.org,
Phillip Lougher <phillip@lougher.demon.co.uk>
Subject: Re: [PATCH] Port SquashFS to 2.6
Date: Sat, 19 Jul 2003 22:40:22 -0700 [thread overview]
Message-ID: <7vu19hrc1l.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <1058657738.4233.4.camel@ori.thedillows.org> (David Dillow's message of "19 Jul 2003 19:35:38 -0400")
>>>>> "DD" == David Dillow <dave@thedillows.org> writes:
DD> On Sat, 2003-07-19 at 18:59, junkio@cox.net wrote:
>> ...
>> + while(length < index) {
>> + char buffer[PAGE_CACHE_SIZE];
DD> Hmm, isn't that 4K allocated on the stack? Ouch.
Ouch indeed. I was not looking for these things (I was just
porting not fixing). Thank you for pointing it out. Have a
couple of questions:
- Would it be an acceptable alternative here to use blocking
kmalloc upon entry with matching kfree before leaving?
- I would imagine that the acceptable stack usage for functions
would depend on where they are called and what they call.
Coulc you suggest a rule-of-thumb number for
address_space_operations.readpage (say, would 1kB be OK but
not 3kB?)
- Would the same rule apply to 2.4 filesystem layer?
next prev parent reply other threads:[~2003-07-20 5:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-19 22:59 junkio
2003-07-19 23:35 ` David Dillow
2003-07-20 5:40 ` junkio [this message]
2003-07-20 8:22 ` Jörn Engel
2003-07-20 10:16 ` postmaster
2003-07-20 10:38 ` Jörn Engel
2003-07-20 1:50 ` Bernd Eckenfels
[not found] <fa.k0do8p6.ch6pps@ifi.uio.no>
[not found] ` <fa.hre90bn.e6k5pf@ifi.uio.no>
2003-07-22 2:52 ` junkio
2003-07-22 3:42 ` Valdis.Kletnieks
2003-07-22 10:20 ` Jörn Engel
2003-07-22 10:16 ` Jörn Engel
2003-07-22 10:36 John Bradford
2003-07-22 10:47 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vu19hrc1l.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=dave@thedillows.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@lougher.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®