From: postmaster@lougher.demon.co.uk
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: linux-kernel@vger.kernel.org, junkio@cox.net
Subject: Re: [PATCH] Port SquashFS to 2.6
Date: Sun, 20 Jul 2003 11:16:18 +0100 [thread overview]
Message-ID: <E19eBEo-0007h6-0Z@anchor-post-35.mail.demon.net> (raw)
In-Reply-To: <20030720082217.GA25468@wohnheim.fh-wedel.de>
joern@wohnheim.fh-wedel.de wrote:
> On Sat, 19 July 2003 22:40:22 -0700, junkio@cox.net wrote:
> > >>>>> "DD" == David Dillow <dave@thedillows.org> writes:
> >
> > DD> Hmm, isn't that 4K allocated on the stack? Ouch.
> >
> > Ouch indeed. I was not looking for these things (I was just
> > porting not fixing). Thank you for pointing it out. Have a
> > couple of questions:
> >
Thanks for sending the 2.6 patch, due to work pressure, I have had very little
time to do these things recently. I am still, however, actively developing
squashfs (a 1.3 with some improvements will be released soon), and I'd prefer
to do code fixes myself.
> > - Would it be an acceptable alternative here to use blocking
> > kmalloc upon entry with matching kfree before leaving?
> >
> > - I would imagine that the acceptable stack usage for functions
> > would depend on where they are called and what they call.
> > Coulc you suggest a rule-of-thumb number for
> > address_space_operations.readpage (say, would 1kB be OK but
> > not 3kB?)
>
> As a rule of thumb, stay below 1k or you will get regular email from
> me. :)
I tend to allocate (small) buffers on the stack, when their size does not
seem to warrant either: a globally kmalloced buffer and consequent locking,
or a locally kmalloced buffer kfreed on exit from the function, which seems
wasteful. However, if 1K is the perceived wisdom on stack limits, then I will
alter the code.
Phillip
next prev parent reply other threads:[~2003-07-20 10:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-19 22:59 junkio
2003-07-19 23:35 ` David Dillow
2003-07-20 5:40 ` junkio
2003-07-20 8:22 ` Jörn Engel
2003-07-20 10:16 ` postmaster [this message]
2003-07-20 10:38 ` Jörn Engel
2003-07-20 1:50 ` Bernd Eckenfels
[not found] <fa.k0do8p6.ch6pps@ifi.uio.no>
[not found] ` <fa.hre90bn.e6k5pf@ifi.uio.no>
2003-07-22 2:52 ` junkio
2003-07-22 3:42 ` Valdis.Kletnieks
2003-07-22 10:20 ` Jörn Engel
2003-07-22 10:16 ` Jörn Engel
2003-07-22 10:36 John Bradford
2003-07-22 10:47 ` Jörn Engel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E19eBEo-0007h6-0Z@anchor-post-35.mail.demon.net \
--to=postmaster@lougher.demon.co.uk \
--cc=joern@wohnheim.fh-wedel.de \
--cc=junkio@cox.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®