* [PATCH] powerpc: Do not ignore arch/powerpc/include [not found] ` <7vk5etjozt.fsf@gitster.siamese.dyndns.org> @ 2008-08-08 1:45 ` Junio C Hamano 2008-08-08 3:13 ` Stephen Rothwell 0 siblings, 1 reply; 2+ messages in thread From: Junio C Hamano @ 2008-08-08 1:45 UTC (permalink / raw) To: Paul Mackerras Cc: linux-kernel, Stephen Rothwell, Linus Torvalds, Petr Baudis, Shawn O. Pearce, Johannes Schindelin Back when .gitignore file was added to arch/powerpc/ in 06f2138 ([POWERPC] Add files build to .gitignore, 2006-11-26), there indeed was nothing tracked in the ignored hierarchy and ignoring everything made sense. But we have very many tracked files there these days, and having a higher level .gitignore that ignores everything is asking for future troubles.. This should have been part of b8b572e (powerpc: Move include files to arch/powerpc/include/asm, 2008-08-01). Signed-off-by: Junio C Hamano <gitster@pobox.com> --- Junio C Hamano <gitster@pobox.com> writes: > By the way, if anybody wants to reproduce this, be careful with the > tests that run "rm -f .git/index" before adding everything with > "git add ." from the toplevel directory. After doing so, if you check > the result with "git diff --stat HEAD", you will notice many missing files; > I almost got a heart attack before inspecting this file: > > $ cat arch/powerpc/.gitignore > include > > Yes, it excludes 261 already tracked files. Is it intended? I dunno. I looked at this a bit more and now I know this was not intended. arch/powerpc/.gitignore | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/arch/powerpc/.gitignore b/arch/powerpc/.gitignore deleted file mode 100644 index a1a869c..0000000 --- a/arch/powerpc/.gitignore +++ /dev/null @@ -1 +0,0 @@ -include ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] powerpc: Do not ignore arch/powerpc/include 2008-08-08 1:45 ` [PATCH] powerpc: Do not ignore arch/powerpc/include Junio C Hamano @ 2008-08-08 3:13 ` Stephen Rothwell 0 siblings, 0 replies; 2+ messages in thread From: Stephen Rothwell @ 2008-08-08 3:13 UTC (permalink / raw) To: Junio C Hamano Cc: Paul Mackerras, linux-kernel, Linus Torvalds, Petr Baudis, Shawn O. Pearce, Johannes Schindelin [-- Attachment #1: Type: text/plain, Size: 967 bytes --] Hi Junio, On Thu, 07 Aug 2008 18:45:08 -0700 Junio C Hamano <gitster@pobox.com> wrote: > > Back when .gitignore file was added to arch/powerpc/ in 06f2138 ([POWERPC] > Add files build to .gitignore, 2006-11-26), there indeed was nothing > tracked in the ignored hierarchy and ignoring everything made sense. But > we have very many tracked files there these days, and having a higher > level .gitignore that ignores everything is asking for future troubles.. We used to create a symlink called "include" in arch/powerpc (during the build) as part of sharing our include files with arch/ppc. > This should have been part of b8b572e (powerpc: Move include files to > arch/powerpc/include/asm, 2008-08-01). Yeah, sorry about that. > Signed-off-by: Junio C Hamano <gitster@pobox.com> Acked-by: Stephen Rothwell <sfr@canb.auug.org.au> -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/ [-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --] ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-08-08 3:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20080721002354.GK10151@machine.or.cz>
[not found] ` <20080721002508.26773.92277.stgit@localhost>
[not found] ` <7v8wvpm9cl.fsf@gitster.siamese.dyndns.org>
[not found] ` <7vej5543v5.fsf_-_@gitster.siamese.dyndns.org>
[not found] ` <alpine.LFD.1.10.0808041719380.3299@nehalem.linux-foundation.org>
[not found] ` <7vk5etjozt.fsf@gitster.siamese.dyndns.org>
2008-08-08 1:45 ` [PATCH] powerpc: Do not ignore arch/powerpc/include Junio C Hamano
2008-08-08 3:13 ` Stephen Rothwell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®