[PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated reset-gpios

[PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated reset-gpios

[Krzysztof Kozlowski]

GPIOs with "gpio" suffix were long time ago deprecated, thus
"reset-gpios" should be used.  Linux kernel supports both, referenced
schema snps,dw-pcie-common.yaml lists both as well and this schema uses
unevaluatedProperties:false, thus change has no impact except code
readability and removing deprecated patterns.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
---
 Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
index 12a01f7a5744..b9ba938c6239 100644
--- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
@@ -58,11 +58,6 @@ properties:
       - const: msi
       - const: dma
 
-  reset-gpio:
-    description: Should specify the GPIO for controlling the PCI bus device
-      reset signal. It's not polarity aware and defaults to active-low reset
-      sequence (L=reset state, H=operation state) (optional required).
-
   reset-gpio-active-high:
     description: If present then the reset sequence using the GPIO
       specified in the "reset-gpio" property is reversed (H=reset state,
-- 
2.51.0

[PATCH 2/2] dt-bindings: PCI: snps,dw-pcie: Drop deprecated reset-gpio

[Krzysztof Kozlowski]

GPIOs with "gpio" suffix were long time ago deprecated in favor of
"gpios" and this particular property was documented explicitly as
deprecated since commit 42694f9f6407 ("dt-bindings: PCI: add
snps,dw-pcie.yaml") in 2021.

Linux kernel supports both variants for a long time, thus listing the
deprecated one is redundant and instead legacy DTS should be updated.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

---

I will fix DTS separately, so after applying this patch there will be
bunch of dtbs_check warnings. That's expected and fine.
---
 .../devicetree/bindings/pci/snps,dw-pcie-common.yaml       | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
index 2c4dc04f9984..deba46d7a924 100644
--- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
+++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
@@ -209,13 +209,6 @@ properties:
             - pattern: '^p2u-[0-7]$'
             - pattern: '^cp[01]-pcie[0-2]-x[124](-lane[0-3])?-phy$'  # marvell,armada8k-pcie
 
-  reset-gpio:
-    deprecated: true
-    description:
-      Reference to the GPIO-controlled PERST# signal. It is used to reset all
-      the peripheral devices available on the PCIe bus.
-    maxItems: 1
-
   reset-gpios:
     description:
       Reference to the GPIO-controlled PERST# signal. It is used to reset all
-- 
2.51.0

RE: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated reset-gpios

[Hongxing Zhu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2536 bytes --]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Sent: 2026Äê3ÔÂ11ÈÕ 23:50
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; Lucas Stach
> <l.stach@pengutronix.de>; Lorenzo Pieralisi <lpieralisi@kernel.org>; Krzysztof
> Wilczy¨½ski <kwilczynski@kernel.org>; Manivannan Sadhasivam
> <mani@kernel.org>; Rob Herring <robh@kernel.org>; Bjorn Helgaas
> <bhelgaas@google.com>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor
> Dooley <conor+dt@kernel.org>; Frank Li <frank.li@nxp.com>; Sascha Hauer
> <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Jingoo Han
> <jingoohan1@gmail.com>; Gustavo Pimentel
> <gustavo.pimentel@synopsys.com>; linux-pci@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Subject: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated
> reset-gpios
> 
> GPIOs with "gpio" suffix were long time ago deprecated, thus "reset-gpios"
> should be used.  Linux kernel supports both, referenced schema
> snps,dw-pcie-common.yaml lists both as well and this schema uses
> unevaluatedProperties:false, thus change has no impact except code
> readability and removing deprecated patterns.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks.

Best Regards
Richard Zhu

> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 12a01f7a5744..b9ba938c6239 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -58,11 +58,6 @@ properties:
>        - const: msi
>        - const: dma
> 
> -  reset-gpio:
> -    description: Should specify the GPIO for controlling the PCI bus device
> -      reset signal. It's not polarity aware and defaults to active-low reset
> -      sequence (L=reset state, H=operation state) (optional required).
> -
>    reset-gpio-active-high:
>      description: If present then the reset sequence using the GPIO
>        specified in the "reset-gpio" property is reversed (H=reset state,
> --
> 2.51.0

RE: [PATCH 2/2] dt-bindings: PCI: snps,dw-pcie: Drop deprecated reset-gpio

[Hongxing Zhu]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="gb2312", Size: 2767 bytes --]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Sent: 2026Äê3ÔÂ11ÈÕ 23:50
> To: Hongxing Zhu <hongxing.zhu@nxp.com>; Lucas Stach
> <l.stach@pengutronix.de>; Lorenzo Pieralisi <lpieralisi@kernel.org>;
> Krzysztof Wilczy¨½ski <kwilczynski@kernel.org>; Manivannan Sadhasivam
> <mani@kernel.org>; Rob Herring <robh@kernel.org>; Bjorn Helgaas
> <bhelgaas@google.com>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor
> Dooley <conor+dt@kernel.org>; Frank Li <frank.li@nxp.com>; Sascha Hauer
> <s.hauer@pengutronix.de>; Pengutronix Kernel Team
> <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Jingoo
> Han <jingoohan1@gmail.com>; Gustavo Pimentel
> <gustavo.pimentel@synopsys.com>; linux-pci@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org; imx@lists.linux.dev;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> Subject: [PATCH 2/2] dt-bindings: PCI: snps,dw-pcie: Drop deprecated
> reset-gpio
> 
> GPIOs with "gpio" suffix were long time ago deprecated in favor of "gpios"
> and this particular property was documented explicitly as deprecated since
> commit 42694f9f6407 ("dt-bindings: PCI: add
> snps,dw-pcie.yaml") in 2021.
> 
> Linux kernel supports both variants for a long time, thus listing the
> deprecated one is redundant and instead legacy DTS should be updated.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: Richard Zhu <hongxing.zhu@nxp.com>
Thanks.

Best Regards
Richard Zhu
> 
> ---
> 
> I will fix DTS separately, so after applying this patch there will be bunch of
> dtbs_check warnings. That's expected and fine.
> ---
>  .../devicetree/bindings/pci/snps,dw-pcie-common.yaml       | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git
> a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
> b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
> index 2c4dc04f9984..deba46d7a924 100644
> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie-common.yaml
> @@ -209,13 +209,6 @@ properties:
>              - pattern: '^p2u-[0-7]$'
>              - pattern: '^cp[01]-pcie[0-2]-x[124](-lane[0-3])?-phy$'  #
> marvell,armada8k-pcie
> 
> -  reset-gpio:
> -    deprecated: true
> -    description:
> -      Reference to the GPIO-controlled PERST# signal. It is used to reset all
> -      the peripheral devices available on the PCIe bus.
> -    maxItems: 1
> -
>    reset-gpios:
>      description:
>        Reference to the GPIO-controlled PERST# signal. It is used to reset
> all
> --
> 2.51.0

RE: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated reset-gpios

[Sherry Sun]

> Subject: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated
> reset-gpios
> 
> GPIOs with "gpio" suffix were long time ago deprecated, thus "reset-gpios" should
> be used.  Linux kernel supports both, referenced schema snps,dw-pcie-
> common.yaml lists both as well and this schema uses
> unevaluatedProperties:false, thus change has no impact except code readability
> and removing deprecated patterns.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
> ---
>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index 12a01f7a5744..b9ba938c6239 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -58,11 +58,6 @@ properties:
>        - const: msi
>        - const: dma
> 
> -  reset-gpio:
> -    description: Should specify the GPIO for controlling the PCI bus device
> -      reset signal. It's not polarity aware and defaults to active-low reset
> -      sequence (L=reset state, H=operation state) (optional required).
> -

Add Dmitry and Bartosz.

Hi Krzysztof,
Seems this property is still handled in gpiolib-of.c, see commit b8b80348c57b
("gpiolib: of: add polarity quirk for Freescale PCIe controller").
Maybe need to change the quirk gpio_propname here too.


>    reset-gpio-active-high:
>      description: If present then the reset sequence using the GPIO
>        specified in the "reset-gpio" property is reversed (H=reset state,

 Also change the "reset-gpio" to "reset-gpios" in this description.

Best Regards
Sherry
> --
> 2.51.0
> 

Re: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated reset-gpios

[Krzysztof Kozlowski]

On 12/03/2026 10:18, Sherry Sun wrote:
>> Subject: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated
>> reset-gpios
>>
>> GPIOs with "gpio" suffix were long time ago deprecated, thus "reset-gpios" should
>> be used.  Linux kernel supports both, referenced schema snps,dw-pcie-
>> common.yaml lists both as well and this schema uses
>> unevaluatedProperties:false, thus change has no impact except code readability
>> and removing deprecated patterns.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>> ---
>>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 5 -----
>>  1 file changed, 5 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>> index 12a01f7a5744..b9ba938c6239 100644
>> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>> @@ -58,11 +58,6 @@ properties:
>>        - const: msi
>>        - const: dma
>>
>> -  reset-gpio:
>> -    description: Should specify the GPIO for controlling the PCI bus device
>> -      reset signal. It's not polarity aware and defaults to active-low reset
>> -      sequence (L=reset state, H=operation state) (optional required).
>> -
> 
> Add Dmitry and Bartosz.
> 
> Hi Krzysztof,
> Seems this property is still handled in gpiolib-of.c, see commit b8b80348c57b
> ("gpiolib: of: add polarity quirk for Freescale PCIe controller").
> Maybe need to change the quirk gpio_propname here too.

Oh, I missed that completely. Thanks for mentioning it.

1. Having this property in drivers/gpio/gpiolib-of.c means we should
keep it in the schema as deprecated, because each ABI should be documented.

2. I can drop reset-gpio-active-high from DTS as well, because
reset-gpios have proper flag.

3. We don't need to update gpiolib-of.c, because standard flag from
reset-gpios will be used.

> 
> 
>>    reset-gpio-active-high:
>>      description: If present then the reset sequence using the GPIO
>>        specified in the "reset-gpio" property is reversed (H=reset state,
> 
>  Also change the "reset-gpio" to "reset-gpios" in this description.
> 

Also here - no need to update, because this will be used only for
reset-gpio.


Best regards,
Krzysztof

Re: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated reset-gpios

[Krzysztof Kozlowski]

On 12/03/2026 17:29, Krzysztof Kozlowski wrote:
> On 12/03/2026 10:18, Sherry Sun wrote:
>>> Subject: [PATCH 1/2] dt-bindings: PCI: fsl,imx6q-pcie: Switch to undeprecated
>>> reset-gpios
>>>
>>> GPIOs with "gpio" suffix were long time ago deprecated, thus "reset-gpios" should
>>> be used.  Linux kernel supports both, referenced schema snps,dw-pcie-
>>> common.yaml lists both as well and this schema uses
>>> unevaluatedProperties:false, thus change has no impact except code readability
>>> and removing deprecated patterns.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
>>> ---
>>>  Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml | 5 -----
>>>  1 file changed, 5 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>>> b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>>> index 12a01f7a5744..b9ba938c6239 100644
>>> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>>> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
>>> @@ -58,11 +58,6 @@ properties:
>>>        - const: msi
>>>        - const: dma
>>>
>>> -  reset-gpio:
>>> -    description: Should specify the GPIO for controlling the PCI bus device
>>> -      reset signal. It's not polarity aware and defaults to active-low reset
>>> -      sequence (L=reset state, H=operation state) (optional required).
>>> -
>>
>> Add Dmitry and Bartosz.
>>
>> Hi Krzysztof,
>> Seems this property is still handled in gpiolib-of.c, see commit b8b80348c57b
>> ("gpiolib: of: add polarity quirk for Freescale PCIe controller").
>> Maybe need to change the quirk gpio_propname here too.
> 
> Oh, I missed that completely. Thanks for mentioning it.
> 
> 1. Having this property in drivers/gpio/gpiolib-of.c means we should
> keep it in the schema as deprecated, because each ABI should be documented.
> 
> 2. I can drop reset-gpio-active-high from DTS as well, because
> reset-gpios have proper flag.
> 
> 3. We don't need to update gpiolib-of.c, because standard flag from
> reset-gpios will be used.
> 
>>
>>
>>>    reset-gpio-active-high:
>>>      description: If present then the reset sequence using the GPIO
>>>        specified in the "reset-gpio" property is reversed (H=reset state,
>>
>>  Also change the "reset-gpio" to "reset-gpios" in this description.
>>
> 
> Also here - no need to update, because this will be used only for
> reset-gpio.

I will send a v2.

Best regards,
Krzysztof