From: Andrew Davis <afd@ti.com>
To: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>,
Sebastian Reichel <sre@kernel.org>,
Laxman Dewangan <ldewangan@nvidia.com>
Cc: <linux-pm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe
Date: Mon, 18 Nov 2024 08:10:32 -0600 [thread overview]
Message-ID: <801c3154-07a8-40ff-af68-b5dac8c83e9a@ti.com> (raw)
In-Reply-To: <20241117053443.1148902-1-iwamatsu@nigauri.org>
On 11/16/24 11:34 PM, Nobuhiro Iwamatsu wrote:
> The return is executed on the devm_register_sys_off_handler() line in
> as3722_poweroff_probe, so the last return line is unnecessary. Remove it.
>
> Fixes: 348fde771ce7 ("power: reset: as3722-poweroff: Use devm_register_sys_off_handler(POWER_OFF)")
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
Acked-by: Andrew Davis <afd@ti.com>
> v2: Set correct mail address for Sebastian Reichel.
>
> drivers/power/reset/as3722-poweroff.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/power/reset/as3722-poweroff.c b/drivers/power/reset/as3722-poweroff.c
> index bb26fa6fa67ca7..8075382cbc3625 100644
> --- a/drivers/power/reset/as3722-poweroff.c
> +++ b/drivers/power/reset/as3722-poweroff.c
> @@ -57,8 +57,6 @@ static int as3722_poweroff_probe(struct platform_device *pdev)
> SYS_OFF_PRIO_DEFAULT,
> as3722_pm_power_off,
> as3722_poweroff);
> -
> - return 0;
> }
>
> static struct platform_driver as3722_poweroff_driver = {
next prev parent reply other threads:[~2024-11-18 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-17 5:34 Nobuhiro Iwamatsu
2024-11-18 14:10 ` Andrew Davis [this message]
2024-12-18 23:45 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=801c3154-07a8-40ff-af68-b5dac8c83e9a@ti.com \
--to=afd@ti.com \
--cc=iwamatsu@nigauri.org \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®