* [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe
@ 2024-11-17 5:34 Nobuhiro Iwamatsu
2024-11-18 14:10 ` Andrew Davis
2024-12-18 23:45 ` Sebastian Reichel
0 siblings, 2 replies; 3+ messages in thread
From: Nobuhiro Iwamatsu @ 2024-11-17 5:34 UTC (permalink / raw)
To: Sebastian Reichel, Laxman Dewangan
Cc: linux-pm, linux-kernel, Andrew Davis, Nobuhiro Iwamatsu
The return is executed on the devm_register_sys_off_handler() line in
as3722_poweroff_probe, so the last return line is unnecessary. Remove it.
Fixes: 348fde771ce7 ("power: reset: as3722-poweroff: Use devm_register_sys_off_handler(POWER_OFF)")
Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
v2: Set correct mail address for Sebastian Reichel.
drivers/power/reset/as3722-poweroff.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/power/reset/as3722-poweroff.c b/drivers/power/reset/as3722-poweroff.c
index bb26fa6fa67ca7..8075382cbc3625 100644
--- a/drivers/power/reset/as3722-poweroff.c
+++ b/drivers/power/reset/as3722-poweroff.c
@@ -57,8 +57,6 @@ static int as3722_poweroff_probe(struct platform_device *pdev)
SYS_OFF_PRIO_DEFAULT,
as3722_pm_power_off,
as3722_poweroff);
-
- return 0;
}
static struct platform_driver as3722_poweroff_driver = {
--
2.45.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe
2024-11-17 5:34 [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe Nobuhiro Iwamatsu
@ 2024-11-18 14:10 ` Andrew Davis
2024-12-18 23:45 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Davis @ 2024-11-18 14:10 UTC (permalink / raw)
To: Nobuhiro Iwamatsu, Sebastian Reichel, Laxman Dewangan
Cc: linux-pm, linux-kernel
On 11/16/24 11:34 PM, Nobuhiro Iwamatsu wrote:
> The return is executed on the devm_register_sys_off_handler() line in
> as3722_poweroff_probe, so the last return line is unnecessary. Remove it.
>
> Fixes: 348fde771ce7 ("power: reset: as3722-poweroff: Use devm_register_sys_off_handler(POWER_OFF)")
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
> ---
Acked-by: Andrew Davis <afd@ti.com>
> v2: Set correct mail address for Sebastian Reichel.
>
> drivers/power/reset/as3722-poweroff.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/power/reset/as3722-poweroff.c b/drivers/power/reset/as3722-poweroff.c
> index bb26fa6fa67ca7..8075382cbc3625 100644
> --- a/drivers/power/reset/as3722-poweroff.c
> +++ b/drivers/power/reset/as3722-poweroff.c
> @@ -57,8 +57,6 @@ static int as3722_poweroff_probe(struct platform_device *pdev)
> SYS_OFF_PRIO_DEFAULT,
> as3722_pm_power_off,
> as3722_poweroff);
> -
> - return 0;
> }
>
> static struct platform_driver as3722_poweroff_driver = {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe
2024-11-17 5:34 [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe Nobuhiro Iwamatsu
2024-11-18 14:10 ` Andrew Davis
@ 2024-12-18 23:45 ` Sebastian Reichel
1 sibling, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2024-12-18 23:45 UTC (permalink / raw)
To: Sebastian Reichel, Laxman Dewangan, Nobuhiro Iwamatsu
Cc: linux-pm, linux-kernel, Andrew Davis
On Sun, 17 Nov 2024 14:34:43 +0900, Nobuhiro Iwamatsu wrote:
> The return is executed on the devm_register_sys_off_handler() line in
> as3722_poweroff_probe, so the last return line is unnecessary. Remove it.
>
>
Applied, thanks!
[1/1] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe
commit: 156fb706f915ceb436200030e3730305bbf12f6c
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-18 23:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-17 5:34 [PATCH v2] power: reset: as3722-poweroff: Remove unnecessary return in as3722_poweroff_probe Nobuhiro Iwamatsu
2024-11-18 14:10 ` Andrew Davis
2024-12-18 23:45 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®