From: Alexandre Bounine <alex.bou9@gmail.com>
To: Colin King <colin.king@canonical.com>,
Matt Porter <mporter@kernel.crashing.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Cc: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rapidio: remove redundant pointer md
Date: Thu, 19 Jul 2018 20:25:12 -0400 [thread overview]
Message-ID: <801e392b-c5ba-2857-c0af-157c65171bfe@gmail.com> (raw)
In-Reply-To: <20180711082346.5223-1-colin.king@canonical.com>
Acked-by: Alexandre Bounine <alex.bou9@gmail.com>
On 2018-07-11 04:23 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer md is being assigned but is never used hence it is redundant
> and can be removed.
>
> Cleans up clang warning:
> warning: variable 'md' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/rapidio/devices/rio_mport_cdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index a8cb8d2f2abb..cbe467ff1aba 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -1006,7 +1006,6 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)
> static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
> {
> struct mport_cdev_priv *priv;
> - struct mport_dev *md;
> struct rio_async_tx_wait w_param;
> struct mport_dma_req *req;
> dma_cookie_t cookie;
> @@ -1016,7 +1015,6 @@ static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
> int ret;
>
> priv = (struct mport_cdev_priv *)filp->private_data;
> - md = priv->md;
>
> if (unlikely(copy_from_user(&w_param, arg, sizeof(w_param))))
> return -EFAULT;
>
prev parent reply other threads:[~2018-07-20 0:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 8:23 Colin King
2018-07-20 0:25 ` Alexandre Bounine [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=801e392b-c5ba-2857-c0af-157c65171bfe@gmail.com \
--to=alex.bou9@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mporter@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®