* [PATCH] rapidio: remove redundant pointer md
@ 2018-07-11 8:23 Colin King
2018-07-20 0:25 ` Alexandre Bounine
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2018-07-11 8:23 UTC (permalink / raw)
To: Matt Porter, Alexandre Bounine, linux-kernel; +Cc: kernel-janitors
From: Colin Ian King <colin.king@canonical.com>
Pointer md is being assigned but is never used hence it is redundant
and can be removed.
Cleans up clang warning:
warning: variable 'md' set but not used [-Wunused-but-set-variable]
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/rapidio/devices/rio_mport_cdev.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
index a8cb8d2f2abb..cbe467ff1aba 100644
--- a/drivers/rapidio/devices/rio_mport_cdev.c
+++ b/drivers/rapidio/devices/rio_mport_cdev.c
@@ -1006,7 +1006,6 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)
static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
{
struct mport_cdev_priv *priv;
- struct mport_dev *md;
struct rio_async_tx_wait w_param;
struct mport_dma_req *req;
dma_cookie_t cookie;
@@ -1016,7 +1015,6 @@ static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
int ret;
priv = (struct mport_cdev_priv *)filp->private_data;
- md = priv->md;
if (unlikely(copy_from_user(&w_param, arg, sizeof(w_param))))
return -EFAULT;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] rapidio: remove redundant pointer md
2018-07-11 8:23 [PATCH] rapidio: remove redundant pointer md Colin King
@ 2018-07-20 0:25 ` Alexandre Bounine
0 siblings, 0 replies; 2+ messages in thread
From: Alexandre Bounine @ 2018-07-20 0:25 UTC (permalink / raw)
To: Colin King, Matt Porter, linux-kernel, Andrew Morton; +Cc: kernel-janitors
Acked-by: Alexandre Bounine <alex.bou9@gmail.com>
On 2018-07-11 04:23 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Pointer md is being assigned but is never used hence it is redundant
> and can be removed.
>
> Cleans up clang warning:
> warning: variable 'md' set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/rapidio/devices/rio_mport_cdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/rapidio/devices/rio_mport_cdev.c b/drivers/rapidio/devices/rio_mport_cdev.c
> index a8cb8d2f2abb..cbe467ff1aba 100644
> --- a/drivers/rapidio/devices/rio_mport_cdev.c
> +++ b/drivers/rapidio/devices/rio_mport_cdev.c
> @@ -1006,7 +1006,6 @@ static int rio_mport_transfer_ioctl(struct file *filp, void __user *arg)
> static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
> {
> struct mport_cdev_priv *priv;
> - struct mport_dev *md;
> struct rio_async_tx_wait w_param;
> struct mport_dma_req *req;
> dma_cookie_t cookie;
> @@ -1016,7 +1015,6 @@ static int rio_mport_wait_for_async_dma(struct file *filp, void __user *arg)
> int ret;
>
> priv = (struct mport_cdev_priv *)filp->private_data;
> - md = priv->md;
>
> if (unlikely(copy_from_user(&w_param, arg, sizeof(w_param))))
> return -EFAULT;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-20 0:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-11 8:23 [PATCH] rapidio: remove redundant pointer md Colin King
2018-07-20 0:25 ` Alexandre Bounine
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®