From: "Anwar, Md Danish" <a0501179@ti.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: MD Danish Anwar <danishanwar@ti.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<srk@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
<r-gunasekaran@ti.com>, Roger Quadros <rogerq@kernel.org>
Subject: Re: [EXTERNAL] Re: [PATCH net v2] net: ti: icssg-prueth: Fix r30 CMDs bitmasks
Date: Wed, 18 Oct 2023 20:05:28 +0530 [thread overview]
Message-ID: <80240b87-4257-9ff4-e24c-5b9211f2dc2b@ti.com> (raw)
In-Reply-To: <a322d1c2-d79a-4b55-92f6-2b98c1f2266e@lunn.ch>
On 10/17/2023 12:09 AM, Andrew Lunn wrote:
>>> How many different versions of REL.PRU-ICSS-ETHERNET-SWITCH have been
>>> released? They don't appear to be part of linux-firmware.git :-(
>>>
>>
>> The firmwares are currently not posted to linux-firmware.git. They are
>> maintained internally as of now. Different version of firmware is
>> released for every SDK release (3-4 times a year)
>
> Clearly, mainline works differently. Ideally you do want to get the
> firmware in linux-firmware.git. The kernel and firmware are then more
> likely to by upgraded at the same time. However, you should not assume
Definitely, we are having discussions on this and soon we'll start
pushing the ICSSG firmware to linux-firmware.git. Till then, we will
maintain firmware internally only.
> so. Maybe in mainline you can then support the last 4 firmware
> versions, and issue an error if a version older than that is found.
>
> However, until the firmware is easily available via linux-firmware,
> you probably should be backwards compatible for a longer period.
>
I understand that. I had discussion with the firmware team and this is
actually not breaking backwards compatibility.
The commands EMAC_PORT_DISABLE and EMAC_PORT_FORWARDING are actually
wrong in the driver.
Firmware is using below bitmasks since the beginning and they were wrong
in the driver. This patch actually fixes this.
{{0xffff0004, 0xffff0100, 0xffff0004, EMAC_NONE}},/* EMAC_PORT_DISABLE */
{{0xffbb0000, 0xfcff0000, 0xdcfb0000, EMAC_NONE}},/* EMAC_PORT_FORWARD */
I tested this patch with older firmware (Version
REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.04) as well as newer firmware
(Version REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05). With this patch both
EMAC_PORT_DISABLE and EMAC_PORT_FORWARD commands are working with both
older and newer firmwares.
Apologies for wrong commit message. I will send next version with proper
commit message mentioning that this patch is backwards compatible
> Andrew
--
Thanks and Regards,
Md Danish Anwar
next prev parent reply other threads:[~2023-10-18 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 16:15 MD Danish Anwar
2023-10-16 16:28 ` Andrew Lunn
2023-10-16 16:56 ` Anwar, Md Danish
2023-10-16 18:39 ` Andrew Lunn
2023-10-18 14:35 ` Anwar, Md Danish [this message]
2023-10-18 14:51 ` [EXTERNAL] " Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80240b87-4257-9ff4-e24c-5b9211f2dc2b@ti.com \
--to=a0501179@ti.com \
--cc=andrew@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®