From: "Anwar, Md Danish" <a0501179@ti.com>
To: Andrew Lunn <andrew@lunn.ch>, MD Danish Anwar <danishanwar@ti.com>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<srk@ti.com>, Vignesh Raghavendra <vigneshr@ti.com>,
<r-gunasekaran@ti.com>, Roger Quadros <rogerq@kernel.org>
Subject: Re: [PATCH net v2] net: ti: icssg-prueth: Fix r30 CMDs bitmasks
Date: Mon, 16 Oct 2023 22:26:24 +0530 [thread overview]
Message-ID: <d7e56794-8061-bf18-bb6f-7525588546fc@ti.com> (raw)
In-Reply-To: <11109e7d-139b-4c8c-beaa-e1e89e355b1b@lunn.ch>
On 10/16/2023 9:58 PM, Andrew Lunn wrote:
> On Mon, Oct 16, 2023 at 09:45:25PM +0530, MD Danish Anwar wrote:
>> The bitmask for EMAC_PORT_DISABLE and EMAC_PORT_FORWARD has been changed
>> in the ICSSG firmware REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05.
>>
>> The current bitmasks are wrong and as a result EMAC_PORT_DISABLE and
>> EMAC_PORT_FORWARD commands doesn not work.
>> Update r30 commands to use the same bitmask as used by the ICSSG firmware
>> REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05.
>>
>> These bitmasks are not backwards compatible. This will work with
>> firmware version REL.PRU-ICSS-ETHERNET-SWITCH_02.02.12.05 and above but
>> not with lower firmware versions.
>
> Breaking backwards compatibility is generally not allowed.
>
> As far as i understand the driver, it loads whatever version of
> firmware is available. It does not ask for a specific version. So you
> should ask the firmware what version it is, and then handle the
> bitmask as appropriate.
>
Understood. I will try to find a way to do this at runtime.
> How many different versions of REL.PRU-ICSS-ETHERNET-SWITCH have been
> released? They don't appear to be part of linux-firmware.git :-(
>
The firmwares are currently not posted to linux-firmware.git. They are
maintained internally as of now. Different version of firmware is
released for every SDK release (3-4 times a year)
> Andrew
>
> ---
> pw-bot: cr
--
Thanks and Regards,
Md Danish Anwar
next prev parent reply other threads:[~2023-10-16 17:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 16:15 MD Danish Anwar
2023-10-16 16:28 ` Andrew Lunn
2023-10-16 16:56 ` Anwar, Md Danish [this message]
2023-10-16 18:39 ` Andrew Lunn
2023-10-18 14:35 ` [EXTERNAL] " Anwar, Md Danish
2023-10-18 14:51 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7e56794-8061-bf18-bb6f-7525588546fc@ti.com \
--to=a0501179@ti.com \
--cc=andrew@lunn.ch \
--cc=danishanwar@ti.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=rogerq@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®