* [PATCH][drm-next] drm/amdgpu: remove duplicate return statement
@ 2017-08-23 13:17 Colin King
2017-08-23 18:24 ` Felix Kuehling
0 siblings, 1 reply; 3+ messages in thread
From: Colin King @ 2017-08-23 13:17 UTC (permalink / raw)
To: Oded Gabbay, Alex Deucher, Christian König, David Airlie,
dri-devel, amd-gfx
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Remove a redundant identical return statement, it has no use.
Detected by CoverityScan, CID#1454586 ("Structurally dead code")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
index fb6e5dbd5a03..309f2419c6d8 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
@@ -155,7 +155,6 @@ static const struct kfd2kgd_calls kfd2kgd = {
struct kfd2kgd_calls *amdgpu_amdkfd_gfx_8_0_get_functions(void)
{
return (struct kfd2kgd_calls *)&kfd2kgd;
- return (struct kfd2kgd_calls *)&kfd2kgd;
}
static inline struct amdgpu_device *get_amdgpu_device(struct kgd_dev *kgd)
--
2.14.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][drm-next] drm/amdgpu: remove duplicate return statement
2017-08-23 13:17 [PATCH][drm-next] drm/amdgpu: remove duplicate return statement Colin King
@ 2017-08-23 18:24 ` Felix Kuehling
2017-08-24 18:26 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Felix Kuehling @ 2017-08-23 18:24 UTC (permalink / raw)
To: Colin King, Oded Gabbay, Alex Deucher, Christian König,
David Airlie, dri-devel, amd-gfx
Cc: kernel-janitors, linux-kernel
I must have added that accidentally when cherry-picking an internal
patch for upstreaming. Thanks for catching it.
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Regards,
Felix
On 2017-08-23 09:17 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Remove a redundant identical return statement, it has no use.
>
> Detected by CoverityScan, CID#1454586 ("Structurally dead code")
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
> index fb6e5dbd5a03..309f2419c6d8 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
> @@ -155,7 +155,6 @@ static const struct kfd2kgd_calls kfd2kgd = {
> struct kfd2kgd_calls *amdgpu_amdkfd_gfx_8_0_get_functions(void)
> {
> return (struct kfd2kgd_calls *)&kfd2kgd;
> - return (struct kfd2kgd_calls *)&kfd2kgd;
> }
>
> static inline struct amdgpu_device *get_amdgpu_device(struct kgd_dev *kgd)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH][drm-next] drm/amdgpu: remove duplicate return statement
2017-08-23 18:24 ` Felix Kuehling
@ 2017-08-24 18:26 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2017-08-24 18:26 UTC (permalink / raw)
To: Felix Kuehling
Cc: Colin King, Oded Gabbay, Alex Deucher, Christian König,
David Airlie, Maling list - DRI developers, amd-gfx list,
kernel-janitors, LKML
On Wed, Aug 23, 2017 at 2:24 PM, Felix Kuehling <felix.kuehling@amd.com> wrote:
> I must have added that accidentally when cherry-picking an internal
> patch for upstreaming. Thanks for catching it.
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Applied. thanks!
Alex
>
> Regards,
> Felix
>
>
> On 2017-08-23 09:17 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> Remove a redundant identical return statement, it has no use.
>>
>> Detected by CoverityScan, CID#1454586 ("Structurally dead code")
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
>> index fb6e5dbd5a03..309f2419c6d8 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v8.c
>> @@ -155,7 +155,6 @@ static const struct kfd2kgd_calls kfd2kgd = {
>> struct kfd2kgd_calls *amdgpu_amdkfd_gfx_8_0_get_functions(void)
>> {
>> return (struct kfd2kgd_calls *)&kfd2kgd;
>> - return (struct kfd2kgd_calls *)&kfd2kgd;
>> }
>>
>> static inline struct amdgpu_device *get_amdgpu_device(struct kgd_dev *kgd)
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-08-24 18:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-23 13:17 [PATCH][drm-next] drm/amdgpu: remove duplicate return statement Colin King
2017-08-23 18:24 ` Felix Kuehling
2017-08-24 18:26 ` Alex Deucher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®