From: Julia Lawall <julia.lawall@inria.fr>
To: Deepak R Varma <drv@mailo.com>
Cc: outreachy@lists.linux.dev, gregkh@linuxfoundation.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
kumarpraveen@linux.microsoft.com, saurabh.truth@gmail.com
Subject: Re: [PATCH v2] staging: most: dim2: read done_buffers count locally from HDM channel
Date: Tue, 18 Oct 2022 14:52:21 +0200 (CEST) [thread overview]
Message-ID: <80696861-c73f-cdb9-b4e1-36c29ece78bb@inria.fr> (raw)
In-Reply-To: <Y06g2llpa5S/025M@debian-BULLSEYE-live-builder-AMD64>
On Tue, 18 Oct 2022, Deepak R Varma wrote:
> On Tue, Oct 18, 2022 at 09:39:08AM +0200, Julia Lawall wrote:
> >
> >
> > On Tue, 18 Oct 2022, Deepak R Varma wrote:
> >
> > > The done_buffer count is already available in the hdm_channel struct.
> > > Calling dim_get_channel_state function to source this value out of
> > > the same structure is unnecessary.
> > > Further, the second parameter struct dim_ch_state_t to this function
> > > is filled by using the hdm_channel inside the function. This filled in
> > > variable is never used in the caller and can be altogether removed.
> > > So, a call to dim_get_channel_state function in this context also
> > > deems expensive.
> >
> > Thanks for the rewrite.
> >
> > I find "source this value out of" hard to understand.
> >
> > I would have written something like the following:
> >
> > The function dim_get_channel_state only serves to initialize the ready and
> > done_buffers fields of the structure passed as its second argument. In
> > service_done_flag, this structure is never used again and the only purpose
> > of the call is to get the value that is put in the done_buffers field.
> > But that value is just the done_sw_buffers_number field of the call's
> > first argument. So the whole call is useless, and we can just replace it
> > with an access to this field.
> >
> > This change implies that the variable st is no longer used, so drop it as
> > well.
>
> This is really well written. Sounds much structured. Now my own log message
> sounds a little random :)
>
> Is it okay for me to use your verbiage as is in my patch log?
Yes.
julia
next prev parent reply other threads:[~2022-10-18 12:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 7:18 Deepak R Varma
2022-10-18 7:39 ` Julia Lawall
2022-10-18 12:49 ` Deepak R Varma
2022-10-18 12:52 ` Julia Lawall [this message]
2022-10-18 13:48 ` Deepak R Varma
2022-10-18 14:19 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=80696861-c73f-cdb9-b4e1-36c29ece78bb@inria.fr \
--to=julia.lawall@inria.fr \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=kumarpraveen@linux.microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy@lists.linux.dev \
--cc=saurabh.truth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®