From: Andrew Lunn <andrew@lunn.ch>
To: Li Yang <leoyang.li@nxp.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
David Bauer <mail@david-bauer.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Viorel Suman <viorel.suman@nxp.com>, Wei Fang <wei.fang@nxp.com>
Subject: Re: [PATCH v3 1/2] net: phy: at803x: fix the wol setting functions
Date: Sat, 29 Jul 2023 10:14:06 +0200 [thread overview]
Message-ID: <8071d8c5-1da3-47a0-9da2-a64ee80db6e5@lunn.ch> (raw)
In-Reply-To: <20230728215320.31801-2-leoyang.li@nxp.com>
On Fri, Jul 28, 2023 at 04:53:19PM -0500, Li Yang wrote:
> In commit 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"), it
> seems not correct to use a wol_en bit in a 1588 Control Register which is
> only available on AR8031/AR8033(share the same phy_id) to determine if WoL
> is enabled. Change it back to use AT803X_INTR_ENABLE_WOL for determining
> the WoL status which is applicable on all chips supporting wol. Also update
> the at803x_set_wol() function to only update the 1588 register on chips
> having it.
Do chips which do not have the 1588 register not have WoL? Or WoL
hardware is always enabled, but you still need to enable the
interrupt.
Have you tested on a range of PHY? It might be better to split this
patch up a bit. If it causes regressions, having smaller patches can
make it easier to find which change broken it.
Andrew
next prev parent reply other threads:[~2023-07-29 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 21:53 [PATCH v3 0/2] fix at803x wol setting Li Yang
2023-07-28 21:53 ` [PATCH v3 1/2] net: phy: at803x: fix the wol setting functions Li Yang
2023-07-29 8:14 ` Andrew Lunn [this message]
2023-07-31 14:58 ` Leo Li
2023-08-01 9:16 ` Paolo Abeni
2023-08-02 9:50 ` Jie Luo
2023-08-02 10:22 ` Russell King (Oracle)
2023-08-02 18:43 ` Leo Li
2023-07-28 21:53 ` [PATCH v3 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032 Li Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8071d8c5-1da3-47a0-9da2-a64ee80db6e5@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mail@david-bauer.net \
--cc=netdev@vger.kernel.org \
--cc=viorel.suman@nxp.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®